<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 14, 2016 at 6:51 PM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I've been made aware of:</div><div><br></div><div>commit 195937c2da592d9993ada7609aea84<wbr>f64523a711</div><div>Author: Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></div><div>Date: Sun Oct 9 20:05:36 2016 +0300</div><div><br></div><div> build: Disable tests during build</div><div> </div><div> Tests are needed for development, not for building a package. This</div><div> allows us to use latest and greatest development tools, which are not</div><div> available in brew or koji.</div><div><br></div><div><br></div><div>Please note that the spec file in current state is doing the opposite of what's recommended by Fedora guidelines[1]<br></div><div>Tests are not mandatory according to the guidelines but they're highly recommended.</div><div><br></div><div>[1] <a href="https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites" target="_blank">https://fedoraproject.org/<wbr>wiki/Packaging:Guidelines#<wbr>Test_Suites</a></div><span class="HOEnZb"><font color="#888888"><div><br></div></font></span></div></blockquote><div><br></div><div>We break some more fedora guidelines. we need someone to help with that in vdsm group. we raised it last vdsm call. anyone? we have bunch of interesting issues in our packing method that we can improve </div><div>please add this issue to the vdsm-trello board for follow up - adding back test phase in vdsm spec. maybe it'll be easier once pytest will work</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="HOEnZb"><font color="#888888"><div></div>-- <br><div class="m_-5805728985341010462gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</div></div>