<p dir="ltr"></p>
<p dir="ltr">Il 20/Nov/2016 16:06, "Barak Korren" <<a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a>> ha scritto:<br>
><br>
> Hi all,<br>
><br>
> Perhaps the main purpose of CI, is to prevent braking code from<br>
> getting merged into the stable/master branches. Unfortunately our CI<br>
> is not there yet, and one of the reasons for that is that we do large<br>
> amount of our CI tests only _after_ the code is merged.<br>
><br>
> The reason for that is that when balancing through, but time<br>
> consuming, tests (e.g. enging build with all permutations) v.s. faster<br>
> but more basic ones (e.g. "findbugs" and single permutation build), we<br>
> typically choose the faster tests to be run per-patch-set and leave<br>
> the through testing to only be run post-merge.<br>
><br>
> We'd like to change that and have the through tests also run before<br>
> merge. </p>
<p dir="ltr">Hopefully not the same tests ☺<br></p>
<p dir="ltr">Ideally we would like to just hook stuff to the "submit"<br>
> button, but Gerrit doesn't allow one to do that easily. So instead<br>
> we'll need to adopt some kind of flag to indicate we want to submit<br>
> and have Jenkins<br>
> "click" the submit button on our behalf if tests pass.<br>
><br>
> I see two options here:<br>
> 1. Use Code-Review+2 as the indicator to run "heavy" CI and merge.<br>
> 2. Add an "approve" flag that maintainers can set to +1 (This is<br>
> what OpenStack is doing).<br>
><br>
> What would you prefer?</p>
<p dir="ltr">I would prefer to follow openstack example. Will help developers to have same flow in both projects.<br><br></p>
<p dir="ltr">><br>
> --<br>
> Barak Korren<br>
> <a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a><br>
> RHEV-CI Team<br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/mailman/listinfo/devel</a><br></p>