<div dir="ltr"><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 24, 2016 at 10:37 AM, Martin Perina <span dir="ltr"><<a target="_blank" href="mailto:mperina@redhat.com">mperina@redhat.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 24, 2016 at 9:31 AM, Eyal Edri <span dir="ltr"><<a target="_blank" href="mailto:eedri@redhat.com">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Can you paste here example of such job failing now?</div></blockquote><div><br><div>Sure, please take a look at patch <a target="_blank" href="https://gerrit.ovirt.org/66999">https://gerrit.ovirt.org/66999</a><wbr></div> <br><div style="font-family:arial,helvetica,sans-serif">I've rebased it yesterday at 23:22 and upgrade from master job failed due to the error I've described below:<br><br><a target="_blank" href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_created/9295/">http://jenkins.ovirt.org/job/<wbr>ovirt-engine_master_upgrade-<wbr>from-master_el7_created/9295/</a><br><br></div><div style="font-family:arial,helvetica,sans-serif">Although at that moment patch<div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default"></div> <a target="_blank" href="https://gerrit.ovirt.org/67210">https://gerrit.ovirt.org/67210</a> , which fixed faulty revert patch [1], was already merged, so engine-setup should execute successfully.<br><br></div><div style="font-family:arial,helvetica,sans-serif">I've just scheduled another build on the same patch (there was no rebase at this time), so you can compare the results.<br></div></div></div></div></div></blockquote><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default">So today's build finished fine, which is strange, because</div> <div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default">patch <a target="_blank" href="https://gerrit.ovirt.org/67210">https://gerrit.ovirt.org/67210</a> haven't been rebased, so upgrade from master should fail same way as yesterday -> so it seems that upgrade from master caches somewhere git hash, which is used as a startup for db upgrade job and not always using actual latest commit from master<br><br></div></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">Martin<br></div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 24, 2016 at 9:42 AM, Martin Perina <span dir="ltr"><<a target="_blank" href="mailto:mperina@redhat.com">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I don't know what exactly upgrade from master job is doing, but according to error produced by engine-setup it does not take latest patch merged to master to prepare initial db on which we try to execute upgrade. It take the revert patch, which is faulty and that's why upgrade job is failing. <br><span class="gmail-m_-3293010814662540398gmail-m_3907584255360980742HOEnZb"><font color="#888888"><br>Martin <br></font></span><div class="gmail-m_-3293010814662540398gmail-m_3907584255360980742HOEnZb"><div class="gmail-m_-3293010814662540398gmail-m_3907584255360980742h5"><br>On Thursday, November 24, 2016, Eyal Edri <<a target="_blank" href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>> What does it mean to clean the jobs? You mean git history or temp files?<br>><br>> On Nov 24, 2016 1:23 AM, "Martin Perina" <<a target="_blank" href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>>><br>>> So, I tested current master and also upgrade from 4.0 to master and everything works fine on my local machine.<br>>><br>>> But I've found 2 issues:<br>>><br>>> 1. Jenkins CI for some reason unknown to me doesn't use current master (change-id: I59087ff8902e35b9f7c922eba0a17<wbr>ba4f0791795) but it uses older commit (most probably revert patch from Eyal [1] with Change-Id: I8c2350aba48619dfa84624b343cfa<wbr>167d0b6e0ed).as a current master when executing upgrade job from master to patch<br>>><br>>> 2. When we are reverting patches which contain db upgrade scripts which are not last (for example we are dropping db script 04_01_0500 when there's already merged script 04_01_0510) we cannot delete upgrade script otherwise db schema upgrade script fails (revert script [1] is faulty). Only following actions are valid in this case:<br>>><br>>> a. Comment out code in db upgrade script we want to revert, but leave this script in the repo<br>>><br>>> b. Remove the db upgrade script and renumber all later db upgrade scripts so there's no hole in db upgrade script numbering<br>>><br>>> Conclusion: current code in master is OK, we need clean up jenkins job to really use latest merged patch on git master branch.<br>>><br>>> Martin<br>>><br>>><br>>> [1] <a target="_blank" href="https://gerrit.ovirt.org/#/c/67205/">https://gerrit.ovirt.org/#/c/6<wbr>7205/</a><br>>><br>>><br>>> On Wed, Nov 23, 2016 at 7:17 PM, Michal Skrivanek <<a target="_blank" href="mailto:mskrivan@redhat.com">mskrivan@redhat.com</a>> wrote:<br>>>><br>>>><br>>>> > On 23 Nov 2016, at 17:44, Martin Sivak <<a target="_blank" href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br>>>> ><br>>>> > Yeah, our patches are still failing as well. It seems the patch was<br>>>> > not enough or there is some other conflicting db script.<br>>>><br>>>> I think the hash changed. IIRC there was some issue in the logic when the existing script is updated (since it was merged and reverted and re-merged with the same number, but it was not the exact same content)<br>>>> Martin/Eli to the rescue!<br>>>><br>>>> ><br>>>> > Martin<br>>>> ><br>>>> >> On Wed, Nov 23, 2016 at 2:16 PM, Sandro Bonazzola <<a target="_blank" href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>>>> >><br>>>> >><br>>>> >>> On Wed, Nov 23, 2016 at 2:13 PM, Arik Hadas <<a target="_blank" href="mailto:ahadas@redhat.com">ahadas@redhat.com</a>> wrote:<br>>>> >>><br>>>> >>> it should be fixed now (by <a target="_blank" href="https://gerrit.ovirt.org/#/c/67210/">https://gerrit.ovirt.org/#/c/6<wbr>7210/</a>)<br>>>> >><br>>>> >><br>>>> >> I rebased <a target="_blank" href="https://gerrit.ovirt.org/66999">https://gerrit.ovirt.org/66999</a> and still failing there.<br>>>> >><br>>>> >><br>>>> >>><br>>>> >>> ----- Original Message -----<br>>>> >>>> engine master CI is failing on $subject, please fix or revert as soon as<br>>>> >>>> possible, thanks.<br>>>> >>>><br>>>> >>>> --<br>>>> >>>> Sandro Bonazzola<br>>>> >>>> Better technology. Faster innovation. Powered by community<br>>>> >>>> collaboration.<br>>>> >>>> See how it works at <a target="_blank" href="http://redhat.com">redhat.com</a><br>>>> >>>><br>>>> >>>> ______________________________<wbr>_________________<br>>>> >>>> Devel mailing list<br>>>> >>>> <a target="_blank" href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>>>> >>>> <a target="_blank" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>>>> >><br>>>> >><br>>>> >><br>>>> >><br>>>> >> --<br>>>> >> Sandro Bonazzola<br>>>> >> Better technology. Faster innovation. Powered by community collaboration.<br>>>> >> See how it works at <a target="_blank" href="http://redhat.com">redhat.com</a><br>>>> >><br>>>> >> ______________________________<wbr>_________________<br>>>> >> Devel mailing list<br>>>> >> <a target="_blank" href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>>>> >> <a target="_blank" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>>>> > ______________________________<wbr>_________________<br>>>> > Devel mailing list<br>>>> > <a target="_blank" href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>>>> > <a target="_blank" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>>>> ><br>>>> ><br>>><br>>
</div></div></blockquote></div><span class="gmail-m_-3293010814662540398gmail-HOEnZb"><font color="#888888"><br><br clear="all"><span class="gmail-HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="gmail-m_-3293010814662540398gmail-m_3907584255360980742gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: <a target="_blank" href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</font></span></font></span></div>
</blockquote></div><br></div></div>
</blockquote></div><br></div></div>