<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 24, 2016 at 11:25 AM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Nov 24, 2016 at 12:21 PM, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
><br>
><br>
> On Thu, Nov 24, 2016 at 10:37 AM, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Thu, Nov 24, 2016 at 9:31 AM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
>>><br>
>>> Can you paste here example of such job failing now?<br>
>><br>
>><br>
>> Sure, please take a look at patch <a href="https://gerrit.ovirt.org/66999" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/66999</a><br>
>><br>
>> I've rebased it yesterday at 23:22 and upgrade from master job failed due<br>
>> to the error I've described below:<br>
>><br>
>><br>
>> <a href="http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_created/9295/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine_master_upgrade-<wbr>from-master_el7_created/9295/</a><br>
>><br>
>> Although at that moment patch<br>
>> <a href="https://gerrit.ovirt.org/67210" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/67210</a> , which fixed faulty revert patch [1], was<br>
>> already merged, so engine-setup should execute successfully.<br>
>><br>
>> I've just scheduled another build on the same patch (there was no rebase<br>
>> at this time), so you can compare the results.<br>
><br>
><br>
> So today's build finished fine, which is strange, because<br>
><br>
> patch <a href="https://gerrit.ovirt.org/67210" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/67210</a> haven't been rebased, so upgrade from<br>
> master should fail same way as yesterday -> so it seems that upgrade from<br>
> master caches somewhere git hash, which is used as a startup for db upgrade<br>
> job and not always using actual latest commit from master<br>
<br>
AFAIU the upgrade job upgrade from the latest nightly master snapshot<br>
build, not from git.<br>
So after you merge such a patch and its builds are finished, you have<br>
to run the publisher.<br></blockquote><div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Well, it that case the logic of "upgrade from master" job is a bit misleading, because it's "upgrade from yesterday's master" actually ...<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
><br>
>><br>
>> Martin<br>
>><br>
>>><br>
>>> On Thu, Nov 24, 2016 at 9:42 AM, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>><br>
>>> wrote:<br>
>>>><br>
>>>> I don't know what exactly upgrade from master job is doing, but<br>
>>>> according to error produced by engine-setup it does not take latest patch<br>
>>>> merged to master to prepare initial db on which we try to execute upgrade.<br>
>>>> It take the revert patch, which is faulty and that's why upgrade job is<br>
>>>> failing.<br>
>>>><br>
>>>> Martin<br>
>>>><br>
>>>> On Thursday, November 24, 2016, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
>>>> > What does it mean to clean the jobs? You mean git history or temp<br>
>>>> > files?<br>
>>>> ><br>
>>>> > On Nov 24, 2016 1:23 AM, "Martin Perina" <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
>>>> >><br>
>>>> >> So, I tested current master and also upgrade from 4.0 to master and<br>
>>>> >> everything works fine on my local machine.<br>
>>>> >><br>
>>>> >> But I've found 2 issues:<br>
>>>> >><br>
>>>> >> 1. Jenkins CI for some reason unknown to me doesn't use current<br>
>>>> >> master (change-id: I59087ff8902e35b9f7c922eba0a17<wbr>ba4f0791795) but it uses<br>
>>>> >> older commit (most probably revert patch from Eyal [1] with Change-Id:<br>
>>>> >> I8c2350aba48619dfa84624b343cfa<wbr>167d0b6e0ed).as a current master when<br>
>>>> >> executing upgrade job from master to patch<br>
>>>> >><br>
>>>> >> 2. When we are reverting patches which contain db upgrade scripts<br>
>>>> >> which are not last (for example we are dropping db script 04_01_0500 when<br>
>>>> >> there's already merged script 04_01_0510) we cannot delete upgrade script<br>
>>>> >> otherwise db schema upgrade script fails (revert script [1] is faulty). Only<br>
>>>> >> following actions are valid in this case:<br>
>>>> >><br>
>>>> >> a. Comment out code in db upgrade script we want to revert, but<br>
>>>> >> leave this script in the repo<br>
>>>> >><br>
>>>> >> b. Remove the db upgrade script and renumber all later db upgrade<br>
>>>> >> scripts so there's no hole in db upgrade script numbering<br>
>>>> >><br>
>>>> >> Conclusion: current code in master is OK, we need clean up jenkins<br>
>>>> >> job to really use latest merged patch on git master branch.<br>
>>>> >><br>
>>>> >> Martin<br>
>>>> >><br>
>>>> >><br>
>>>> >> [1] <a href="https://gerrit.ovirt.org/#/c/67205/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>67205/</a><br>
>>>> >><br>
>>>> >><br>
>>>> >> On Wed, Nov 23, 2016 at 7:17 PM, Michal Skrivanek<br>
>>>> >> <<a href="mailto:mskrivan@redhat.com">mskrivan@redhat.com</a>> wrote:<br>
>>>> >>><br>
>>>> >>><br>
>>>> >>> > On 23 Nov 2016, at 17:44, Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br>
>>>> >>> ><br>
>>>> >>> > Yeah, our patches are still failing as well. It seems the patch<br>
>>>> >>> > was<br>
>>>> >>> > not enough or there is some other conflicting db script.<br>
>>>> >>><br>
>>>> >>> I think the hash changed. IIRC there was some issue in the logic<br>
>>>> >>> when the existing script is updated (since it was merged and reverted and<br>
>>>> >>> re-merged with the same number, but it was not the exact same content)<br>
>>>> >>> Martin/Eli to the rescue!<br>
>>>> >>><br>
>>>> >>> ><br>
>>>> >>> > Martin<br>
>>>> >>> ><br>
>>>> >>> >> On Wed, Nov 23, 2016 at 2:16 PM, Sandro Bonazzola<br>
>>>> >>> >> <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >>> On Wed, Nov 23, 2016 at 2:13 PM, Arik Hadas <<a href="mailto:ahadas@redhat.com">ahadas@redhat.com</a>><br>
>>>> >>> >>> wrote:<br>
>>>> >>> >>><br>
>>>> >>> >>> it should be fixed now (by <a href="https://gerrit.ovirt.org/#/c/67210/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>67210/</a>)<br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >> I rebased <a href="https://gerrit.ovirt.org/66999" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/66999</a> and still failing there.<br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >>><br>
>>>> >>> >>> ----- Original Message -----<br>
>>>> >>> >>>> engine master CI is failing on $subject, please fix or revert<br>
>>>> >>> >>>> as soon as<br>
>>>> >>> >>>> possible, thanks.<br>
>>>> >>> >>>><br>
>>>> >>> >>>> --<br>
>>>> >>> >>>> Sandro Bonazzola<br>
>>>> >>> >>>> Better technology. Faster innovation. Powered by community<br>
>>>> >>> >>>> collaboration.<br>
>>>> >>> >>>> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
>>>> >>> >>>><br>
>>>> >>> >>>> ______________________________<wbr>_________________<br>
>>>> >>> >>>> Devel mailing list<br>
>>>> >>> >>>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>>>> >>> >>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >><br>
>>>> >>> >> --<br>
>>>> >>> >> Sandro Bonazzola<br>
>>>> >>> >> Better technology. Faster innovation. Powered by community<br>
>>>> >>> >> collaboration.<br>
>>>> >>> >> See how it works at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a><br>
>>>> >>> >><br>
>>>> >>> >> ______________________________<wbr>_________________<br>
>>>> >>> >> Devel mailing list<br>
>>>> >>> >> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>>>> >>> >> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>>>> >>> > ______________________________<wbr>_________________<br>
>>>> >>> > Devel mailing list<br>
>>>> >>> > <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>>>> >>> > <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>>>> >>> ><br>
>>>> >>> ><br>
>>>> >><br>
>>>> ><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Eyal Edri<br>
>>> Associate Manager<br>
>>> RHV DevOps<br>
>>> EMEA ENG Virtualization R&D<br>
>>> Red Hat Israel<br>
>>><br>
>>> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
>><br>
>><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Didi<br>
</font></span></blockquote></div><br></div></div>