<div dir="ltr"><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">So, I tested current master and also upgrade from 4.0 to master and everything works fine on my local machine.<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">But I've found 2 issues:<br><br>1. Jenkins CI for some reason unknown to me doesn't use current master (change-id: I59087ff8902e35b9f7c922eba0a17ba4f0791795) but it uses older commit (most probably revert patch from Eyal [1] with Change-Id: I8c2350aba48619dfa84624b343cfa167d0b6e0ed).as a current master when executing upgrade job from master to patch<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">2. When we are reverting patches which contain db upgrade scripts which are not last (for example we are dropping db script 04_01_0500 when there's already merged script 04_01_0510) we cannot delete upgrade script otherwise db schema upgrade script fails (revert script [1] is faulty). Only following actions are valid in this case:<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"> a. Comment out code in db upgrade script we want to revert, but leave this script in the repo<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"> b. Remove the db upgrade script and renumber all later db upgrade scripts so there's no hole in db upgrade script numbering<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Conclusion: current code in master is OK, we need clean up jenkins job to really use latest merged patch on git master branch.<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">Martin<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><br>[1] <a href="https://gerrit.ovirt.org/#/c/67205/">https://gerrit.ovirt.org/#/c/67205/</a><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 23, 2016 at 7:17 PM, Michal Skrivanek <span dir="ltr"><<a target="_blank" href="mailto:mskrivan@redhat.com">mskrivan@redhat.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><br>
<br>
> On 23 Nov 2016, at 17:44, Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br>
><br>
> Yeah, our patches are still failing as well. It seems the patch was<br>
> not enough or there is some other conflicting db script.<br>
<br>
I think the hash changed. IIRC there was some issue in the logic when the existing script is updated (since it was merged and reverted and re-merged with the same number, but it was not the exact same content)<br>
Martin/Eli to the rescue!<br>
<br>
><br>
> Martin<br>
><br>
>> On Wed, Nov 23, 2016 at 2:16 PM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
>><br>
>><br>
>>> On Wed, Nov 23, 2016 at 2:13 PM, Arik Hadas <<a href="mailto:ahadas@redhat.com">ahadas@redhat.com</a>> wrote:<br>
>>><br>
>>> it should be fixed now (by <a target="_blank" rel="noreferrer" href="https://gerrit.ovirt.org/#/c/67210/">https://gerrit.ovirt.org/#/c/<wbr>67210/</a>)<br>
>><br>
>><br>
>> I rebased <a target="_blank" rel="noreferrer" href="https://gerrit.ovirt.org/66999">https://gerrit.ovirt.org/66999</a> and still failing there.<br>
>><br>
>><br>
>>><br>
>>> ----- Original Message -----<br>
>>>> engine master CI is failing on $subject, please fix or revert as soon as<br>
>>>> possible, thanks.<br>
>>>><br>
>>>> --<br>
>>>> Sandro Bonazzola<br>
>>>> Better technology. Faster innovation. Powered by community<br>
>>>> collaboration.<br>
>>>> See how it works at <a target="_blank" rel="noreferrer" href="http://redhat.com">redhat.com</a><br>
>>>><br>
>>>> ______________________________<wbr>_________________<br>
>>>> Devel mailing list<br>
>>>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>>>> <a target="_blank" rel="noreferrer" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Sandro Bonazzola<br>
>> Better technology. Faster innovation. Powered by community collaboration.<br>
>> See how it works at <a target="_blank" rel="noreferrer" href="http://redhat.com">redhat.com</a><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> Devel mailing list<br>
>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>> <a target="_blank" rel="noreferrer" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a target="_blank" rel="noreferrer" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
><br>
><br>
</blockquote></div><br></div></div>