<div dir="ltr">Hi Vojtech,<div><br></div><div>I posted a patch [1] for this, so the change isn't merged yet.</div><div>We thought of using the 'minimal' macro for it.</div><div><br></div><div>Can you send your suggestion to the patch? </div><div><br></div><div><br></div><div>[1] <a href="https://gerrit.ovirt.org/#/c/67269/">https://gerrit.ovirt.org/#/c/67269/</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 25, 2016 at 8:43 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span class=""><br>
> Any patches sent on this?<br>
<br>
</span>I'd like to help.<br>
<br>
Looking at the recent Engine (master) build:<br>
<br>
<a href="http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64/1691/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-engine_master_build-<wbr>artifacts-el7-x86_64/1691/</a><br>
<br>
$ rpm -qlp ovirt-engine-webadmin-portal-<wbr>4.1.0-0.0.master.<wbr>20161125171318.gitae69c34.el7.<wbr>centos.noarch.rpm<br>
<br>
it shows we still build all [browser x language] GWT permutations,<br>
basically there are tons of <md5>.cache.js files in `webadmin.war`<br>
directory (each one represents a single permutation).<br>
<br>
In automation/build-artifacts.sh, we could add some variable that<br>
controls what kind of GWT build to do (e.g. GWT_BUILD_MODE):<br>
<br>
1, snapshot GWT build: all supported browsers x en_US (only)<br>
=> 3 x 1 = 3 GWT permutations<br>
<br>
2, full GWT build: all supported browsers x all supported locales<br>
=> 3 x 9 = 27 (!) GWT permutations<br>
<br>
With "snapshot GWT build", we should do:<br>
<br>
rpmbuild \<br>
.. existing stuff<br>
-D "ovirt_build_locales 0" \<br>
.. existing stuff<br>
<br>
GWT_BUILD_MODE can default to "full GWT build".<br>
<br>
But how do we override GWT_BUILD_MODE when doing non-release builds?<br>
<br>
Regards,<br>
Vojtech<br>
<br>
<br>
----- Original Message -----<br>
> From: "eyal edri [Administrator] (oVirt JIRA)" <<a href="mailto:jira@ovirt-jira.atlassian.net">jira@ovirt-jira.atlassian.net</a><wbr>><br>
> To: <a href="mailto:infra@ovirt.org">infra@ovirt.org</a><br>
> Sent: Sunday, November 6, 2016 4:29:02 PM<br>
> Subject: [JIRA] (OVIRT-416) [standard-ci] build-artifacts should reuse the artifacts built on check-merged if any<br>
><br>
><br>
> [<br>
<div class="HOEnZb"><div class="h5">> <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22321#comment-22321" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-416?page=com.<wbr>atlassian.jira.plugin.system.<wbr>issuetabpanels:comment-<wbr>tabpanel&focusedCommentId=<wbr>22321#comment-22321</a><br>
> ]<br>
><br>
> eyal edri [Administrator] commented on OVIRT-416:<br>
> ------------------------------<wbr>-------------------<br>
><br>
> Any patches sent on this?<br>
> Also, wanted to mention #OVIRT-751 is handling similar purpose with enabling<br>
> better maven caching, so it might suffice as a starting point in optimizing<br>
> ovirt-engine runtime for builds.<br>
><br>
> > [standard-ci] build-artifacts should reuse the artifacts built on<br>
> > check-merged if any<br>
> > ------------------------------<wbr>------------------------------<wbr>-------------------------<br>
> ><br>
> > Key: OVIRT-416<br>
> > URL: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-416" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-416</a><br>
> > Project: oVirt - virtualization made easy<br>
> > Issue Type: Improvement<br>
> > Reporter: David Caro Estevez<br>
> > Assignee: infra<br>
> ><br>
> > Right now most projects just rebuild twice the artifacts, what for some<br>
> > means a big waste of resources, if we could just reuse what was built<br>
> > previously there would be no rebuilding.<br>
> > Something to take into account is that the distributions that check-merged<br>
> > and build-artifacts run for might not match, so you can be running<br>
> > check-merged only on fc23 but building artifacts for fc23, fc22 an el7 (as<br>
> > an example), maybe we should not allow different distros on each stage?|<br>
><br>
><br>
><br>
> --<br>
> This message was sent by Atlassian JIRA<br>
> (v1000.499.4#100018)<br>
> ______________________________<wbr>_________________<br>
> Infra mailing list<br>
> <a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a><br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>