<div dir="ltr">I don't see any options to control this from project config, it will require more investigating to see if its a config option or only available via cherry-pick.<div>opening a ticket to track this.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Nov 27, 2016 at 1:38 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Nov 27, 2016 at 12:31:21PM +0200, Eyal Edri wrote:<br>
> Not sure I understand what do you mean by Gerrit Headers.<br>
> Can you give examples?<br>
><br>
> On Fri, Nov 25, 2016 at 4:57 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br>
><br>
> > On Fri, Nov 25, 2016 at 4:45 PM, Tomáš Golembiovský <<a href="mailto:tgolembi@redhat.com">tgolembi@redhat.com</a>><br>
> > wrote:<br>
> > > Hi,<br>
> > ><br>
> > > I've noticed that in vdsm repo the merged commits do not contain the<br>
> > > info headers added by Gerrit any more (Reviewed-by/Reviewed-on/etc.)<wbr>.<br>
> > ><br>
> > > Is that intentional? If yes, what was the motivation behind this?<br>
> > ><br>
> > > The change seem to have happened about 4 days ago. Sometime between the<br>
> > > following two commits:<br>
> > ><br>
> > > * 505f5da API: Introduce getQemuImageInfo API. [Maor Lipchuk]<br>
> > > * 1c4a39c protocoldetector: Avoid unneeded getpeername() [Nir Soffer]<br>
> ><br>
> > We switched vdsm to fast-forward 4 days ago, maybe this was unintended<br>
> > side effect of this change?<br>
> ><br>
> > The gerrit headers are very useful, please add back.<br>
<br>
<br>
</span><a href="https://gerrit.ovirt.org/#/c/66295/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>66295/</a> is the last one which had them:<br>
<span class=""><br>
Reviewed-on: <a href="https://gerrit.ovirt.org/66295" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/66295</a><br>
Reviewed-by: Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>><br>
Continuous-Integration: Jenkins CI<br>
<br>
</span>they are added to the commit message during cherry-pick, and I find them<br>
very useful.<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>