<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 8, 2016 at 10:12 AM, Martin Polednik <span dir="ltr"><<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/12/16 09:28 +0200, Edward Haas wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Wed, Dec 7, 2016 at 11:54 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
broken_on_ci is uses default name="OVIRT_CI", to mark it also for<br>
travis, we need another broken_on_ci with name="TRAVIS_CI".<br>
<br>
Maybe this test should run only if nm is active on the machine?<br>
<br>
</blockquote>
<br>
We need the test to always run when expected.<br>
If NM is not running, the test will not run (silently) and we will never<br>
know if there is a problem or not.<br>
<br>
It is not convenient to mark each CI type as broken, why the test code<br>
needs to know we have multiple<br>
CI/s?<br>
</blockquote>
<br></span>
I believe this is great point - we should just mark the test as broken<br>
on *any* CI to create a pressure to get it fixed.<br>
<br>
Slight off-topic addition: I don't understand why patch marking a test<br>
as broken on CI takes more than 5 minutes to get merged in when given<br>
pointer to the failure.</blockquote><div><br></div><div>Because it is a wrong approach. :)<br></div><div>If a test fails, it is a smell that something bad happens and we may have a<br></div><div>production problem.<br></div><div>So before marking and excluding the test, one should feel very guilty that<br></div><div>this check is no longer covered and better understand why it fails.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Currently, we run on CI tests that are not marked as 'functional'.<br>
Perhaps we need another test type that can be mark not to run on simple CI.<br>
"power-integration", "super-integration"?<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Wed, Dec 7, 2016 at 11:23 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>> wrote:<br>
> On Wed, Dec 7, 2016 at 2:03 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
>> Looks like we need @brokentest("reason...", name="TRAVIC_CI") on this:<br>
><br>
> Odd, the code already has<br>
><br>
> @broken_on_ci('NetworkManager should not be started on CI nodes')<br>
><br>
><br>
>><br>
>> See <a href="https://travis-ci.org/oVirt/vdsm/jobs/181933329" rel="noreferrer" target="_blank">https://travis-ci.org/oVirt/vd<wbr>sm/jobs/181933329</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==========<br>
>><br>
>> ERROR: test suite for <module 'network.nmdbus_test' from<br>
>> '/vdsm/tests/network/nmdbus_te<wbr>st.py'><br>
>><br>
>> ------------------------------<wbr>------------------------------<wbr>----------<br>
>><br>
>> Traceback (most recent call last):<br>
>><br>
>> File "/usr/lib/python2.7/site-packa<wbr>ges/nose/suite.py", line 209, in<br>
run<br>
>><br>
>> self.setUp()<br>
>><br>
>> File "/usr/lib/python2.7/site-packa<wbr>ges/nose/suite.py", line 292, in<br>
setUp<br>
>><br>
>> self.setupContext(ancestor)<br>
>><br>
>> File "/usr/lib/python2.7/site-packa<wbr>ges/nose/suite.py", line 315, in<br>
>> setupContext<br>
>><br>
>> try_run(context, names)<br>
>><br>
>> File "/usr/lib/python2.7/site-packa<wbr>ges/nose/util.py", line 471, in<br>
try_run<br>
>><br>
>> return func()<br>
>><br>
>> File "/vdsm/tests/testValidation.py<wbr>", line 191, in wrapper<br>
>><br>
>> return f(*args, **kwargs)<br>
>><br>
>> File "/vdsm/tests/testValidation.py<wbr>", line 97, in wrapper<br>
>><br>
>> return f(*args, **kwargs)<br>
>><br>
>> File "/vdsm/tests/network/nmdbus_te<wbr>st.py", line 48, in setup_module<br>
>><br>
>> NMDbus.init()<br>
>><br>
>> File "/vdsm/lib/vdsm/network/nm/nmd<wbr>bus/__init__.py", line 33, in init<br>
>><br>
>> NMDbus.bus = dbus.SystemBus()<br>
>><br>
>> File "/usr/lib64/python2.7/site-pac<wbr>kages/dbus/_dbus.py", line 194,<br>
in __new__<br>
>><br>
>> private=private)<br>
>><br>
>> File "/usr/lib64/python2.7/site-pac<wbr>kages/dbus/_dbus.py", line 100,<br>
in __new__<br>
>><br>
>> bus = BusConnection.__new__(subclass<wbr>, bus_type, mainloop=mainloop)<br>
>><br>
>> File "/usr/lib64/python2.7/site-pac<wbr>kages/dbus/bus.py", line 122, in<br>
__new__<br>
>><br>
>> bus = cls._new_for_bus(address_or_ty<wbr>pe, mainloop=mainloop)<br>
>><br>
>> DBusException: org.freedesktop.DBus.Error.Fil<wbr>eNotFound: Failed to<br>
>> connect to socket /var/run/dbus/system_bus_socke<wbr>t: No such file or<br>
>> directory<br>
>><br>
>> -------------------- >> begin captured logging << --------------------<br>
>><br>
>> 2016-12-07 11:48:33,458 DEBUG (MainThread) [root] /usr/bin/taskset<br>
>> --cpu-list 0-1 /bin/systemctl status NetworkManager (cwd None)<br>
>> (commands:69)<br>
>><br>
>> 2016-12-07 11:48:33,465 DEBUG (MainThread) [root] FAILED: <err> =<br>
>> 'Failed to get D-Bus connection: Operation not permitted\n'; <rc> = 1<br>
>> (commands:93)<br>
>><br>
>> 2016-12-07 11:48:33,465 DEBUG (MainThread) [root] /usr/bin/taskset<br>
>> --cpu-list 0-1 /bin/systemctl start NetworkManager (cwd None)<br>
>> (commands:69)<br>
>><br>
>> 2016-12-07 11:48:33,470 DEBUG (MainThread) [root] FAILED: <err> =<br>
>> 'Failed to get D-Bus connection: Operation not permitted\n'; <rc> = 1<br>
>> (commands:93)<br>
>><br>
>> --------------------- >> end captured logging << ---------------------<br>
<br>
</blockquote></blockquote>
<br>
</div></div><div class="HOEnZb"><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote>
<br>
</div></div></blockquote></div><br></div></div>