<div dir="ltr"><div><div>So it's not about the added network tests (these were added in the one I've mentioned, the one who had successful runs after being merged), and I don't see how the patch you've mentioned breaks anything (as it merely moves pieces around).<br><br></div>I could of course be wrong entirely and there's something I'm missing about the patch you're claiming is the guilty one, but it won't be about the network tests either way.<br><br></div><div>If it's then not about the network tests, then my immediate suspicion is that the problem lies somewhere else and isn't in either of the patches. I am far from able to prove this either way, though, so if reverting the patch you've mentioned somehow fixes check-merged, then it is of course fine by me.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 22, 2016 at 5:45 PM, Yaniv Bronheim <span dir="ltr"><<a href="mailto:ybronhei@redhat.com" target="_blank">ybronhei@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Thu, Dec 22, 2016 at 5:39 PM, Leon Goldberg <span dir="ltr"><<a href="mailto:lgoldber@redhat.com" target="_blank">lgoldber@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Doesn't seem related; the patch does nothing but move pieces around.<br><br></div>Judging by the title I guess you're referring to <a href="https://gerrit.ovirt.org/#/c/67787/" target="_blank">https://gerrit.ovirt.org/#/c/6<wbr>7787/</a> ?</div></blockquote><div><br></div><div><br></div></span><div>no.. you can see that after this patch it used to work (check the jobs after the merge)</div><div>so something in <a href="https://gerrit.ovirt.org/#/c/68078/" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>68078/</a> broke it</div><div><div class="h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="m_-264066231245078517gmail-h5"><br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 22, 2016 at 5:14 PM, Yaniv Bronheim <span dir="ltr"><<a href="mailto:ybronhei@redhat.com" target="_blank">ybronhei@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi guys and Leon,<div><br><div><a href="https://gerrit.ovirt.org/#/c/68078/" target="_blank">https://gerrit.ovirt.org/#/c/6<wbr>8078/</a> broke the check-merged job with really tough exception:</div><div><br></div><div><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>sh: [17766: 1 (255)] tcsetattr: Inappropriate ioctl for device
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>Took 2586 seconds
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span><a href="http://jenkins.ovirt.org/computer/vm0136.workers-phx.ovirt.org/log" style="box-sizing:border-box;color:rgb(92,53,102)" target="_blank">Slave went offline during the build</a>
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>ERROR: Connection was broken: java.io.IOException: Unexpected termination of the channel
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at hudson.remoting.SynchronousCom<wbr>mandTransport$ReaderThread.run<wbr>(SynchronousCommandTransport.<wbr>java:50)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>Caused by: java.io.EOFException
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at java.io.ObjectInputStream$Peek<wbr>InputStream.readFully(ObjectIn<wbr>putStream.java:2353)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at java.io.ObjectInputStream$Bloc<wbr>kDataInputStream.readShort(Obj<wbr>ectInputStream.java:2822)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at java.io.ObjectInputStream.read<wbr>StreamHeader(ObjectInputStream<wbr>.java:804)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at java.io.ObjectInputStream.<ini<wbr>t>(ObjectInputStream.java:301)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at hudson.remoting.ObjectInputStr<wbr>eamEx.<init>(ObjectInputStream<wbr>Ex.java:48)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at hudson.remoting.AbstractSynchr<wbr>onousByteArrayCommandTransport<wbr>.read(AbstractSynchronousByteA<wbr>rrayCommandTransport.java:34)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span> at hudson.remoting.SynchronousCom<wbr>mandTransport$ReaderThread.run<wbr>(SynchronousCommandTransport.<wbr>java:48)
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>Build step 'Execute shell' marked build as failure
<span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">15:23:34</b> </span>Performing Post build task...</pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">I have no clue what causes it.. we need to investigate in the tests code.</pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">you can see it in <a href="http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/772/consoleFull" target="_blank">http://jenkins.ovirt.org/job/v<wbr>dsm_master_check-merged-el7-x8<wbr>6_64/772/consoleFull</a></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">and this for a job run just before it got in, which worked well - <a href="http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/688/console" target="_blank">http://jenkins.ovirt.org/job/v<wbr>dsm_master_check-merged-el7-x8<wbr>6_64/688/console</a></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">I suggest to revert this patch (and backport the revert to ovirt-4.1 branch as well) until figuring what causes it</pre><span class="m_-264066231245078517gmail-m_-9158045348924395848gmail-HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_-264066231245078517gmail-m_-9158045348924395848gmail-m_6615150780809622505gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</font></span></div></div></div>
</blockquote></div><br></div></div></div></div></div></div>
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_-264066231245078517gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8px"><b>Yaniv Bronhaim.</b></span><br></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br></div>