<div dir="ltr">Why do we need to wait for a review and not revert the offending patch in the meantime? </div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 25, 2016 at 4:26 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Sun, Dec 25, 2016 at 3:59 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
> On Sun, Dec 25, 2016 at 3:40 PM, Barak Korren <<a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a>> wrote:<br>
>>><br>
>>> Can you tell if /var/run/vdsm/svdsm.sock exists?<br>
>><br>
>> # ls -l /var/run/vdsm/svdsm.sock<br>
>> ls: cannot access /var/run/vdsm/svdsm.sock: No such file or directory<br>
>><br>
>>> What's `ls -lZ /var/run/vdsm` ?<br>
>><br>
>> # ls -lZ /var/run/vdsm<br>
>> ls: cannot access /var/run/vdsm: No such file or directory<br>
>><br>
>>> Can you manually run supervdsmServer --sockfile=/var/run/vdsm/<wbr>svdsm.sock<br>
>>> on that host?<br>
>><br>
>> I get this:<br>
>><br>
>> [2016-12-25 08:39:01,224 pyinotify ERROR] add_watch: cannot watch<br>
>> /var/run/vdsm/sourceRoutes WD=-1, Errno=Not a directory (ENOTDIR)<br>
>> Exception in thread sourceRoute:<br>
>> Traceback (most recent call last):<br>
>> File "/usr/lib64/python2.7/<wbr>threading.py", line 811, in __bootstrap_inner<br>
>> self.run()<br>
>> File "/usr/lib64/python2.7/<wbr>threading.py", line 764, in run<br>
>> self.__target(*self.__args, **self.__kwargs)<br>
>> File "/usr/lib/python2.7/site-<wbr>packages/vdsm/utils.py", line 368, in wrapper<br>
>> return f(*a, **kw)<br>
>> File "/usr/lib/python2.7/site-<wbr>packages/vdsm/network/<wbr>sourceroutethread.py",<br>
>> line 90, in _subscribeToInotifyLoop<br>
>> for filePath in sorted(os.listdir(SOURCE_<wbr>ROUTES_FOLDER)):<br>
>> OSError: [Errno 20] Not a directory: '/var/run/vdsm/sourceRoutes'<br>
><br>
> Now that's completely my fault.<br>
><br>
> I probably did not verify <a href="https://gerrit.ovirt.org/#/c/68662/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>68662/</a> on a<br>
> clean installation.<br>
><br>
> Barak, do you know if there's a standard way of triggering<br>
> systemd-tmpfiles in %post ?<br>
><br>
> <a href="https://gerrit.ovirt.org/#/c/69092/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>69092/</a> would revert my offending patch.<br>
<br>
</div></div>But <a href="https://gerrit.ovirt.org/#/c/69093/1/vdsm.spec.in" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>69093/1/vdsm.spec.in</a> may be a proper<br>
fix. Would you care to review?<br>
<div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div>