<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 10, 2017 at 1:00 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
----- Original Message -----<br>
> From: "Greg Sheremeta" <<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>><br>
> To: "Vojtech Szocs" <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>><br>
</span><span class="">> Cc: "devel" <<a href="mailto:devel@ovirt.org">devel@ovirt.org</a>>, "Oved Ourfali" <<a href="mailto:oourfali@redhat.com">oourfali@redhat.com</a>>, "Juan Hernández" <<a href="mailto:jhernand@redhat.com">jhernand@redhat.com</a>><br>
> Sent: Monday, January 9, 2017 9:46:18 PM<br>
> Subject: Re: PatternFly upgrade - how to handle JS dependencies<br>
><br>
> On Fri, Jan 6, 2017 at 12:45 PM, Vojtech Szocs <<a href="mailto:vszocs@redhat.com">vszocs@redhat.com</a>> wrote:<br>
><br>
> > Hello,<br>
> ><br>
> > we'd like to upgrade the version of PatternFly (plus associated libraries,<br>
> > namely Bootstrap and jQuery) used in oVirt UI.<br>
> ><br>
> > Today, PatternFly stuff (PF + associated libraries) comes from<br>
> > `patternfly1`<br>
> > package hosted at Copr repo:<br>
> ><br>
> > <a href="https://copr.fedorainfracloud.org/coprs/patternfly/patternfly1/" rel="noreferrer" target="_blank">https://copr.fedorainfracloud.<wbr>org/coprs/patternfly/<wbr>patternfly1/</a><br>
> ><br>
> > Today, we require `patternfly1` as both Engine RPM build dependency and the<br>
> > Engine devel. env. dependency.<br>
> ><br>
> > To keep things simple, I'd like to propose the following approach:<br>
> ><br>
> > - create oVirt specific package, e.g. `ovirt-patternfly`, hosted at Copr,<br>
> > containing PatternFly + associated libraries (Bootstrap, jQuery) which<br>
> > are intended *specifically* for use by oVirt UI (hence the ovirt prefix)<br>
> ><br>
><br>
> I've already done this, although it's currently named 'patternfly3'<br>
> <a href="https://copr.fedorainfracloud.org/coprs/patternfly/patternfly3/" rel="noreferrer" target="_blank">https://copr.fedorainfracloud.<wbr>org/coprs/patternfly/<wbr>patternfly3/</a><br>
<br>
</span>I really think we should put some `ovirt` prefix there, to avoid<br>
people thinking that it's some kind of general-purpose PatternFly<br>
package.<br>
<br>
For example, `ovirt-engine-ui-dependencies` (for Engine GWT UI).<br></blockquote><div><br></div><div>That's fine. I had created the repo long before your suggestion, that's all.</div><div><br></div><div>I think it should have 'js' in the name somewhere.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
><br>
> However, we want to move it to our ovirt infra because copr sometimes goes<br>
> down, and that breaks CI jobs.<br>
<br>
</span>If we really want to do that, maybe we should add a new project<br>
into releng-tools repo. The project would be at<br>
<br>
releng-tools/specs/ovirt-<wbr>engine-ui-dependencies<br>
<br>
containing package.json and build script that downloads JS dep's<br>
and then packages all JS stuff as RPM.<br>
<br>
(Basically a very similar build process as with nodejs-modules.)<br></blockquote><div><br></div><div>Sure, that sounds good. Let me verify with infra where it should go.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
><br>
> So, +1 from me, but let's move to ovirt infra.<br>
><br>
><br>
> ><br>
> > - discontinue maintenance of `patternfly1` package at Copr<br>
> ><br>
> > - keep the existing approach: require `ovirt-patternfly` as both the Engine<br>
> > build dependency and the Engine devel. env. dependency<br>
> ><br>
> > An alternative approach would be to introduce Node.js as Engine devel. env.<br>
> > dependency (use `npm install` to pull PF stuff), while using the existing<br>
> > ovirt-engine-{nodejs,nodejs-<wbr>modules} packages for Engine RPM build.<br>
> ><br>
> > However, this alternative has some downsides, namely complication of devel.<br>
> > env. just to fetch the PF stuff. I don't like the idea of complicating the<br>
> > existing devel. env. just for the sake of fetching some 3rd party libs.<br>
> ><br>
> > I'm wondering what others think about this.<br>
> ><br>
> > Regards,<br>
> > Vojtech<br>
> ><br>
><br>
><br>
><br>
> --<br>
> Greg Sheremeta, MBA<br>
> Red Hat, Inc.<br>
> Sr. Software Engineer<br>
> <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a><br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Greg Sheremeta, MBA<br>Red Hat, Inc.<br>Sr. Software Engineer<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div>
</div></div>