<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 14, 2017 at 12:05 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking at:<div><a href="https://gerrit.ovirt.org/#/c/69438/3" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>69438/3</a></div><div><br></div><div>but there are several others in gerrit for different projects</div><div>taking this one as example just because it make me loose the evening on it.</div><div><br></div><div>"<span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">adding cli for 4.1 experimental repos" as stated in the header of the patch</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">has totally nothing to do with the body of the patch:</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">"</span><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">- also dropped fc23 since its eol"</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">which just dropped all the fc23 artifacts from the publisher causing:</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">- cockpit-ovirt for fc23 failing to build due to missing dependencies</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">- publisher 4.0 nightly failing due to missing cockpit-ovirt for fc23</span></div></div></blockquote><div><br></div><div>Wasn't aware the log line is that important and commit msg sometimes isn't looked at, will take that into account next time.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div> <br></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">Now I unblocked the publisher for 4.0 with: </span><font color="#353535" face="monospace"><span style="white-space:pre-wrap"><a href="https://gerrit.ovirt.org/70402" target="_blank">https://gerrit.ovirt.org/70402</a></span></font></div><div><font color="#353535" face="monospace"><span style="white-space:pre-wrap">but if infra decided to drop fc23 support since fc23 gone EOL, please do it completely.</span></font></div><div><br clear="all"><div>If a patch need a "also did..." it needs a separate patch.</div></div></div></blockquote><div><br></div><div>If the cockpit job was fixed when it started to be broken infra would have seen the fc23 error which was missed and fixed it,</div><div>Because it was failing for a few days it masked the fc23 issue in the job ( btw - the same error is in the cockpit ovirt 3.6 build artifacts job ).</div><div><br></div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div>Thanks,</div><span class="HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_5964834358237078411gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>