<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 26, 2017 at 10:00 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 26, 2017 at 9:50 AM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Hi,<br><br></div><div style="font-family:arial,helvetica,sans-serif">so this is exactly the issue why we should have ovirt-engine-4.1.0 branch even before 1st RC build.<br></div><div style="font-family:arial,helvetica,sans-serif">Unfortunately <a href="https://gerrit.ovirt.org/#/c/71001/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>1001/</a> was merged by Tal, even though it was targeted for 4.1.1.<br></div><div style="font-family:arial,helvetica,sans-serif">So we have 2 options:<br><br></div><div style="font-family:arial,helvetica,sans-serif">1. Revert the patch and rebuild engine again (safer, but time consuming)<br><br></div><div style="font-family:arial,helvetica,sans-serif">2. Hope that we will not cause any huge issue (it probably won't, but you know how it goes) and release 4.1.0 with vdsm-jsonrpc-java 1.3.8<br></div></div></blockquote><div><br></div><div>If it may help, <a href="http://jenkins.ovirt.org/job/ovirt_4.1_system-tests_manual/11/" target="_blank">http://jenkins.ovirt.<wbr>org/job/ovirt_4.1_system-<wbr>tests_manual/11/</a> passed CI testing.</div><div>I'm for including it rather than reverting.</div><div><br></div></div></div></div></blockquote><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default">I know, we have this fix included in master for a few days and looks good. So let's include it, at worst case we will have relase a fix async.<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br><br></div><div style="font-family:arial,helvetica,sans-serif">And I really hope that there were not merged any other patches targeted for 4.1.1<br><br></div><div style="font-family:arial,helvetica,sans-serif">Martin<br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_4675216209270818468gmail-">On Thu, Jan 26, 2017 at 8:24 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="m_4675216209270818468gmail-h5"><div dir="ltr"><pre class="m_4675216209270818468gmail-m_4660427352325165788m_-629881367072599740gmail-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:14px"><span class="m_4675216209270818468gmail-m_4660427352325165788m_-629881367072599740gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:00:44.789</b> </span>package: ovirt-engine-backend-4.1.0.3-1<wbr>.fc24.noarch from check-custom-fc24
<span class="m_4675216209270818468gmail-m_4660427352325165788m_-629881367072599740gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:00:44.789</b> </span> unresolved deps:
<span class="m_4675216209270818468gmail-m_4660427352325165788m_-629881367072599740gmail-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:00:44.789</b> </span> vdsm-jsonrpc-java >= 0:1.3.8</pre><div><br></div><div><div>[sbonazzo@sbonazzo vdsm-jsonrpc-java] [vdsm-jsonrpc-java:ovirt-4.1]$ git tag --list |grep 1.3</div><div>v1.3.3</div><div>v1.3.4</div><div>v1.3.5</div><div>v1.3.6</div><div>v1.3.7</div></div><div><br></div><div>We really need a test in check-patch.sh which build the rpms and install them so we can detect these errors earlier.</div>Piotr please provide vdsm-jsonrpc-java v.1.3.8, thanks<span class="HOEnZb"><font color="#888888"><span class="m_4675216209270818468gmail-m_4660427352325165788HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_4675216209270818468gmail-m_4660427352325165788m_-629881367072599740gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</font></span></font></span></div><span class="HOEnZb"><font color="#888888">
<br></font></span></div></div><span class="HOEnZb"><font color="#888888">______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_4675216209270818468gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr">Sandro Bonazzola<br>Better technology. Faster innovation. Powered by community collaboration.<br>See how it works at <a href="http://redhat.com" target="_blank">redhat.com</a></div></div></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br></div></div>