<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 7, 2017 at 10:18 AM, Francesco Romani <span dir="ltr"><<a href="mailto:fromani@redhat.com" target="_blank">fromani@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<br>
<div class="m_8650625367889582635moz-cite-prefix">On 02/05/2017 12:39 PM, Tal Nisan
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Great, thanks!
<div>I will let you know if something doesn't work as it should</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sun, Feb 5, 2017 at 12:09 PM, Shlomo
Ben David <span dir="ltr"><<a href="mailto:sbendavi@redhat.com" target="_blank">sbendavi@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Hi Tal,</div>
<div><br>
</div>
<div>I'm going to apply today the verify grade (-1) for
the following hooks:</div>
<div><br>
</div>
<div>
<ol>
<li><b>check_product</b> - if the patch project is not
the same as the bug product will return a verify
grade (-1).<br>
</li>
<li><b>check_target_milestone</b> - if the patch
branch major version is not the
same as the bug target milestone major version will
return a verify grade (-1).</li>
</ol>
</div>
<div>
<div class="m_8650625367889582635m_-4133077015336823918gmail_signature">
<div dir="ltr">
<div class="m_8650625367889582635m_-4133077015336823918gmail_signature">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>Best Regards,</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br></span>
Let's consider this scenario: we just begin developing the 4.2
version on the master branch; we just released the 4.1.0 version, so
we have the 4.1.z branch, and we are still supporting the 4.0.z
branch.<br>
Let's consider a bug which needs to be backported in the 4.0.z
branch, from master, of course passing throgh 4.1.z<br>
<br>
0. bug target milestone is 4.0.N+1 (last release is 4.0.N)<br>
1. patch on master -> OK<br>
2. patch backported first time on branch 4.1.z<br>
-> check_target_milestone fails! branch major 4.1, bug target
4.0<br>
<br>
It seems that this flow doesn't cover the case on which we need a
double backport.<br></div></blockquote><div><br></div><div>We are aware of that option, i.e "clone candidate" bugs, and if we see that the bug has 2 version flags ( e.g ovirt-4.1 + ovirt-4.0 ) then it shouldn't give -1. </div><div>If it still fails on bugs that are 'clone candidate' then its a bug and we should fix it.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
<br>
Bests,<span class="HOEnZb"><font color="#888888"><br>
<pre class="m_8650625367889582635moz-signature" cols="72">--
Francesco Romani
Red Hat Engineering Virtualization R & D
IRC: fromani</pre>
</font></span></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div>Eyal Edri<br>Associate Manager</div><div>RHV DevOps<br>EMEA ENG Virtualization R&D<br>Red Hat Israel<br><br>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div>
</div></div>