<div dir="ltr">If found this error in system tests - looks like wrong assert - code should check<div>if disk is not None before checking state.<br><div><br></div><div>I&#39;m not sure who is the owner of this test, so posting here.</div><div><br></div><div><pre class="inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:16px"><span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:05</b> </span><span style="box-sizing:border-box;color:rgb(0,205,205)">  # snapshots_merge: </span>
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span><span style="box-sizing:border-box;color:rgb(205,0,0)">Unhandled exception in &lt;function &lt;lambda&gt; at 0x276a5f0&gt;
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>Traceback (most recent call last):
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/usr/lib/python2.7/site-packages/ovirtlago/testlib.py&quot;, line 217, in assert_equals_within
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    res = func()
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py&quot;, line 466, in &lt;lambda&gt;
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    api.vms.get(VM0_NAME).disks.get(disk_name).status.state == &#39;ok&#39;
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>AttributeError: &#39;NoneType&#39; object has no attribute &#39;state&#39;</span>
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span><span style="box-sizing:border-box;color:rgb(205,0,0)">Error while running thread
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>Traceback (most recent call last):
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/usr/lib/python2.7/site-packages/lago/utils.py&quot;, line 57, in _ret_via_queue
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    queue.put({&#39;return&#39;: func()})
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py&quot;, line 465, in snapshot_live_merge
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    lambda:
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/usr/lib/python2.7/site-packages/ovirtlago/testlib.py&quot;, line 264, in assert_true_within_long
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    assert_equals_within_long(func, True, allowed_exceptions)
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/usr/lib/python2.7/site-packages/ovirtlago/testlib.py&quot;, line 251, in assert_equals_within_long
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exceptions
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/usr/lib/python2.7/site-packages/ovirtlago/testlib.py&quot;, line 217, in assert_equals_within
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    res = func()
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>  File &quot;/home/jenkins/workspace/ovirt-system-tests_manual/ovirt-system-tests/basic-suite-master/test-scenarios/004_basic_sanity.py&quot;, line 466, in &lt;lambda&gt;
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>    api.vms.get(VM0_NAME).disks.get(disk_name).status.state == &#39;ok&#39;
<span class="inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>AttributeError: &#39;NoneType&#39; object has no attribute &#39;state&#39;</span>
</pre><br class="inbox-inbox-Apple-interchange-newline"></div></div></div>