<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 16, 2017 at 10:46 AM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">If found this error in system tests - looks like wrong assert - code should check<div>if disk is not None before checking state.<br><div><br></div><div>I'm not sure who is the owner of this test, so posting here.</div></div></div></blockquote><div><br></div><div>Theoretically, perhaps. </div><div>Practically, it worked (until yesterday?) and now I'm also seeing this failure - it's not a coincidence.</div><div>However, looking at my failure[1], I'm seeing other nasty stuff, which may explain the later on failures</div><div><br></div><div>For example, new NPE I have not seen in the past:</div><div><div>2017-03-16 09:57:57,581-04 INFO [org.ovirt.engine.core.bll.AddVmTemplateCommand] (DefaultQuartzScheduler1) [5d94233] Ending command 'org.ovirt.engine.core.bll.AddVmTemplateCommand' successfully.</div><div>2017-03-16 09:57:57,591-04 INFO [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand] (DefaultQuartzScheduler1) [5d94233] START, SetVmStatusVDSCommand( SetVmStatusVDSCommandParameters:{runAsync='true', vmId='00000000-0000-0000-0000-000000000000', status='Down', exitStatus='Normal'}), log id: 30ee3299</div><div>2017-03-16 09:57:57,593-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall] (DefaultQuartzScheduler1) [5d94233] Compiled stored procedure. Call string is [{call getvmdynamicbyvmguid(?)}]</div><div>2017-03-16 09:57:57,594-04 DEBUG [org.ovirt.engine.core.dal.dbbroker.PostgresDbEngineDialect$PostgresSimpleJdbcCall] (DefaultQuartzScheduler1) [5d94233] SqlCall for procedure [GetVmDynamicByVmGuid] compiled</div><div>2017-03-16 09:57:57,595-04 ERROR [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand] (DefaultQuartzScheduler1) [5d94233] Command 'SetVmStatusVDSCommand( SetVmStatusVDSCommandParameters:{runAsync='true', vmId='00000000-0000-0000-0000-000000000000', status='Down', exitStatus='Normal'})' execution failed: null</div><div>2017-03-16 09:57:57,595-04 DEBUG [org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand] (DefaultQuartzScheduler1) [5d94233] Exception: java.lang.NullPointerException</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.vdsbroker.SetVmStatusVDSCommand.executeVDSCommand(SetVmStatusVDSCommand.java:33) [vdsbroker.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.vdsbroker.VDSCommandBase.executeCommand(VDSCommandBase.java:73) [vdsbroker.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.dal.VdcCommandBase.execute(VdcCommandBase.java:33) [dal.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.vdsbroker.vdsbroker.DefaultVdsCommandExecutor.execute(DefaultVdsCommandExecutor.java:14) [vdsbroker.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.vdsbroker.ResourceManager.runVdsCommand(ResourceManager.java:404) [vdsbroker.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.bll.VDSBrokerFrontendImpl.runVdsCommand(VDSBrokerFrontendImpl.java:33) [bll.jar:]</div><div><span class="gmail-Apple-tab-span" style="white-space:pre"> </span>at org.ovirt.engine.core.bll.VmHandler.unLockVm(VmHandler.java:377) [bll.jar:]</div></div><div><br></div><div><br></div><div><br></div><div>Y.</div><div><br></div><div>[1] <a href="http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86_64/326/artifact/exported-artifacts/basic_suite_master__logs/test_logs/basic-suite-master/post-004_basic_sanity.py/lago-basic-suite-master-engine/_var_log/ovirt-engine/engine.log">http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86_64/326/artifact/exported-artifacts/basic_suite_master__logs/test_logs/basic-suite-master/post-004_basic_sanity.py/lago-basic-suite-master-engine/_var_log/ovirt-engine/engine.log</a></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br></div><div><pre class="gmail-m_-3711950224702553848inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:16px"><span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:05</b> </span><span style="box-sizing:border-box;color:rgb(0,205,205)"> # snapshots_merge: </span>
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span><span style="box-sizing:border-box;color:rgb(205,0,0)">Unhandled exception in <function <lambda> at 0x276a5f0>
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>Traceback (most recent call last):
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/usr/lib/python2.7/site-<wbr>packages/ovirtlago/testlib.py"<wbr>, line 217, in assert_equals_within
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> res = func()
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/home/jenkins/workspace/<wbr>ovirt-system-tests_manual/<wbr>ovirt-system-tests/basic-<wbr>suite-master/test-scenarios/<wbr>004_basic_sanity.py", line 466, in <lambda>
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> api.vms.get(VM0_NAME).disks.<wbr>get(disk_name).status.state == 'ok'
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>AttributeError: 'NoneType' object has no attribute 'state'</span>
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span><span style="box-sizing:border-box;color:rgb(205,0,0)">Error while running thread
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>Traceback (most recent call last):
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/usr/lib/python2.7/site-<wbr>packages/lago/utils.py", line 57, in _ret_via_queue
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> queue.put({'return': func()})
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/home/jenkins/workspace/<wbr>ovirt-system-tests_manual/<wbr>ovirt-system-tests/basic-<wbr>suite-master/test-scenarios/<wbr>004_basic_sanity.py", line 465, in snapshot_live_merge
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> lambda:
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/usr/lib/python2.7/site-<wbr>packages/ovirtlago/testlib.py"<wbr>, line 264, in assert_true_within_long
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> assert_equals_within_long(<wbr>func, True, allowed_exceptions)
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/usr/lib/python2.7/site-<wbr>packages/ovirtlago/testlib.py"<wbr>, line 251, in assert_equals_within_long
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> func, value, LONG_TIMEOUT, allowed_exceptions=allowed_<wbr>exceptions
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/usr/lib/python2.7/site-<wbr>packages/ovirtlago/testlib.py"<wbr>, line 217, in assert_equals_within
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> res = func()
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> File "/home/jenkins/workspace/<wbr>ovirt-system-tests_manual/<wbr>ovirt-system-tests/basic-<wbr>suite-master/test-scenarios/<wbr>004_basic_sanity.py", line 466, in <lambda>
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span> api.vms.get(VM0_NAME).disks.<wbr>get(disk_name).status.state == 'ok'
<span class="gmail-m_-3711950224702553848inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">08:28:31</b> </span>AttributeError: 'NoneType' object has no attribute 'state'</span>
</pre><br class="gmail-m_-3711950224702553848inbox-inbox-Apple-interchange-newline"></div></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br></div></div>