<br><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 23, 2017, 12:25 PM Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br class="gmail_msg">
<br class="gmail_msg">
I am just wondering whether you tried Roman's Hystrix integration to<br class="gmail_msg">
see what command was so slow?<br class="gmail_msg"><br class="gmail_msg">
Martin<br class="gmail_msg"></blockquote></div><div><br></div><div>More on that in a different thread. Using only the debug logs it was quite easy to see that it was 13000+ queries to the db instead of one.</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
On Thu, Mar 23, 2017 at 11:05 AM, Roy Golan <<a href="mailto:rgolan@redhat.com" class="gmail_msg" target="_blank">rgolan@redhat.com</a>> wrote:<br class="gmail_msg">
> Lately we came across an interesting case where multi-host+mult-networks<br class="gmail_msg">
> resulted editing a host to conclude in minutes. One assumption that was<br class="gmail_msg">
> raised which we wanted to eliminate was that the decryption we perform on a<br class="gmail_msg">
> fence agent password might be taking too long.<br class="gmail_msg">
><br class="gmail_msg">
> So these days it's an easy task thanks to JMH[1], supplied by the jdk<br class="gmail_msg">
> itself. I kickstarted [2] and added a 'DecryptionBenchmark', see the output<br class="gmail_msg">
> as an example[3]<br class="gmail_msg">
><br class="gmail_msg">
> Although The JMH project recommends to create a separate project I find it<br class="gmail_msg">
> would be less trivial to people to contribute benchmarks let alone just<br class="gmail_msg">
> playing around with current code they want to test.<br class="gmail_msg">
><br class="gmail_msg">
> - So, (when it will be merged) you add your benchmark under<br class="gmail_msg">
> backend/manager/modules/benchmarks/MyBenchmark.java<br class="gmail_msg">
><br class="gmail_msg">
> - run it from intellij using the jmh plugin exactly like a unit-test<br class="gmail_msg">
> OR<br class="gmail_msg">
> - mvn test -P benchmarks -pl org.ovirt.engine:benchmarks<br class="gmail_msg">
> OR<br class="gmail_msg">
> - java -jar benchmarks.jar<br class="gmail_msg">
><br class="gmail_msg">
> I hope this would serve all of us well, please review and add your<br class="gmail_msg">
> benchmarks.<br class="gmail_msg">
><br class="gmail_msg">
> PS - this will not run in the CI atm.<br class="gmail_msg">
><br class="gmail_msg">
> [1] <a href="http://openjdk.java.net/projects/code-tools/jmh/" rel="noreferrer" class="gmail_msg" target="_blank">http://openjdk.java.net/projects/code-tools/jmh/</a><br class="gmail_msg">
> [2] <a href="https://gerrit.ovirt.org/74537" rel="noreferrer" class="gmail_msg" target="_blank">https://gerrit.ovirt.org/74537</a> microbenchmarks: Introduce<br class="gmail_msg">
> microbenchmarks using JMH<br class="gmail_msg">
> [3] DecryptionBenchmark output (short version):<br class="gmail_msg">
><br class="gmail_msg">
> # Run complete. Total time: 00:09:06<br class="gmail_msg">
><br class="gmail_msg">
> Benchmark Mode Samples Score Score error<br class="gmail_msg">
> Units<br class="gmail_msg">
> b.DecryptionBenchmark.decryption thrpt 50 101.258 1.270<br class="gmail_msg">
> ops/s<br class="gmail_msg">
> b.DecryptionBenchmark.encryption thrpt 50 238.587 4.667<br class="gmail_msg">
> ops/s<br class="gmail_msg">
> b.DecryptionBenchmark.decryption avgt 50 0.010 0.000<br class="gmail_msg">
> s/op<br class="gmail_msg">
> b.DecryptionBenchmark.encryption avgt 50 0.004 0.000<br class="gmail_msg">
> s/op<br class="gmail_msg">
> b.DecryptionBenchmark.decryption sample 5544 0.010 0.000<br class="gmail_msg">
> s/op<br class="gmail_msg">
> b.DecryptionBenchmark.encryption sample 13067 0.004 0.000<br class="gmail_msg">
> s/op<br class="gmail_msg">
> b.DecryptionBenchmark.decryption ss 50 0.014 0.001<br class="gmail_msg">
> s<br class="gmail_msg">
> b.DecryptionBenchmark.encryption ss 50 0.009 0.001<br class="gmail_msg">
> s<br class="gmail_msg">
><br class="gmail_msg">
> Process finished with exit code 0<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> Devel mailing list<br class="gmail_msg">
> <a href="mailto:Devel@ovirt.org" class="gmail_msg" target="_blank">Devel@ovirt.org</a><br class="gmail_msg">
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br class="gmail_msg">
</blockquote></div>