<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 24, 2017 at 3:51 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Found the problem after debugging NlsCheck.<br><br></div><div style="font-family:arial,helvetica,sans-serif">First of all, it checks all kinds of Java sources, including the generated ones. That's silly and one of the reasons why Checkstyle execution takes a rather long time. I'll fix that.<br><br></div><div style="font-family:arial,helvetica,sans-serif">Next, when checking a Java source that contains string "{}" (without quotes) it will log the problem, but Checkstyle message logging infra things that "{}" is a placeholder to resolve, but it's not, and it fails on NumberFormatException. I'll fix that too.<span class="gmail-HOEnZb"><font color="#888888"><br></font></span></div></div></blockquote><div><br><div style="font-family:arial,helvetica,sans-serif" class="gmail_default"><a href="https://gerrit.ovirt.org/#/c/74611/">https://gerrit.ovirt.org/#/c/74611/</a><br><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><span class="gmail-HOEnZb"><font color="#888888"><br></font></span></div><span class="gmail-HOEnZb"><font color="#888888"><div style="font-family:arial,helvetica,sans-serif"></div><div style="font-family:arial,helvetica,sans-serif"></div><div style="font-family:arial,helvetica,sans-serif">Vojtech<br><br></div></font></span><div><div class="gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 24, 2017 at 3:19 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Hi Allon,<br><br></div><div style="font-family:arial,helvetica,sans-serif">I think I found some strange Checkstyle related problems on master.<br><br></div><div style="font-family:arial,helvetica,sans-serif">Engine build with (GWT compilation enabled) works OK.<br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">Next, trying to start GWT debugger:<br><br>$ make gwt-debug DEBUG_MODULE=webadmin \<br> DEV_EXTRA_BUILD_FLAGS_GWT_DEFA<wbr>ULTS="-Dgwt.userAgent=gecko1_<wbr>8,safari" \<br> DEV_EXTRA_BUILD_FLAGS="-Dgwt.l<wbr>ogLevel=INFO -Dgwt.locale=en_US -Dgwt.compiler.localWorkers=1" \<br> DEV_BUILD_GWT_SUPER_DEV_MODE=1<br><br>maven-checkstyle-plugin:check execution fails on<br><br> frontend/webadmin/modules/gwt-<wbr>extension/src/main/java/org/ov<wbr>irt/engine/ui/uioverrides/org/<wbr>ovirt/engine/core/compat/Forma<wbr>tterDotnet.java<br> can't parse argument number: (\\d)\\: For input string: "(\\d)\\"<br><br></div><div style="font-family:arial,helvetica,sans-serif">the class isn't used, removed it, retry. Now it fails on:<br><br> frontend/webadmin/modules/gwt-<wbr>extension/src/main/java/org/ov<wbr>irt/engine/ui/uioverrides/org/<wbr>slf4j/Logger.java<br> can't parse argument number: For input string: ""<br><br></div><div style="font-family:arial,helvetica,sans-serif">I guess it's a bug in our NON-NLS check? But why doesn't the problem occur during Engine build?<br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">I'm thinking about disabling Checkstyle for gwt-extension module, as it contains custom GWT RPC serializers and GWT class overrides, and maybe the file path src/main/java/org/ovirt/engine<wbr>/ui/uioverrides/here/goes/<wbr>actual/pkg is confusing the Checkstyle now.<br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">Thanks,<br></div><div style="font-family:arial,helvetica,sans-serif">Vojtech<br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="gmail-m_251118853353326676gmail-h5">On Wed, Mar 22, 2017 at 10:33 PM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-m_251118853353326676gmail-h5"><div dir="ltr"><div style="font-family:monospace,monospace">Hi all,</div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace">As per [1], I've just merged a series of patches that upgrades the oVirt engine to use the latest maven-checkstyle-plugin and checkstyle packages.</div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace">Please note that the newer checkstyle is a tad stricter than the old one we used to have (read: it contains several fixes for bugs where the old checkstyle was supposed to find issues but missed them).</div><div style="font-family:monospace,monospace">I also took the opportunity and added a couple of new checks that enforce rules we were de-facto adhering to anyway.</div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace">If any problems come up, please let me know.</div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace">-Your friendly neighborhood cleanup dude</div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace">[1] <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1433408" target="_blank">https://bugzilla.redhat.co<wbr>m/show_bug.cgi?id=1433408</a></div></div>
<br></div></div>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>