<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 27, 2017 at 2:10 PM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Mon, Mar 27, 2017 at 3:09 PM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:monospace,monospace"><font><font> </font></font></div><div style="font-family:monospace,monospace"><font><font><font><font><font><font>Indeed, </font></font></font></font></font></font><font><font><font><font><font><font><font><font> Greg.</font></font></font></font></font></font></font></font><font><font><font><font><font><font><font><font>thanks</font></font></font></font></font></font></font></font><font><font><font><font></font></font></font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font><font><font><font><font>As a temporary solution, you could cherry-pick </font></font><a href="https://gerrit.ovirt.org/#/c/74611" target="_blank"><font><font>https://gerrit.</font></font><font><font>ovi<wbr>rt.org/#/c/74611</font></font></a><font><font> and work above it.</font></font></font></font></font></font></div><div style="font-family:monospace,monospace"><font><font><font><font>It should solve the issue (even though IMHO it isn't ready for merging to master).</font></font></font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font><font><font><font><font>Vojta</font></font></font></font><font><font> - are you updating </font></font><a href="https://gerrit.ovirt.org/#/c/74611" target="_blank"><font><font>https://gerrit.ovirt.</font></font><font><font><wbr>org/#/c/74611</font></font></a><font><font> as per my comments there, or should I take it over?</font></font></font></font></div></div></blockquote></span><div><div style="font-family:monospace,monospace">I literally have no idea who I did made this typo.</div><div style="font-family:monospace,monospace">I meant "Vojtech", of course.</div></div></div></div></div></blockquote><div><br><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">In Czech language, Vojta actually means Vojtech, in a less formal way =)<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">I've just updated <a href="https://gerrit.ovirt.org/#/c/74611/">https://gerrit.ovirt.org/#/c/74611/</a> according to your comments.<br><br></div><div style="font-family:arial,helvetica,sans-serif" class="gmail_default">The reason why GWT debugger fails to start is because one of the non-localized strings (which comes from `gwt-extension` and therefore shouldn't be checked in the first place..) contains a {} placeholder, NlsCheck logs it, and eventually crashes because it thinks it's a log message placeholder, but it's just something we want printed out.<br></div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div><div class="gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-m_-115242002332664818HOEnZb"><div class="gmail-m_-115242002332664818h5"><div class="gmail_extra"><br><div class="gmail_quote"><font><font>On Mon, Mar 27, 2017 at 3:03 PM, Greg Sheremeta </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:gshereme@redhat.com" target="_blank"><font><font>gshereme@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><font><font>From the comments in 74619</font></font><div><br></div><div><font><font>"" "</font></font></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap"><font><font>So, tl;dr - it /won't/ work with this patch but without 74611. This patch should be applied before 74611</font></font></span><br></div><div><span style="color:rgb(53,53,53);font-family:sans-serif;white-space:pre-wrap"><font><font>"" "</font></font></span></div></div><div class="gmail_extra"><div><div class="gmail-m_-115242002332664818m_-8207311559298690738h5"><br><div class="gmail_quote"><font><font>On Mon, Mar 27, 2017 at 7:42 AM, Marek Libra </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:mlibra@redhat.com" target="_blank"><font><font>mlibra@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><font><font>With </font></font><br> <a href="https://gerrit.ovirt.org/#/c/74619/" target="_blank"><font><font>https://gerrit.ovirt.org/#/c/7</font></font><font><font><wbr>4619/</font></font></a><br><br><font><font>applied, following is still failing:</font></font><br><font><font> make gwt-debug DEBUG_MODULE=webadmin DEV_EXTRA_BUILD_FLAGS_GWT_DEFA</font></font><font><font><wbr>ULTS="-Dgwt.cssResourceStyle=p</font></font><font><font><wbr>retty -Dgwt.userAgent=gecko1_8"</font></font><br><br></div><font><font>with message:</font></font><br><font><font>[WARNING] The requested profile "gwt-user" could not be activated because it does not exist.</font></font><br><font><font>[ERROR] Failed to execute goal org.apache.maven.plugins:maven</font></font><font><font><wbr>-checkstyle-plugin:2.17:check (checkstyle) on project webadmin: Failed during checkstyle configuration: Exception was thrown while processing /home/mlibra/IdeaProjects/ovir</font></font><font><font><wbr>t-engine/frontend/webadmin/mod</font></font><font><font><wbr>ules/gwt-extension/src/main/</font></font><font><font>ja<wbr>va/org/ovirt/engine/ui/uiove</font></font><font><font>rr<wbr>ides/org/slf4j/Logger.java: can't parse argument number: For input string: "" -> [Help 1]</font></font><br><br><br></div><font><font>Any hint, please?</font></font><span class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129HOEnZb"><font color="#888888"><br></font></span></div><span class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129HOEnZb"><font color="#888888"><font><font>Marek</font></font><br><div><div><div><br><br></div></div></div></font></span></div><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129HOEnZb"><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129h5"><div class="gmail_extra"><br><div class="gmail_quote"><font><font>On Fri, Mar 24, 2017 at 4:14 PM, Vojtech Szocs </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:vszocs@redhat.com" target="_blank"><font><font>vszocs@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span><font><font>On Fri, Mar 24, 2017 at 3:51 PM, Vojtech Szocs </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:vszocs@redhat.com" target="_blank"><font><font>vszocs@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><font><font>Found the problem after debugging NlsCheck.</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>First of all, it checks all kinds of Java sources, including the generated ones. That's silly and one of the reasons why Checkstyle execution takes a rather long time. I'll fix that.</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Next, when checking a Java source that contains string "{}" (without quotes) it will log the problem, but Checkstyle message logging infra things that "{}" is a placeholder to resolve, but it's not, and it fails on NumberFormatException. I'll fix that too.</font></font><span class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-HOEnZb"><font color="#888888"><br></font></span></div></div></blockquote></span><div><br><div><font><font></font></font><a href="https://gerrit.ovirt.org/#/c/74611/" target="_blank"><font><font>https://gerrit.ovirt.org/#/c/</font></font><font><font><wbr>74611/</font></font></a><font><font></font></font><br><br></div></div><div><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><span class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-HOEnZb"><font color="#888888"><br></font></span></div><span class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-HOEnZb"><font color="#888888"><div style="font-family:arial,helvetica,sans-serif"></div><div style="font-family:arial,helvetica,sans-serif"></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Vojtech</font></font><br><br></div></font></span><div><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote"><font><font>On Fri, Mar 24, 2017 at 3:19 PM, Vojtech Szocs </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:vszocs@redhat.com" target="_blank"><font><font>vszocs@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><font><font>Hi Allon,</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>I think I found some strange Checkstyle related problems on master.</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Engine build with (GWT compilation enabled) works OK.</font></font><br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Next, trying to start GWT debugger:</font></font><br><br><font><font>$ make gwt-debug DEBUG_MODULE=webadmin \</font></font><br><font><font> DEV_EXTRA_BUILD_FLAGS_GWT_DEFA</font></font><font><font><wbr>ULTS="-Dgwt.userAgent=gecko1_8</font></font><font><font><wbr>,safari" \</font></font><br><font><font> DEV_EXTRA_BUILD_FLAGS="-Dgwt.l</font></font><font><font><wbr>ogLevel=INFO -Dgwt.locale=en_US -Dgwt.compiler.localWorkers=1" \</font></font><br><font><font> DEV_BUILD_GWT_SUPER_DEV_MODE=1</font></font><br><br><font><font>maven-checkstyle-plugin:check execution fails on</font></font><br><br><font><font> frontend/webadmin/modules/gwt-</font></font><font><font><wbr>extension/src/main/java/org/ov</font></font><font><font><wbr>irt/engine/ui/uioverrides/org/</font></font><font><font><wbr>ovirt/engine/core/compat/Forma</font></font><font><font><wbr>tterDotnet.java</font></font><br><font><font> can't parse argument number: (\\d)\\: For input string: "(\\d)\\"</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>the class isn't used, removed it, retry. Now it fails on:</font></font><br><br><font><font> frontend/webadmin/modules/gwt-</font></font><font><font><wbr>extension/src/main/java/org/ov</font></font><font><font><wbr>irt/engine/ui/uioverrides/org/</font></font><font><font><wbr>slf4j/Logger.java</font></font><br><font><font> can't parse argument number: For input string: ""</font></font><br><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>I guess it's a bug in our NON-NLS check? But why doesn't the problem occur during Engine build?</font></font><br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>I'm thinking about disabling Checkstyle for gwt-extension module, as it contains custom GWT RPC serializers and GWT class overrides, and maybe the file path src/main/java/org/ovirt/engine</font></font><font><font><wbr>/ui/uioverrides/here/goes/actu</font></font><font><font><wbr>al/pkg is confusing the Checkstyle now.</font></font><br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Thanks,</font></font><br></div><div style="font-family:arial,helvetica,sans-serif"><font><font>Vojtech</font></font><br></div><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-m_251118853353326676gmail-h5"><font><font>On Wed, Mar 22, 2017 at 10:33 PM, Allon Mureinik </font></font><span dir="ltr"><font><font><</font></font><a href="mailto:amureini@redhat.com" target="_blank"><font><font>amureini@redhat.com</font></font></a><font><font>></font></font></span><font><font> wrote:</font></font><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129m_-6821470198507987675m_-1331166704052779664gmail-m_251118853353326676gmail-h5"><div dir="ltr"><div style="font-family:monospace,monospace"><font><font>Hi all,</font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font>As per [1], I've just merged a series of patches that upgrades the oVirt engine to use the latest maven-checkstyle-plugin and checkstyle packages.</font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font>Please note that the newer checkstyle is a tad stricter than the old one we used to have (read: it contains several fixes for bugs where the old checkstyle was supposed to find issues but missed them).</font></font></div><div style="font-family:monospace,monospace"><font><font>I also took the opportunity and added a couple of new checks that enforce rules we were de-facto adhering to anyway.</font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font>If any problems come up, please let me know.</font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font>-Your friendly neighborhood cleanup dude</font></font></div><div style="font-family:monospace,monospace"><br></div><div style="font-family:monospace,monospace"><font><font>[1] </font></font><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1433408" target="_blank"><font><font>https://bugzilla.redhat.co</font></font><font><font><wbr>m/show_bug.cgi?id=1433408</font></font></a></div></div>
<br></div></div><font><font>______________________________</font></font><font><font><wbr>_________________</font></font><br><font><font>
Devel mailing list</font></font><br>
<a href="mailto:Devel@ovirt.org" target="_blank"><font><font>Devel@ovirt.org</font></font></a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank"><font><font>http://lists.ovirt.org/mailman</font></font><font><font><wbr>/listinfo/devel</font></font></a><br></blockquote></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div></div></div><br></div></div>
<br><font><font>______________________________</font></font><font><font><wbr>_________________</font></font><br><font><font>
Devel mailing list</font></font><br>
<a href="mailto:Devel@ovirt.org" target="_blank"><font><font>Devel@ovirt.org</font></font></a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank"><font><font>http://lists.ovirt.org/mailman</font></font><font><font><wbr>/listinfo/devel</font></font></a><br></blockquote></div><br></div>
</div></div><br><font><font>______________________________</font></font><font><font><wbr>_________________</font></font><br><font><font>
Devel mailing list</font></font><br>
<a href="mailto:Devel@ovirt.org" target="_blank"><font><font>Devel@ovirt.org</font></font></a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank"><font><font>http://lists.ovirt.org/mailman</font></font><font><font><wbr>/listinfo/devel</font></font></a><br></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="gmail-m_-115242002332664818m_-8207311559298690738HOEnZb"><font color="#888888"><font><font>-- </font></font><br><div class="gmail-m_-115242002332664818m_-8207311559298690738m_-4553278528227448129gmail_signature"><div dir="ltr"><div><font><font>Greg Sheremeta, MBA</font></font><br><font><font>Red Hat, Inc.</font></font><br><font><font>Sr. Software Engineer</font></font><br><a href="mailto:gshereme@redhat.com" target="_blank"><font><font>gshereme@redhat.com</font></font></a><br></div></div></div>
</font></span></div>
<br><font><font>______________________________</font></font><font><font><wbr>_________________</font></font><br><font><font>
Devel mailing list</font></font><br>
<a href="mailto:Devel@ovirt.org" target="_blank"><font><font>Devel@ovirt.org</font></font></a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank"><font><font>http://lists.ovirt.org/mailman</font></font><font><font><wbr>/listinfo/devel</font></font></a><br></blockquote></div><br></div>
</div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>