<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Apr 21, 2017 at 11:19 AM Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">As we all know, Python is dynamically typed, which requires good<br>
coverage by unit tests.<br>
<br>
As we all know, Vdsm unit tests' coverage is not good.<br>
<br>
We need all the help we can get in order to avoid typos leading to<br>
bugs. Nir's `make pylint-diff` would give some. </blockquote><div><br></div><div>We can take this patch now, since it does not break the build on errors.</div><div><br></div><div>It is useful as is so people can run make pylint locally and fix their errors.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In order to have it<br>
merged, I have posted<br>
<a href="https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:pylint+owner:danken" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:pylint+owner:danken</a><br>
to silence existing pylint errors. I hope I did not silence any<br>
serious ones; please review this topic as soon as possible.<br></blockquote><div><br></div><div>Thanks for this great work!</div><div><br></div><div>I think the last patch is too big, and there are some storage issues that we can fix</div><div>now. Can you split by vertical? I would like to take over the the storage part.</div><div><br></div><div>I sent this patch making the storage/monitor.py pylint clean:</div><div><a href="https://gerrit.ovirt.org/75736">https://gerrit.ovirt.org/75736</a><br></div><div><br></div><div>Nir</div></div></div>