<div dir="ltr"><div class="gmail_default" style="font-size:large">The fix for that regression was merged to master, please sync and check again <br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 5:14 PM, Eli Mesika <span dir="ltr"><<a href="mailto:emesika@redhat.com" target="_blank">emesika@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:large">Hi<br><br></div><div class="gmail_default" style="font-size:large">Please review the fixing patch <br><a href="https://gerrit.ovirt.org/#/c/76013/2" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>76013/2</a><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 3:00 PM, Fred Rolland <span dir="ltr"><<a href="mailto:frolland@redhat.com" target="_blank">frolland@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Eli hi,<br><br></div>It seems there is some issue in the squash patch [1].<br><div><div><br>Regarding the issue found by the OST, if you start from a fresh DB, wrong values will be inserted in the "spec_params" column in the vm_device table. [2]<br></div><div>We will get '58ca7b19-0071-00c0-01d6-00000<wbr>0000212' instead of a map like { "vram" : "65536" }<br></div><div><br></div><div>It will fail the creation of the AddVmTemplateCommand that we see in the log.<br><br></div><div>Regards,<br><br></div><div>Freddy<br></div><div><br>[1] <a href="https://gerrit.ovirt.org/#/c/74382/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>4382/</a><br>[2] <a href="https://gerrit.ovirt.org/#/c/74382/8/packaging/dbscripts/data/01200_insert_vm_device.sql" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>4382/8/packaging/dbscripts/dat<wbr>a/01200_insert_vm_device.sql</a></div></div></div><div class="m_1483308851719635728HOEnZb"><div class="m_1483308851719635728h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 12:13 PM, Fred Rolland <span dir="ltr"><<a href="mailto:frolland@redhat.com" target="_blank">frolland@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking at it<br></div><div class="m_1483308851719635728m_7421219156940558578HOEnZb"><div class="m_1483308851719635728m_7421219156940558578h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 12:11 AM, Nadav Goldin <span dir="ltr"><<a href="mailto:ngoldin@redhat.com" target="_blank">ngoldin@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Test failed: add_secondary_storage_domains/<wbr>import_template_from_glance<br>
<br>
Link to suspected patches: <a href="https://gerrit.ovirt.org/#/c/74382/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>4382/</a><br>
<br>
Link to Job: <a href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/6456/</a><br>
(started in 6451)<br>
<br>
Link to all logs:<br>
<a href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/6456/artifact/exported-ar<wbr>tifacts/basic-suit-master-el7/<wbr>test_logs/basic-suite-master/p<wbr>ost-002_bootstrap.py/</a><br>
<br>
Engine log: <a href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6456/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/lago-basic-suite-master-engine/_var_log/ovirt-engine/engine.log" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/6456/artifact/exported-ar<wbr>tifacts/basic-suit-master-el7/<wbr>test_logs/basic-suite-master/p<wbr>ost-002_bootstrap.py/lago-basi<wbr>c-suite-master-engine/_var_log<wbr>/ovirt-engine/engine.log</a><br>
<br>
Error snippet from the test log:<br>
<br>
<error><br>
<br>
lago.utils: ERROR: Error while running thread<br>
Traceback (most recent call last):<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/lago/utils.py", line 58, in<br>
_ret_via_queue<br>
queue.put({'return': func()})<br>
File "/home/jenkins/workspace/test-<wbr>repo_ovirt_experimental_master<wbr>/ovirt-system-tests/basic-suit<wbr>e-master/test-scenarios/002_bo<wbr>otstrap.py",<br>
line 803, in import_template_from_glance<br>
generic_import_from_glance(api<wbr>, image_name=CIRROS_IMAGE_NAME,<br>
image_ext='_glance_template', as_template=True)<br>
File "/home/jenkins/workspace/test-<wbr>repo_ovirt_experimental_master<wbr>/ovirt-system-tests/basic-suit<wbr>e-master/test-scenarios/002_bo<wbr>otstrap.py",<br>
line 641, in generic_import_from_glance<br>
lambda: api.disks.get(disk_name).statu<wbr>s.state == 'ok',<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line<br>
264, in assert_true_within_long<br>
assert_equals_within_long(func<wbr>, True, allowed_exceptions)<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line<br>
251, in assert_equals_within_long<br>
func, value, LONG_TIMEOUT, allowed_exceptions=allowed_exc<wbr>eptions<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line<br>
230, in assert_equals_within<br>
'%s != %s after %s seconds' % (res, value, timeout)<br>
AssertionError: False != True after 600 seconds<br>
<br>
<br>
</error><br>
<br>
<br>
the engine.log has this sequence repeating(apparently at the end of<br>
the task - 199ed356):<br>
<br>
2017-04-24 13:34:50,079-04 INFO<br>
[org.ovirt.engine.core.bll.sto<wbr>rage.repoimage.ImportRepoImage<wbr>Command]<br>
(DefaultQuartzScheduler10) [199ed356-0960-4ef4-9637-09c76<wbr>a07c932]<br>
Ending command 'org.ovirt.engine.core.bll.sto<wbr>rage.repoimage.ImportRepoImage<wbr>Command'<br>
successfully.<br>
2017-04-24 13:34:50,090-04 ERROR<br>
[<a href="http://org.ovirt.engine.core.bll.Com" target="_blank">org.ovirt.engine.core.bll.Com</a><wbr>mandsFactory] (DefaultQuartzScheduler10)<br>
[] An exception has occurred while trying to create a command object<br>
for command 'AddVmTemplate' with parameters<br>
'AddVmTemplateParameters:{comm<wbr>andId='a6d45092-dfe0-4a65-bdc4<wbr>-4c23a68fe7d5',<br>
user='admin', commandType='Unknown'}': WELD-000049: Unable to invoke<br>
protected final void<br>
org.ovirt.engine.core.bll.Comm<wbr>andBase.postConstruct() on<br>
org.ovirt.engine.core.bll.AddV<wbr>mTemplateCommand@35c1cbd5<br>
2017-04-24 13:34:50,095-04 INFO<br>
[org.ovirt.engine.core.utils.t<wbr>ransaction.TransactionSupport]<br>
(DefaultQuartzScheduler10) [] transaction rolled back<br>
2017-04-24 13:34:50,123-04 INFO<br>
[org.ovirt.engine.core.dal.dbb<wbr>roker.auditloghandling.AuditLo<wbr>gDirector]<br>
(DefaultQuartzScheduler10) [] EVENT_ID:<br>
USER_IMPORT_IMAGE_AS_TEMPLATE_<wbr>FINISHED_SUCCESS(3,018), Correlation ID:<br>
199ed356-0960-4ef4-9637-09c76a<wbr>07c932, Job ID:<br>
0b91fec3-97be-493f-9dfb-af1230<wbr>e4d3ee, Call Stack: null, Custom Event<br>
ID: -1, Message: User admin@internal-authz successfully imported image<br>
CirrOS_0.3.4_for_x86_64_glance<wbr>_template as template<br>
CirrOS_0.3.4_for_x86_64_glance<wbr>_template to domain iscsi.<br>
2017-04-24 13:34:50,123-04 ERROR<br>
[org.ovirt.engine.core.bll.tas<wbr>ks.CommandCallbacksPoller]<br>
(DefaultQuartzScheduler10) [] Failed invoking callback end method<br>
'onSucceeded' for command '25028c51-d877-44e3-b1ef-40b31<wbr>5b469d3' with<br>
exception 'null', the callback is marked for end method retries<br>
<br>
Thanks,<br>
Nadav.<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>