<div dir="ltr">The current scheme seems a little buggy on FF. See how the top green bar is not stretched to cover the top of the oVirt logo.<br><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 6 May 2017 at 12:49, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Here's my take.<div><br></div><div>The line on the top is a little thicker than I like, but we have the same thickness in oVirt (I checked). I'm ok with shrinking it in both places.</div><div><br></div><div>I put in the logo from the oVirt login page. I added patternfly and bootstrap. Changed the font to OpenSans. Positioned things and fixed paddings. Changed the button and form field to patternfly type (blue button)</div></div></blockquote><div><br></div></span><div>Looks very good now. I wonder how far are we from being ADA compliant (also a general question to our UI - I know Patternfly should help us there as well).</div><span class="HOEnZb"><font color="#888888"><div>Y.</div></font></span><div><div class="h5"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Best wishes,</div><div>Greg</div><div><br></div></div><div class="gmail_extra"><div><div class="m_-7223758443414663172h5"><br><div class="gmail_quote">On Fri, May 5, 2017 at 2:15 AM, Roy Golan <span dir="ltr"><<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div>Adding UX people <a class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410GWVZpf m_-7223758443414663172m_6817677305274670962m_7205283961653565410gW" id="m_-7223758443414663172m_6817677305274670962m_7205283961653565410IloFPc-1" href="mailto:info@eldanet.com" target="_blank">+Eldan Hildesheim</a> <a class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410GWVZpf m_-7223758443414663172m_6817677305274670962m_7205283961653565410gW" id="m_-7223758443414663172m_6817677305274670962m_7205283961653565410IloFPc-2" href="mailto:awels@redhat.com" target="_blank">+Alexander Wels</a> <a class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410GWVZpf m_-7223758443414663172m_6817677305274670962m_7205283961653565410gW" id="m_-7223758443414663172m_6817677305274670962m_7205283961653565410IloFPc-3" href="mailto:gshereme@redhat.com" target="_blank">+Greg Sheremeta</a> <br><br></div><div><div class="m_-7223758443414663172m_6817677305274670962h5"><div><div class="gmail_quote"><div dir="ltr">On Fri, May 5, 2017 at 2:32 AM Martin Perina <<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin <<a href="mailto:ederevea@redhat.com" target="_blank">ederevea@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks everyone for the great feedback!<div><br></div><div>So there's two options I see now:</div><div>1) keep the default header scheme with white background, just add the project logo into the corner</div><div>2) try to adapt to the Patternfly scheme as used in oVirt's Admin UI currently.</div><div><br></div><div>I've swapped the header background color to #393f45 as used in oVirt for a quick test:</div><div><a href="https://gerrit-staging.phx.ovirt.org/" target="_blank">https://gerrit-staging.phx.ovi<wbr>rt.org/</a></div></div></blockquote><div><br></div><div>Looks good!</div></div></div></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br><div>Much better for my eyes now, thanks a lot!<br></div> </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div><div>The oVirt logo needs little more space around it, and it also should be centered vertically.</div><div>Modifying the logo margin to 8px and width to 108px works for me using chrome,<br></div><div>see attached screenshot.</div><div><br></div><div><img src="cid:15bd472f669c80ce0602" alt="Screenshot from 2017-05-04 20-11-39.png" style="max-width:100%"><br></div><div><br></div><div>Nir</div><br class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607inbox-inbox-Apple-interchange-newline"></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Is this more readable? If yes - I can continue working in this direction to add gradients</div><div>and other patternfly style elements. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Otherwise I'll just go with option 1 and stick to the default style we have now.</div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span>> It will help if someone can suggest an alternate CSS which we can use or specific color codes,<br><div class="gmail_extra"><br></div></span><div class="gmail_extra">Well.. keep it as it is or make it really dark (like the patternfly menu). I do not care about logos but big area filled with non-neutral color is always going to be an issue.</div><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203HOEnZb"><font color="#888888"><div class="gmail_extra"><br></div><div class="gmail_extra">Martin</div></font></span><div><div class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-">On Thu, May 4, 2017 at 3:05 PM, Martin Perina <span dir="ltr"><<a href="mailto:mperina@redhat.com" target="_blank">mperina@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">I agree with Milan and Martin, even after few minutes looking at it, the green<br>with combination of white background just made my eyes burning :-(<br><br></div><div style="font-family:arial,helvetica,sans-serif">Would it be possible to use more darker colors (at least for top banner/menu)?<br>For example darker colors we use in oVirt engine welcome page ...</div></div></blockquote><div><br></div></span><div>Thanks for the feedback,</div><div>It will help if someone can suggest an alternate CSS which we can use or specific color codes,</div><div>otherwise it will be long trial and error process until we'll find something that will suite everyone.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-h5"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-m_-8426331096979698991HOEnZb"><font color="#888888"><br><br></font></span></div><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-m_-8426331096979698991HOEnZb"><font color="#888888"><div style="font-family:arial,helvetica,sans-serif">Martin<br></div></font></span><div><div class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-m_-8426331096979698991h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I agree with Milan here. The light green background makes the menu<br>
items to be almost unreadable, the search button (slightly different<br>
green color) blends with the background and generally the color pulls<br>
my eyes away from the content. I wouldn't feel comfortable looking at<br>
the screen for a whole day.<br>
<br>
Martin<br>
<br>
On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <<a href="mailto:mzamazal@redhat.com" target="_blank">mzamazal@redhat.com</a>> wrote:<br>
> Evgheni Dereveanchin <<a href="mailto:ederevea@redhat.com" target="_blank">ederevea@redhat.com</a>> writes:<br>
><br>
>> The Infra team is working on customizing the look of Gerrit to make it fit<br>
>> better with other oVirt services. I want to share the result of this<br>
>> effort. Hopefully we can gather some feedback before applying the design to<br>
>> oVirt's instance of Gerrit.<br>
>><br>
>> Please visit the Staging instance to check it out:<br>
>><br>
>> <a href="https://gerrit-staging.phx.ovirt.org/" rel="noreferrer" target="_blank">https://gerrit-staging.phx.ov<wbr>irt.org/</a><br>
><br>
> Thank you for the preview. While it fits better with oVirt services,<br>
> there is one thing that makes me uncomfortable with it: low contrast.<br>
> The top green bar is probably directly violating Web Accessibility<br>
> Guidelines (AA level; see<br>
> <a href="https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast" rel="noreferrer" target="_blank">https://www.w3.org/TR/WCAG20/#<wbr>visual-audio-contrast-contrast</a><wbr>), but I<br>
> find all the green parts harder to read than in the current version.<br>
> So it would be nice if the contrast could be improved.<br>
><br>
> Thanks,<br>
> Milan<br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote></div><br></div></div></div></div>
<br></div></div><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-">______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
<br></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203m_5203219111087275683gmail-m_-8426331096979698991gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold"><font color="#cc0000">Eyal edri</font></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><br></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">ASSOCIATE MANAGER</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">RHV DevOps</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><br></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat EMEA</a></p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div>phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div>
</div></div>
</blockquote></div><br></div></div></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br><br clear="all"><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747HOEnZb"><font color="#888888"><div><br></div></font></span></div><span class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747HOEnZb"><font color="#888888"><div class="gmail_extra">-- <br><div class="m_-7223758443414663172m_6817677305274670962m_7205283961653565410m_-1675475041217025985m_2069640828238704747m_3954376673917468607m_-4381485728848953203gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div style="font-size:small">Regards,</div><div style="font-size:small">Evgheni Dereveanchin</div></div></div>
</div>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></font></span></blockquote></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div></div></div>
______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/infra</a><br>
</blockquote></div></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="m_-7223758443414663172HOEnZb"><font color="#888888">-- <br><div class="m_-7223758443414663172m_6817677305274670962gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Greg Sheremeta, MBA<br><span style="font-size:12.8px">Sr. Software Engineer</span><br></div><div>Red Hat, Inc.<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div></div></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div></div></div><br></div></div>
<br>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Barak Korren<br>RHV DevOps team , RHCE, RHCi<br>Red Hat EMEA<br><a href="http://redhat.com" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" target="_blank">redhat.com/trusted</a></div>
</div>