<div dir="ltr"><div><div>This patch should fix it: <a href="https://gerrit.ovirt.org/#/c/76630">https://gerrit.ovirt.org/#/c/76630</a><br></div>Checked against OST and it passed.<br><br></div>Some small debate on the how in the patch, will check with Dan to merge an agreed version asap.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 9, 2017 at 3:53 PM, Oved Ourfali <span dir="ltr"><<a href="mailto:oourfali@redhat.com" target="_blank">oourfali@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">CC-ing Edi.<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, May 9, 2017 at 3:46 PM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br></span><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Tue, May 9, 2017 at 3:44 PM, Piotr Kliczewski<br>
<<a href="mailto:piotr.kliczewski@gmail.com" target="_blank">piotr.kliczewski@gmail.com</a>> wrote:<br>
> It seems to be broken by this patch [1]<br>
><br>
><br>
> [1] <a href="https://gerrit.ovirt.org/#/c/76603" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>6603</a><br>
<br>
</span>Indeed. Please revert for now [1], then investigate.<br>
<br>
[1] <a href="https://gerrit.ovirt.org/76626" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/76626</a><br>
<div class="m_-5944488473383669089HOEnZb"><div class="m_-5944488473383669089h5"><br>
><br>
> On Tue, May 9, 2017 at 2:40 PM, Anton Marchukov <<a href="mailto:amarchuk@redhat.com" target="_blank">amarchuk@redhat.com</a>> wrote:<br>
>> Hello.<br>
>><br>
>> Today around 11 am the add host for master started to consistently fail.<br>
>><br>
>> We found the following in /var/log/messages (as I understand it might get<br>
>> there through journald as the host deploy log claims that vdsmd unit startup<br>
>> failed):<br>
>><br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: Traceback (most<br>
>> recent call last):<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/bin/vdsm-tool", line 219, in main<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: return<br>
>> tool_command[cmd]["command"](*<wbr>args)<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/tool/network.py", line 48, in<br>
>> upgrade_networks<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> netupgrade.upgrade()<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/network/netupgrade.<wbr>py", line 55, in<br>
>> upgrade<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> _create_unified_configuration(<wbr>rconfig, NetInfo(netinfo(vdsmnets)))<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/network/netupgrade.<wbr>py", line 133, in<br>
>> _create_unified_configuration<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> RunningConfig.store()<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/network/netconfpersis<wbr>tence.py", line<br>
>> 204, in store<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: _store_net_config()<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/network/netconfpersis<wbr>tence.py", line<br>
>> 281, in _store_net_config<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> utils.rmTree(real_old_safeconf<wbr>_dir)<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/utils.py", line 125, in rmTree<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> shutil.rmtree(directoryToRemov<wbr>e)<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib64/python2.7/shutil.p<wbr>y", line 232, in rmtree<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
>> onerror(os.path.islink, path, sys.exc_info())<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
>> "/usr/lib64/python2.7/shutil.p<wbr>y", line 230, in rmtree<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: raise<br>
>> OSError("Cannot call rmtree on a symbolic link")<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: OSError: Cannot<br>
>> call rmtree on a symbolic link<br>
>> May 9 07:01:25 lago-basic-suite-master-host1 systemd: vdsm-network.service:<br>
>> control process exited, code=exited status=1<br>
>><br>
>><br>
>> The full logs of the run you can find in Jenkins artifacts:<br>
>><br>
>> <a href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6589/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/6589/artifact/exported-ar<wbr>tifacts/basic-suit-master-el7/<wbr>test_logs/basic-suite-master/<wbr>post-002_bootstrap.py/</a><br>
>><br>
>><br>
>> Any vdsm patches merged that might cause this?<br>
>><br>
>> --<br>
>><br>
>> Anton Marchukov<br>
>> Senior Software Engineer - RHEV CI - Red Hat<br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> Devel mailing list<br>
>> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
<br>
<br>
<br>
</div></div><span class="m_-5944488473383669089HOEnZb"><font color="#888888">--<br>
Didi<br>
</font></span><div class="m_-5944488473383669089HOEnZb"><div class="m_-5944488473383669089h5">______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
<br>
<br>
</div></div></blockquote></div></div></div><br></div>
</blockquote></div><br></div>