<div dir="ltr"><div><div>You cannot revert it, the original was wrong.<br></div>This is not suppose to be a symlink but an actual directory.<br></div>QE reported it to fail yesterday.<br><br><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 9, 2017 at 3:46 PM, Yedidyah Bar David <span dir="ltr">&lt;<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, May 9, 2017 at 3:44 PM, Piotr Kliczewski<br>
&lt;<a href="mailto:piotr.kliczewski@gmail.com">piotr.kliczewski@gmail.com</a>&gt; wrote:<br>
&gt; It seems to be broken by this patch [1]<br>
&gt;<br>
&gt;<br>
&gt; [1] <a href="https://gerrit.ovirt.org/#/c/76603" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>76603</a><br>
<br>
</span>Indeed. Please revert for now [1], then investigate.<br>
<br>
[1] <a href="https://gerrit.ovirt.org/76626" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/76626</a><br>
<div class="HOEnZb"><div class="h5"><br>
&gt;<br>
&gt; On Tue, May 9, 2017 at 2:40 PM, Anton Marchukov &lt;<a href="mailto:amarchuk@redhat.com">amarchuk@redhat.com</a>&gt; wrote:<br>
&gt;&gt; Hello.<br>
&gt;&gt;<br>
&gt;&gt; Today around 11 am the add host for master started to consistently fail.<br>
&gt;&gt;<br>
&gt;&gt; We found the following in /var/log/messages (as I understand it might get<br>
&gt;&gt; there through journald as the host deploy log claims that vdsmd unit startup<br>
&gt;&gt; failed):<br>
&gt;&gt;<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: Traceback (most<br>
&gt;&gt; recent call last):<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/bin/vdsm-tool&quot;, line 219, in main<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: return<br>
&gt;&gt; tool_command[cmd][&quot;command&quot;](*<wbr>args)<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/tool/network.py&quot;<wbr>, line 48, in<br>
&gt;&gt; upgrade_networks<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; netupgrade.upgrade()<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/network/<wbr>netupgrade.py&quot;, line 55, in<br>
&gt;&gt; upgrade<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; _create_unified_configuration(<wbr>rconfig, NetInfo(netinfo(vdsmnets)))<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/network/<wbr>netupgrade.py&quot;, line 133, in<br>
&gt;&gt; _create_unified_configuration<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; RunningConfig.store()<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/network/<wbr>netconfpersistence.py&quot;, line<br>
&gt;&gt; 204, in store<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: _store_net_config()<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/network/<wbr>netconfpersistence.py&quot;, line<br>
&gt;&gt; 281, in _store_net_config<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; utils.rmTree(real_old_<wbr>safeconf_dir)<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib/python2.7/site-<wbr>packages/vdsm/utils.py&quot;, line 125, in rmTree<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; shutil.rmtree(<wbr>directoryToRemove)<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib64/python2.7/shutil.<wbr>py&quot;, line 232, in rmtree<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool:<br>
&gt;&gt; onerror(os.path.islink, path, sys.exc_info())<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: File<br>
&gt;&gt; &quot;/usr/lib64/python2.7/shutil.<wbr>py&quot;, line 230, in rmtree<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: raise<br>
&gt;&gt; OSError(&quot;Cannot call rmtree on a symbolic link&quot;)<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 vdsm-tool: OSError: Cannot<br>
&gt;&gt; call rmtree on a symbolic link<br>
&gt;&gt; May  9 07:01:25 lago-basic-suite-master-host1 systemd: vdsm-network.service:<br>
&gt;&gt; control process exited, code=exited status=1<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; The full logs of the run you can find in Jenkins artifacts:<br>
&gt;&gt;<br>
&gt;&gt; <a href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6589/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>test-repo_ovirt_experimental_<wbr>master/6589/artifact/exported-<wbr>artifacts/basic-suit-master-<wbr>el7/test_logs/basic-suite-<wbr>master/post-002_bootstrap.py/</a><br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; Any vdsm patches merged that might cause this?<br>
&gt;&gt;<br>
&gt;&gt; --<br>
&gt;&gt;<br>
&gt;&gt; Anton Marchukov<br>
&gt;&gt; Senior Software Engineer - RHEV CI - Red Hat<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; ______________________________<wbr>_________________<br>
&gt;&gt; Devel mailing list<br>
&gt;&gt; <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
&gt;&gt; <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
&gt; ______________________________<wbr>_________________<br>
&gt; Devel mailing list<br>
&gt; <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
&gt; <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Didi<br>
</font></span></blockquote></div><br></div></div></div></div></div></div>