<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 17, 2017 at 2:35 PM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">On Wed, May 17, 2017 at 2:54 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
> On Wed, May 17, 2017 at 12:23 PM, Yedidyah Bar David <<a href="mailto:didi@redhat.com">didi@redhat.com</a>> wrote:<br>
>> On Wed, May 17, 2017 at 11:42 AM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
>>> On Wed, May 17, 2017 at 10:44 AM, Yedidyah Bar David <<a href="mailto:didi@redhat.com">didi@redhat.com</a>> wrote:<br>
>>>> On Wed, May 17, 2017 at 9:38 AM, Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br>
>>>>> On Tue, May 16, 2017 at 6:56 PM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
>>>>>><br>
>>>>>> Hi,<br>
>>>>>> with <a href="https://gerrit.ovirt.org/76855" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/76855</a> it's requested to increase the appliance size by adding ovirt-provider-ovn and its dependencies.<br>
>>>>>><br>
>>>>>> This raise a few questions.<br>
>>>>>> The support for ovirt-provider-ovn is enabled by default in engine-setup and going to be installed by default in the appliance so we're pushing to use it.<br>
>>>>>> Why not requiring it at ovirt-engine spec file level?<br>
>>>>>> Answer given in the commit message of above patch is:<br>
>>>>>><br>
>>>>>> We do not want to have a hard dependency in the<br>
>>>>>> form of an rpm require.<br>
>>>>>> OVN and openvswitch are relatively heavy and complex,<br>
>>>>>> and are still experimental. We would not want to<br>
>>>>>> force everybody to pull them onto any Engine host.<br>
>>>>>><br>
>>>>>> So why adding it to the appliance, which is the default for hosted engine which is our recommeded way to deploy oVirt, and enable it by default?<br>
>>>>>><br>
>>>>>> How this differs from DWH? ovirt-engine requires ovirt-engine-setup which requires ovirt-engine-dwh setup which requires ovirt-engine-dwh.<br>
>>>>>> Why can't we just require ovirt-provider-ovn in ovirt-engine instead of tweaking the appliance?<br>
>>>>>><br>
>>>>>> If we decide it's not mandatory, why not make the default to not enabling it in engine-setup and avoid to add it to the appliance?<br>
>>>>>> Being optional, adding it collides with Bug 1401931 - [RFE] reduce the size of the appliance<br>
>>>>><br>
>>>>> Much like with DWH, I can envisage a use case where ovirt-provider-ovn<br>
>>>>> sits on a remote host, rather than on Engine's. However, the default<br>
>>>>> use case is to place them on the same host.<br>
>>>>><br>
>>>>> I thought that it would be a good idea to include OVN on the<br>
>>>>> appliance, as a means to showcase this new and exciting feature of<br>
>>>>> oVirt. However, it is not a must. We can say that we'd like to keep<br>
>>>>> the appliance small; if someone wants to use OVN with it, let them run<br>
>>>>> ovirt-engine-setup manually, and pull in the dependencies.<br>
>>>><br>
>>>> The appliance is assumed to (soon?) be our standard installation flow,<br>
>>>> not a way to showcase things. For the latter, you might want to add ovn<br>
>>>> to ovirt-live or to the ovirt demo tool [1] (not yet released IIUC).<br>
>>>><br>
>>>> [1] <a href="https://trello.com/b/wocfflzf/sales-demo-tool-lago-based" rel="noreferrer" target="_blank">https://trello.com/b/wocfflzf/<wbr>sales-demo-tool-lago-based</a><br>
>>>><br>
>>>>><br>
>>>>> For this we'd need to flip the default, and not install OVN when the<br>
>>>>> appliance is created, and skip OVN test in the offline test suite.<br>
>>>><br>
>>>> +1<br>
>>><br>
>>> Could you point us to the answer file used for appliance creation?<br>
>><br>
>> Do you want to keep the default True for non-appliance? My +1 above<br>
>> was also for reverting the default, not only in appliance.<br>
><br>
> Oh. I still want to have OVN by default for non-appliance. I like this<br>
> feature, and I want to entice people to use it.<br>
<br>
</div></div>I think that Sandro's question above applies equally well to the<br>
non-appliance usecase. If it's good enough to be the default for<br>
non-appliance, might as well be so for the appliance as well. If<br>
it's not good enough for the appliance, perhaps default to No also<br>
for non-appliance.<br>
<span class="gmail-"><br>
><br>
> For appliance I understand that we have a size limitation, so ok, let<br>
> us not bloat it up.<br>
<br>
</span>What's the impact on size? For the appliance image and for the<br>
eventually-installed machine?<br>
<br>
I do not think the impact on appliance size is the major question here,<br>
but whether we really expect most users to use OVN. But I might be<br>
surprised...<br>
<span class="gmail-im gmail-HOEnZb"><br></span></blockquote><div><br></div><div>Now we have a bug to track it:</div><div><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1452131">https://bugzilla.redhat.com/show_bug.cgi?id=1452131</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-im gmail-HOEnZb">
><br>
> I hope you are also fine with disabling ovn in the following answer file.<br>
><br>
>><br>
>> The appliance-supplied answer file seems is:<br>
>><br>
>> <a href="https://gerrit.ovirt.org/gitweb?p=ovirt-appliance.git;a=blob;f=engine-appliance/data/ovirt-engine-answers;h=2881af6563297a7a3d220dfe479d39f88c12ca46;hb=HEAD" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/<wbr>gitweb?p=ovirt-appliance.git;<wbr>a=blob;f=engine-appliance/<wbr>data/ovirt-engine-answers;h=<wbr>2881af6563297a7a3d220dfe479d39<wbr>f88c12ca46;hb=HEAD</a><br>
>><br>
>> When hosted-engine --deploy is using the appliance, and if the user<br>
>> asks to run engine-setup automatically, it uses above file,<br>
>> but also adds another file, auto-generated, see here:<br>
>><br>
>> <a href="https://gerrit.ovirt.org/gitweb?p=ovirt-hosted-engine-setup.git;a=blob;f=src/plugins/gr-he-common/vm/cloud_init.py;h=0a20f946d65199423c99769ab51e4fe092465e96;hb=HEAD#l1018" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/<wbr>gitweb?p=ovirt-hosted-engine-<wbr>setup.git;a=blob;f=src/<wbr>plugins/gr-he-common/vm/cloud_<wbr>init.py;h=<wbr>0a20f946d65199423c99769ab51e4f<wbr>e092465e96;hb=HEAD#l1018</a><br>
>><br>
>> None of them has the answer for OVN. Latter has:<br>
>><br>
>> DIALOG/autoAcceptDefault=bool:<wbr>True<br>
>><br>
>> For this, see:<br>
>><br>
>> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1270719" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1270719</a><br>
<br>
<br>
<br>
</span><span class="gmail-HOEnZb"><font color="#888888">--<br>
Didi<br>
</font></span><div class="gmail-HOEnZb"><div class="gmail-h5">______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div></div>