<div dir="auto">If you want to see the files I have changed then they are as same as done in this push <a href="https://gerrit.ovirt.org/#/c/63097/">https://gerrit.ovirt.org/#/c/63097/</a>. <div dir="auto"><div dir="auto"><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 23 May 2017 12:36 a.m., "shubham dubey" <<a href="mailto:sdubey504@gmail.com">sdubey504@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">No, my changes are related to storage domain (adding new flag in storage domain db entries). I have done some changes in unit tests dao files to test those changes only but nothing related to icon. </div><div class="gmail_extra"><br><div class="gmail_quote">On 23 May 2017 12:14 a.m., "Greg Sheremeta" <<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 22, 2017 at 2:34 PM, shubham dubey <span dir="ltr"><<a href="mailto:sdubey504@gmail.com" target="_blank">sdubey504@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I have done some changes </div></div></blockquote><div><br></div><div>What did you change?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>in ovirt-engine now while compiling I am getting following error in file<br>VmIconDaoTest.<br><br>Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.466 sec <<< FAILURE!<br>testGetVmIconByDataUrlWithVali<wbr>dUrl(org.ovirt.engine.core.dao<wbr>.VmIconDaoTest) Time elapsed: 18 sec <<< FAILURE!<br>java.lang.AssertionError: expected:<1> but was:<0><br> at org.junit.Assert.fail(Assert.j<wbr>ava:88)<br> at org.junit.Assert.failNotEquals<wbr>(Assert.java:834)<br> at org.junit.Assert.assertEquals(<wbr>Assert.java:645)<br> at org.junit.Assert.assertEquals(<wbr>Assert.java:631)<br> at org.ovirt.engine.core.dao.VmIc<wbr>onDaoTest.testGetVmIconByDataU<wbr>rlWithValidUrl(VmIconDaoTest.j<wbr>ava:59)<br> at sun.reflect.NativeMethodAccess<wbr>orImpl.invoke0(Native Method)<br> at sun.reflect.NativeMethodAccess<wbr>orImpl.invoke(NativeMethodAcce<wbr>ssorImpl.java:62)<br> at sun.reflect.DelegatingMethodAc<wbr>cessorImpl.invoke(DelegatingMe<wbr>thodAccessorImpl.java:43)<br> at java.lang.reflect.Method.invok<wbr>e(Method.java:498)<br> at org.junit.runners.model.Framew<wbr>orkMethod$1.runReflectiveCall(<wbr>FrameworkMethod.java:50)<br> at org.junit.internal.runners.mod<wbr>el.ReflectiveCallable.run(Refl<wbr>ectiveCallable.java:12)<br> at org.junit.runners.model.Framew<wbr>orkMethod.invokeExplosively(Fr<wbr>ameworkMethod.java:47)<br> at org.junit.internal.runners.sta<wbr>tements.InvokeMethod.evaluate(<wbr>InvokeMethod.java:17)<br> at org.junit.internal.runners.sta<wbr>tements.RunBefores.evaluate(Ru<wbr>nBefores.java:26)<br> at org.springframework.test.conte<wbr>xt.junit4.statements.RunBefore<wbr>TestMethodCallbacks.evaluate(R<wbr>unBeforeTestMethodCallbacks.ja<wbr>va:75)<br> at org.springframework.test.conte<wbr>xt.junit4.statements.RunAfterT<wbr>estMethodCallbacks.evaluate(Ru<wbr>nAfterTestMethodCallbacks.java<wbr>:86)<br> at org.springframework.test.conte<wbr>xt.junit4.statements.SpringRep<wbr>eat.evaluate(SpringRepeat.java<wbr>:84)<br> at org.junit.runners.ParentRunner<wbr>.runLeaf(ParentRunner.java:325<wbr>)<br> at org.springframework.test.conte<wbr>xt.junit4.SpringJUnit4ClassRun<wbr>ner.runChild(SpringJUnit4Class<wbr>Runner.java:254)<br> at org.springframework.test.conte<wbr>xt.junit4.SpringJUnit4ClassRun<wbr>ner.runChild(SpringJUnit4Class<wbr>Runner.java:89)<br> at org.junit.runners.ParentRunner<wbr>$3.run(ParentRunner.java:290)<br> at org.junit.runners.ParentRunner<wbr>$1.schedule(ParentRunner.java:<wbr>71)<br> at org.junit.runners.ParentRunner<wbr>.runChildren(ParentRunner.java<wbr>:288)<br> at org.junit.runners.ParentRunner<wbr>.access$000(ParentRunner.java:<wbr>58)<br> at org.junit.runners.ParentRunner<wbr>$2.evaluate(ParentRunner.java:<wbr>268)<br> at org.junit.internal.runners.sta<wbr>tements.RunBefores.evaluate(Ru<wbr>nBefores.java:26)<br> at org.springframework.test.conte<wbr>xt.junit4.statements.RunBefore<wbr>TestClassCallbacks.evaluate(Ru<wbr>nBeforeTestClassCallbacks.java<wbr>:61)<br> at org.springframework.test.conte<wbr>xt.junit4.statements.RunAfterT<wbr>estClassCallbacks.evaluate(Run<wbr>AfterTestClassCallbacks.java:7<wbr>0)<br> at org.junit.runners.ParentRunner<wbr>.run(ParentRunner.java:363)<br> at org.springframework.test.conte<wbr>xt.junit4.SpringJUnit4ClassRun<wbr>ner.run(SpringJUnit4ClassRunne<wbr>r.java:193)<br> at org.apache.maven.surefire.juni<wbr>t4.JUnit4Provider.execute(JUni<wbr>t4Provider.java:252)<br> at org.apache.maven.surefire.juni<wbr>t4.JUnit4Provider.executeTestS<wbr>et(JUnit4Provider.java:141)<br> at org.apache.maven.surefire.juni<wbr>t4.JUnit4Provider.invoke(JUnit<wbr>4Provider.java:112)<br> at sun.reflect.NativeMethodAccess<wbr>orImpl.invoke0(Native Method)<br> at sun.reflect.NativeMethodAccess<wbr>orImpl.invoke(NativeMethodAcce<wbr>ssorImpl.java:62)<br> at sun.reflect.DelegatingMethodAc<wbr>cessorImpl.invoke(DelegatingMe<wbr>thodAccessorImpl.java:43)<br> at java.lang.reflect.Method.invok<wbr>e(Method.java:498)<br> at org.apache.maven.surefire.util<wbr>.ReflectionUtils.invokeMethodW<wbr>ithArray(ReflectionUtils.java:<wbr>189)<br> at org.apache.maven.surefire.boot<wbr>er.ProviderFactory$ProviderPro<wbr>xy.invoke(ProviderFactory.java<wbr>:165)<br> at org.apache.maven.surefire.boot<wbr>er.ProviderFactory.invokeProvi<wbr>der(ProviderFactory.java:85)<br> at org.apache.maven.surefire.boot<wbr>er.ForkedBooter.runSuitesInPro<wbr>cess(ForkedBooter.java:115)<br> at org.apache.maven.surefire.boot<wbr>er.ForkedBooter.main(ForkedBoo<wbr>ter.java:75)<br><br>...<br>...<br>Failed tests: testGetVmIconByDataUrlWithVali<wbr>dUrl(org.ovirt.engine.core.dao<wbr>.VmIconDaoTest): expected:<1> but was:<0><br><br></div>I haven't even done any change in VmIconDaoTest file but this error is there.<br><div>I even try to change the value result.get(0) to result.get(1) in testGetVmIconByDataUrlWithVali<wbr>dUrl but that didn't work.<br></div></div></blockquote><div><br></div><div>This is a "unit test." It's rare that you'd want to change it. Its purpose it to inform you that you've probably broken something somewhere else -- likely in the very thing this test is testing, aka the "unit." By the test that's failing, I'd guess that you've changed some code around the Icons feature.</div><div><br></div><div>Greg</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br><br></div><div>Thanks in advance.<span class="m_2133876546685648643m_84311073501476631m_-8377726333361285849HOEnZb"><font color="#888888"><br><br></font></span></div><span class="m_2133876546685648643m_84311073501476631m_-8377726333361285849HOEnZb"><font color="#888888"><div>Shubham<br></div></font></span></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_2133876546685648643m_84311073501476631m_-8377726333361285849gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Greg Sheremeta, MBA<br><span style="font-size:12.8px">Sr. Software Engineer</span><br></div><div>Red Hat, Inc.<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div></div></div>
</div></div>
</blockquote></div></div>
</blockquote></div></div>