<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">+1 on bumping to NodeJS v8.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">According to [1] the build should pass with gcc v6, but seems that fc26 ships gcc v7 only.<br><br>[1] <a href="https://github.com/nodejs/node/issues/10388#issuecomment-283056552">https://github.com/nodejs/node/issues/10388#issuecomment-283056552</a><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The root cause is indeed an ill-formed NodeJS source code. Using older gcc to build it isn't a proper solution.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">According to [2] the NodeJS v6 "active LTS" period ends at April 2018, however this is a build-related bug, and the GitHub issue is closed with resolution "fixed in next v7 release" (note that v7 is not LTS).<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[2] <a href="https://github.com/nodejs/LTS">https://github.com/nodejs/LTS</a><br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Even though NodeJS v8 "active LTS" period starts at October 2017 (in ~4 months), I'm OK with us bumping to v8 now.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">(If we face any problems with v8, we can "downgrade" to v7 if necessary.)<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards,<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Vojtech<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 31, 2017 at 8:54 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Wed, May 31, 2017 at 2:45 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="ltr">Root cause is a node bug: <a href="https://github.com/nodejs/node/issues/11118" target="_blank">https://github.com/nodejs<wbr>/node/issues/11118</a></div><div dir="ltr"><br></div><div dir="ltr">patch is <a href="https://gerrit.ovirt.org/#/c/77568" target="_blank">https://gerrit.ovirt.org/#/<wbr>c/77568</a></div></div></blockquote><div><br></div></span><div>+1</div><div><div class="gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="ltr"><div>which simply bumps us to node 8, which coincidentally was released today. Looks like the fix isn't going into the node 6 line. </div><span class="gmail-m_-2395937575571095428HOEnZb"><font color="#888888"><div dir="auto"><br></div><div>Greg</div></font></span></div></div><div class="gmail-m_-2395937575571095428HOEnZb"><div class="gmail-m_-2395937575571095428h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 30, 2017 at 8:12 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I'll take care of it. Thanks for letting us know :)</div><div class="gmail_extra"><div><div class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832h5"><br><div class="gmail_quote">On Mon, May 29, 2017 at 9:33 AM, Sandro Bonazzola <span dir="ltr"><<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div>just an heads up that ovirt-engine-nodejs fails to build on fc26: </div><div><a href="http://jenkins.ovirt.org/job/ovirt-engine-nodejs_master_build-artifacts-fc26-x86_64/1/consoleFull" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-engine-nodejs_master_buil<wbr>d-artifacts-fc26-x86_64/1/cons<wbr>oleFull</a></div><span class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832m_4905697782364045511HOEnZb"><font color="#888888"><div><br clear="all"><div><br></div>-- <br><div class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832m_4905697782364045511m_-1763062671194697168gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>SANDRO</span> <span>BONAZZOLA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>EMEA</span></a></p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img height="auto" width="90"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></div></td></tr></tbody></table></div></div></div></div></div></div></div>
</div></font></span></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832HOEnZb"><font color="#888888">-- <br><div class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832m_4905697782364045511gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Greg Sheremeta, MBA<br><span style="font-size:12.8px">Sr. Software Engineer</span><br></div><div>Red Hat, Inc.<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-2395937575571095428m_-7044107438164912784m_8157466149551680832gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Greg Sheremeta, MBA<br><span style="font-size:12.8px">Sr. Software Engineer</span><br></div><div>Red Hat, Inc.<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div></div></div>
</div>
</div></div></blockquote></div></div></div><div><div class="gmail-h5"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_-2395937575571095428gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>SANDRO</span> <span>BONAZZOLA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>EMEA</span></a></p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" height="auto" width="90"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></div></td></tr></tbody></table></div></div></div></div></div></div></div>
</div></div></div></div>
</blockquote></div><br></div></div>