<div dir="ltr"><div><div>Thanks for help.<br></div>One more thing I want to know is that, is it necessary to fork the <br></div>ovirt-site first into your repository to send a pr.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 31, 2017 at 11:57 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, May 31, 2017 at 9:20 PM, shubham dubey <<a href="mailto:sdubey504@gmail.com">sdubey504@gmail.com</a>> wrote:<br>
> Hi,<br>
> I want to fix some issues in ovirt site. Since I never did a pull request<br>
> before,<br>
> hence want to know few things.<br>
> 1)can I fix multiple bug and send a single pr for them.<br>
<br>
</span>You can send one pull request, but each of its commits should fix a<br>
single issue. Then again, if the fixes are unrelated to each other,<br>
you'd better use different PRs.<br>
<span class=""><br>
> 2) when I fix a issue did I need to write something in the comment of the<br>
> bug (like 'fixed' or 'patch send').<br>
<br>
</span>Actually, you should usually write something longer, such as "fix a<br>
broken link" or "add a clearer paragraph, as the former text was<br>
confusing" - anything that can explain to your reviewer the motivation<br>
for your commit.<br>
<span class=""><br>
<br>
><br>
> thanks in advance and I will appreciate for extra related info:)<br>
><br>
> Shubham<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
</blockquote></div><br></div>