<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi Jakub, thanks for taking the effort to simplify AppErrors handling!<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The AppErrors.properties file and its localized variants should live in a single location, e.g. frontend/webadmin/modules/frontend. We should avoid having multiple AppErrors.properties copies spread across the codebase.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">The backend dal (data access layer) module has its own copy of AppErrors.properties file. One option is to copy it from the source location during Engine build, another option is to simply use symlinks.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">In any case, there should be a unit test that ensures all EngineMessage enum members are reflected as methods in AppErrors interface. This will give us the confidence that backend EngineMessage's have proper strings associated with them.<br><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards,<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Vojtech</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 8:51 PM, Jakub Niedermertl <span dir="ltr"><<a href="mailto:jniederm@redhat.com" target="_blank">jniederm@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi all,<br><br></div>there is a patch [1] removing `AppErrors.properties` from webadmin project to simplify edits of AppErrors/EngineMessage. AppErrors.properties from webadmin project will be merged to AppErrors.properties in frontend project. This requires some manual resolutions of conflicts of translation values.<br><br>I'd like to kindly ask you to review altered translation values. They are mostly just typos.<br><br></div>Thanks.<br></div>Jakub<br><div><div><br>[1]: <a href="https://gerrit.ovirt.org/#/c/76215/" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>76215/</a><br></div></div></div>
</blockquote></div><br></div></div>