<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Hi Jakub, thanks for taking the effort to simplify AppErrors handling!<br><br></div><div style="font-family:arial,helvetica,sans-serif">The AppErrors.properties file and its localized variants should live in a single location, e.g. frontend/webadmin/modules/fron<wbr>tend. We should avoid having multiple AppErrors.properties copies spread across the codebase.<br></div></div></blockquote><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline">Yes</div> <div class="gmail_default" style="font-family:monospace,monospace;display:inline">please!</div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline">Why do we even have these three copies? </div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline">I vaguely recall an explanation that there's a "default" properties file (the backend one?), and then the others can overrie specific keys (e.g., to make the user portal simpler and remove admin complexities) - but it doesn't seem as though the this is how it's used.</div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">The backend dal (data access layer) module has its own copy of AppErrors.properties file. One option is to copy it from the source location during Engine build, another option is to simply use symlinks.<br></div></div></blockquote><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline">Why</div> <div class="gmail_default" style="font-family:monospace,monospace;display:inline">do even have this file? For REST API/SDK errors?</div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">In any case, there should be a unit test that ensures all EngineMessage enum members are reflected as methods in AppErrors interface. This will give us the confidence that backend EngineMessage's have proper strings associated with them.<br></div></div></blockquote><div><span style="font-family:monospace,monospace">We've had <div class="gmail_default" style="font-family:monospace,monospace;display:inline">the opposite test for quite a long time:</div></span><br></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace"><a href="https://github.com/oVirt/ovirt-engine/commits/0c7d7e7101142b95bd78e76be08dbb121c0c90f7/frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java">https://github.com/oVirt/ovirt-engine/commits/0c7d7e7101142b95bd78e76be08dbb121c0c90f7/frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java</a></font><br></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace"><br></font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace">But in indeed did's have a test for missing methods in the AppErrors interface.</font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace">I tried cooking up a simple test and found that we're missing several hundred(!) keys, so I just carpet-bomb added them all, to be sorted out later:</font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace"><a href="https://gerrit.ovirt.org/#/c/78354/">https://gerrit.ovirt.org/#/c/78354/</a></font><br></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace"><br></font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace">However, I'm getting a weird GWT error when I try to build the application:</font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace"><div><br></div><div>[ERROR] Errors in 'gen/org/ovirt/engine/ui/frontend/com_gwtplatform_mvp_client_DesktopGinjector_DesktopGinjectorGinjector_fragment.java'</div><div>[INFO] [ERROR] Line 50: Failed to resolve 'org.ovirt.engine.ui.frontend.VdsmErrors' via deferred binding</div><div><br></div><div>I'm obviously doing something stupid I shouldn't be doing, but I must admit I don't understand what I'm doing wrong.</div><div>Some advice from our residenant GWT experts (yes Vojtech, I'm pointing at you :-)) woul be appreciated.</div></font></div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">Regards,<br></div><div style="font-family:arial,helvetica,sans-serif">Vojtech</div><div><div class="gmail-m_334994800606526553h5"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 8:51 PM, Jakub Niedermertl <span dir="ltr"><<a href="mailto:jniederm@redhat.com" target="_blank">jniederm@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi all,<br><br></div>there is a patch [1] removing `AppErrors.properties` from webadmin project to simplify edits of AppErrors/EngineMessage. AppErrors.properties from webadmin project will be merged to AppErrors.properties in frontend project. This requires some manual resolutions of conflicts of translation values.<br><br>I'd like to kindly ask you to review altered translation values. They are mostly just typos.<br><br></div>Thanks.<br></div>Jakub<br><div><div><br>[1]: <a href="https://gerrit.ovirt.org/#/c/76215/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>6215/</a><br></div></div></div>
</blockquote></div><br></div></div></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div></div>