<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Oh, that was stupid on my side - there are indeed several (hundred) properties missing, so we can't merge this test.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">I wonder how we should push this forward. It isn't just a technicality of adding entries to the properties file, we need to know what the message should be (which I don't, at least not for all of them).</div><div class="gmail_default" style="font-family:monospace,monospace">Unless we want to just have "TBD" there.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 21, 2017 at 9:33 AM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Jun 21, 2017 at 9:12 AM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:monospace,monospace"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_-5529518473000672390gmail-">On Tue, Jun 13, 2017 at 2:55 PM, Vojtech Szocs <span dir="ltr"><<a href="mailto:vszocs@redhat.com" target="_blank">vszocs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif">Hi Jakub, thanks for taking the effort to simplify AppErrors handling!<br><br></div><div style="font-family:arial,helvetica,sans-serif">The AppErrors.properties file and its localized variants should live in a single location, e.g. frontend/webadmin/modules/fron<wbr>tend. We should avoid having multiple AppErrors.properties copies spread across the codebase.<br></div></div></blockquote></span><div><div style="font-family:monospace,monospace;display:inline">Yes</div> <div style="font-family:monospace,monospace;display:inline">please!</div></div><div><div style="font-family:monospace,monospace;display:inline">Why do we even have these three copies? </div></div><div><div style="font-family:monospace,monospace;display:inline">I vaguely recall an explanation that there's a "default" properties file (the backend one?), and then the others can overrie specific keys (e.g., to make the user portal simpler and remove admin complexities) - but it doesn't seem as though the this is how it's used.</div></div><span class="m_-5529518473000672390gmail-"><div><div style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">The backend dal (data access layer) module has its own copy of AppErrors.properties file. One option is to copy it from the source location during Engine build, another option is to simply use symlinks.<br></div></div></blockquote></span><div><div style="font-family:monospace,monospace;display:inline">Why</div> <div style="font-family:monospace,monospace;display:inline">do even have this file? For REST API/SDK errors?</div></div><span class="m_-5529518473000672390gmail-"><div><div style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">In any case, there should be a unit test that ensures all EngineMessage enum members are reflected as methods in AppErrors interface. This will give us the confidence that backend EngineMessage's have proper strings associated with them.<br></div></div></blockquote></span><div><span style="font-family:monospace,monospace">We've had <div style="font-family:monospace,monospace;display:inline">the opposite test for quite a long time:</div></span><br></div><div><div style="display:inline"><font face="monospace, monospace"><a href="https://github.com/oVirt/ovirt-engine/commits/0c7d7e7101142b95bd78e76be08dbb121c0c90f7/frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java" target="_blank">https://github.com/oVirt/ovirt<wbr>-engine/commits/0c7d7e7101142b<wbr>95bd78e76be08dbb121c0c90f7/<wbr>frontend/webadmin/modules/<wbr>frontend/src/test/java/org/<wbr>ovirt/engine/ui/frontend/<wbr>AppErrorsTest.java</a></font><br></div></div><div><div style="display:inline"><font face="monospace, monospace"><br></font></div></div><div><div style="display:inline"><font face="monospace, monospace">But in indeed did's have a test for missing methods in the AppErrors interface.</font></div></div><div><div style="display:inline"><font face="monospace, monospace">I tried cooking up a simple test and found that we're missing several hundred(!) keys, so I just carpet-bomb added them all, to be sorted out later:</font></div></div><div><div style="display:inline"><font face="monospace"><a href="https://gerrit.ovirt.org/#/c/78354/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>8354/</a></font><br></div></div><div><div style="display:inline"><font face="monospace"><br></font></div></div><div><div style="display:inline"><font face="monospace">However, I'm getting a weird GWT error when I try to build the application:</font></div></div><div><div style="display:inline"><font face="monospace"><div><br></div><div>[ERROR] Errors in 'gen/org/ovirt/engine/ui/front<wbr>end/com_gwtplatform_mvp_client<wbr>_DesktopGinjector_DesktopGinje<wbr>ctorGinjector_fragment.java'</div><div>[INFO] [ERROR] Line 50: Failed to resolve 'org.ovirt.engine.ui.frontend.<wbr>VdsmErrors' via deferred binding</div><div><br></div><div>I'm obviously doing something stupid I shouldn't be doing, but I must admit I don't understand what I'm doing wrong.</div><div>Some advice from our residenant GWT experts (yes Vojtech, I'm pointing at you :-)) woul be appreciated.</div></font></div></div></div></div></div></blockquote><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline"><br></div></div></span><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline">The</div> <div class="gmail_default" style="font-family:monospace,monospace;display:inline">weirest thing is that CI actually passes on this, but I get the aforementioned error locally when I run </div></div><div><div class="gmail_default" style="font-family:monospace,monospace;display:inline"><br></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace">$ mvn clean install -Pgwt-admin -Dgwt.userAgent=safari</font><br></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace"><br></font></div></div><div><div class="gmail_default" style="display:inline"><font face="monospace, monospace">Now I'm sure I'm doing something stupid - just not sure what.</font></div></div><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div style="font-family:monospace,monospace;display:inline"><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-5529518473000672390gmail-"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif"><br></div><div style="font-family:arial,helvetica,sans-serif">Regards,<br></div><div style="font-family:arial,helvetica,sans-serif">Vojtech</div><div><div class="m_-5529518473000672390gmail-m_-6574030350301196743gmail-m_334994800606526553h5"><div style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 8:51 PM, Jakub Niedermertl <span dir="ltr"><<a href="mailto:jniederm@redhat.com" target="_blank">jniederm@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi all,<br><br></div>there is a patch [1] removing `AppErrors.properties` from webadmin project to simplify edits of AppErrors/EngineMessage. AppErrors.properties from webadmin project will be merged to AppErrors.properties in frontend project. This requires some manual resolutions of conflicts of translation values.<br><br>I'd like to kindly ask you to review altered translation values. They are mostly just typos.<br><br></div>Thanks.<br></div>Jakub<br><div><div><br>[1]: <a href="https://gerrit.ovirt.org/#/c/76215/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>6215/</a><br></div></div></div>
</blockquote></div><br></div></div></div></div>
<br></span>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>