<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Thu, Jun 22, 2017 at 3:39 PM Yaniv Lavi (Dary) <<a href="mailto:ylavi@redhat.com">ylavi@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div>You can have a look at the libfgapi patches as the are the first to externalize the snapshot process to separate implementation.</div></div></blockquote><div><br></div><div>Snapshots in libgfapi are not using any external process. The only difference</div><div>is modifying the volume from file path </div><div>(/rhev/data-center/mnt/server:path/sd_id/images/img_id/vol_id) to gluster path</div><div>(volume/sd_id/images/img_id/vol_id).</div><div><br></div><div>This modification is done when we prepare a volume. This is basically a hack</div><div>since gluster connections are not managed properly in engine like other types</div><div>of storage.</div><div><br></div><div>Nir</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div><div><br></div><div>Thanks,</div></div></div><div class="gmail_extra"><br clear="all"><div><div class="m_1275030391243983111gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><pre cols="72"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;white-space:normal;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase">YANIV LAVI (YANIV DARY)</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;white-space:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">SENIOR TECHNICAL PRODUCT MANAGER</p><p style="font-family:overpass,sans-serif;white-space:normal;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat Israel Ltd.</a></p><span style="font-family:overpass,sans-serif;white-space:normal;font-size:10px;margin:0px;color:rgb(153,153,153)"><p style="margin:0px">34 Jerusalem Road, Building A, 1st floor</p></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium;white-space:normal"></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium;white-space:normal"><p style="font-size:10px;margin:0px;color:rgb(153,153,153)">Ra'anana, Israel 4350109</p></span><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium;white-space:normal"></span><p style="font-family:overpass,sans-serif;white-space:normal;margin:0px 0px 6px;font-size:10px"><span style="color:rgb(153,153,153);margin:0px;padding:0px"><a href="mailto:ylavi@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">ylavi@redhat.com</a> </span><font color="#999999"> T: </font><a href="tel:+972-9-7692306" style="color:rgb(0,136,206);margin:0px" target="_blank">+972-9-7692306</a><font color="#999999">/</font><a href="tel:8272306" style="color:rgb(0,136,206);margin:0px" target="_blank">8272306</a><font color="#999999"> F: </font><a href="tel:+972-9-7692223" style="color:rgb(0,136,206);margin:0px" target="_blank">+972-9-7692223</a><font color="#999999"> IM: </font><span style="color:rgb(153,153,153)">ylavi</span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium;white-space:normal"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table><div style="color:rgb(0,0,0);font-family:overpass,sans-serif;white-space:normal;font-size:10px"><div style="color:rgb(153,153,153)"><a href="https://twitter.com/redhatnews" title="twitter" style="background:url("https://www.redhat.com/files/brand/email/sm-twitter.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">@redhatnews</a> <a href="https://www.linkedin.com/company/red-hat" title="LinkedIn" style="background:url("https://www.redhat.com/files/brand/email/sm-linkedin.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">Red Hat</a> <a href="https://www.facebook.com/RedHatInc" title="Facebook" style="background:url("https://www.redhat.com/files/brand/email/sm-facebook.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">Red Hat</a></div></div></pre></div></div></div></div></div></div></div></div><div class="gmail_extra">
<br><div class="gmail_quote">On Wed, Jun 21, 2017 at 11:57 PM, Deepak Jagtap <span dir="ltr"><<a href="mailto:deepak.jagtap@maxta.com" target="_blank">deepak.jagtap@maxta.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div id="m_1275030391243983111m_-3888588332700425219divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Thanks Yaniv!</p>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_1275030391243983111m_-3888588332700425219divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>><br>
<b>Sent:</b> Wednesday, June 21, 2017 1:47:26 PM<br>
<b>To:</b> Deepak Jagtap<br>
<b>Cc:</b> Allon Mureinik; <a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><div><div class="m_1275030391243983111h5"><br>
<b>Subject:</b> Re: [ovirt-devel] Snapshots & clone support from datastore</div></div></font>
<div> </div>
</div><div><div class="m_1275030391243983111h5">
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jun 21, 2017 at 10:28 PM, Deepak Jagtap <span dir="ltr">
<<a href="mailto:deepak.jagtap@maxta.com" target="_blank">deepak.jagtap@maxta.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Hi Allon,</p>
<p><br>
</p>
<p>I am trying to leverage snapshot capability of underlying filesystem.</p>
<p><span style="font-size:12pt">As per my understanding current snapshot </span><span style="font-size:12pt"></span><span style="font-size:12pt">works like this:</span></p>
<p>Base Image(raw)--->snap1(qcow)->snap2(qcow), i.e after each snapshot vm starts writing on newly created qcow image.</p>
<p>So in this case vm is going to do all new writes on snap2(qcow) voulme and will redirect read IOs to snap1 & Base image as required.</p>
<p><br>
</p>
<p>But in my case snapshots created by the filesystem are read only and it's in raw format.</p>
<p>As a result after creating snapshot vm disk configuration won't change after taking snapshot but will continue doing writes on same base image.</p>
<p>So snapshots will look like this:</p>
<p><span style="font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px">Base Image(raw)--->snap1(raw)->snap2(raw)</span><br>
</p>
<p><span style="font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px">Base Image will always remain writable, while the snapshots will remain
read only raw format.</span></p>
<p><br>
</p>
<p>Just wanted to confirm is this configurable so that vm continues referring base image after the snapshot instead of newly created qcow image?</p>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>It is not. It'll need code modification to allow externally taking snapshots of VM disks.</div>
<div>Y.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p><br>
</p>
<p>Thanks & Regards,</p>
<p>Deepak</p>
<p><span style="font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px"><br>
</span></p>
<p><span style="font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:16px"><br>
</span></p>
<p><br>
</p>
<p> </p>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Allon Mureinik <<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>><br>
<b>Sent:</b> Tuesday, June 20, 2017 7:59:03 PM
<div>
<div class="m_1275030391243983111m_-3888588332700425219h5"><br>
<b>To:</b> Deepak Jagtap<br>
<b>Cc:</b> <a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><br>
<b>Subject:</b> Re: [ovirt-devel] Snapshots & clone support from datastore</div>
</div>
</font>
<div> </div>
</div>
<div>
<div class="m_1275030391243983111m_-3888588332700425219h5">
<div>
<div dir="ltr">
<div style="font-family:monospace,monospace">Not sure I understand the question. Could you give an example of what you mean perhpas?</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Jun 20, 2017 at 10:01 PM, Deepak Jagtap <span dir="ltr">
<<a href="mailto:deepak.jagtap@maxta.com" target="_blank">deepak.jagtap@maxta.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810m_5891938740723837127divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Hi Allon,</p>
<p><br>
</p>
<p>After going through current vdsm code base, noticed that after taking a snapshot vm starts referring the newly created qcow image/volume.</p>
<p>For internal snapshots which are not qcow is it configurable somehow so that vm continues doing writes to same base image?</p>
<p><br>
</p>
<p>Thanks & Regards,</p>
<p>Deepak</p>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810m_5891938740723837127divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Deepak Jagtap<br>
<b>Sent:</b> Tuesday, June 6, 2017 3:37:03 PM<br>
<b>To:</b> Allon Mureinik<span><br>
<b>Cc:</b> <a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><br>
<b>Subject:</b> Re: [ovirt-devel] Snapshots & clone support from datastore</span></font>
<div> </div>
</div>
<span>
<div>
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810m_5891938740723837127divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Thanks Allon!</p>
<p><br>
</p>
<p>Best Regards,</p>
<p>Deepak</p>
</div>
<hr style="display:inline-block;width:98%">
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810m_5891938740723837127divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Allon Mureinik <<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>><br>
<b>Sent:</b> Tuesday, June 6, 2017 2:43:17 PM<br>
<b>To:</b> Deepak Jagtap<br>
<b>Cc:</b> <a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a><br>
<b>Subject:</b> Re: [ovirt-devel] Snapshots & clone support from datastore</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div style="font-family:monospace,monospace">Unfortunately, there's no such integration point at the moment.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Jun 6, 2017 at 5:57 AM, Deepak Jagtap <span dir="ltr">
<<a href="mailto:deepak.jagtap@maxta.com" target="_blank">deepak.jagtap@maxta.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div id="m_1275030391243983111m_-3888588332700425219m_-9072135902178749810m_5891938740723837127m_-4873246095173968224divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif" dir="ltr">
<p>Hey Guys,</p>
<p><br>
</p>
<p>I am newbie to ovirt, and wanted to confirm whats the best way to leverage snapshot, clone features </p>
<p>provided by the datastore filesystem.</p>
<p>I have a btrfs datastore exported and wanted use btrfs snapshots for vm snapshot & clones.</p>
<p>Does ovirt offers any hooks/APIs so that image snapshots are created by the filesystem?</p>
<p><br>
</p>
<p>Thanks & Regards,</p>
<p>Deepak</p>
<p> </p>
</div>
</div>
<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</span></div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div></div></div>
<br>_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br></blockquote></div><br></div>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a></blockquote></div></div>