<div dir="auto">We could optimize it for one time use. Is there a BZ to track it?</div><div class="gmail_extra"><br><div class="gmail_quote">29 cze 2017 15:57 "Nir Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> napisał(a):<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Thu, Jun 29, 2017 at 3:54 PM Avihai Efrat <<a href="mailto:aefrat@redhat.com" target="_blank">aefrat@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582HOEnZb"><div class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Guys ,</div><div><br></div><div>In ovirt 4.2 vdsClient is deprecated so using vdsm-client in tests I get timeout failures.</div></div></blockquote></div></div></div></div></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582HOEnZb"><div class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>When I tested both utilities on a 4.1 host I noticed vdsm-client takes X4 than vdsClient .</div><div><br></div><div>Is this known ? </div><div><br></div><div>can we make it faster ? <br></div><div><br></div><div><div><u>Taken from client CLI :</u></div><div>[root@storage-ge3-vdsm1 ~]# time vdsClient -s 0 getVdsHardwareInfo</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemFamily = 'Red Hat Enterprise Linux'</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemManufacturer = 'Red Hat'</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemProductName = 'RHEV Hypervisor'</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemSerialNumber = '4C4C4544-0053-5410-8047-<wbr>B9C04F465931'</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemUUID = '07FD09C7-8461-4981-B859-<wbr>A40C548E10FF'</div><div><span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>systemVersion = '7.2-9.el7_2.1'</div><div><br></div><div><b><font color="#00ff00">real<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m0.382s</font></b></div><div>user<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m0.272s</div><div>sys<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m0.056s</div><div><br></div><div>[root@storage-ge3-vdsm1 ~]# time vdsm-client Host getHardwareInfo</div><div>{</div><div> "systemProductName": "RHEV Hypervisor", </div><div> "systemSerialNumber": "4C4C4544-0053-5410-8047-<wbr>B9C04F465931", </div><div> "systemFamily": "Red Hat Enterprise Linux", </div><div> "systemVersion": "7.2-9.el7_2.1", </div><div> "systemUUID": "07FD09C7-8461-4981-B859-<wbr>A40C548E10FF", </div><div> "systemManufacturer": "Red Hat"</div><div>}</div><div><br></div><div><b><font color="#ff0000">real<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m1.208s</font></b></div><div>user<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m0.966s</div><div>sys<span class="m_-7546619791292881930m_-3868992466490930973m_-5031372945482677582m_2422528945299710549m_-8774728184581521318gmail-Apple-tab-span" style="white-space:pre-wrap"> </span>0m0.111s</div></div><div><br></div></div></blockquote></div></div></div></div></blockquote></div></div></div></blockquote><div><br></div><div>The difference is about 0.7 seconds. This can be explained by the </div><div>time needed to load the yaml schema - we load it for every request,</div><div>for validating the the request and generating online help.</div><div><br></div><div>It takes about 0.1 seconds on a i7-4770 CPU @ 3.40GHz, but maybe you are</div><div>testing on a much slower machine, or your machine is overloaded for some</div><div>other reason?</div><div><br></div><div>This was discussed in </div><div><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1381899#c17" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1381899#c17</a></div><div><br></div><div>We can make this 100 times faster by using pickle format instead of parsing</div><div>yaml.</div><div><br></div><div>We can also make it infinitely faster by loading the schema only when </div><div>generating online help. There is no real need to validate the request</div><div>on the client side when the server side is already doing this.</div><div><br></div><div>Nir</div><div><br></div></div></div>
</blockquote></div></div>