<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 7, 2017 at 1:48 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div bgcolor="#FFFFFF">
<div class="gmail-m_7405781680609277323moz-cite-prefix">Hi Arik, <br>
<br>
seems there is a second issue in the xml with a required device
not sent: <br>
<br>
Here is the xml sent: <br>
<a class="gmail-m_7405781680609277323moz-txt-link-freetext" href="http://pastebin.test.redhat.com/501086" target="_blank">http://pastebin.test.redhat.<wbr>com/501086</a><br>
<br>
This is the error: <br>
<br>
2017-07-07 06:06:36,386-0400 ERROR (vm/300ac8d4) [virt.vm]
(vmId='300ac8d4-2157-46f6-<wbr>bc24-291d3da9a83d') The vm start process
failed (vm:789)<br>
Traceback (most recent call last):<br>
File "/usr/share/vdsm/virt/vm.py", line 723, in
_startUnderlyingVm<br>
self._run()<br>
File "/usr/share/vdsm/virt/vm.py", line 2341, in _run<br>
self._connection.createXML(<wbr>domxml, flags),<br>
File
"/usr/lib/python2.7/site-<wbr>packages/vdsm/<wbr>libvirtconnection.py", line
125, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib/python2.7/site-<wbr>packages/vdsm/utils.py", line 646,
in wrapper<br>
return func(inst, *args, **kwargs)<br>
File "/usr/lib64/python2.7/site-<wbr>packages/libvirt.py", line 3782,
in createXML<br>
if ret is None:raise libvirtError('<wbr>virDomainCreateXML()
failed', conn=self)<br>
libvirtError: Unable to get device ID '(null)': Bad address<br>
<br>
Here is some other useful info on the device teardown which can
help suggest what was the device: <br>
<br>
<a class="gmail-m_7405781680609277323moz-txt-link-freetext" href="http://pastebin.test.redhat.com/501087" target="_blank">http://pastebin.test.redhat.<wbr>com/501087</a><br>
<br>
Here is a grep on the vm id from logs:
<a class="gmail-m_7405781680609277323moz-txt-link-freetext" href="http://pastebin.test.redhat.com/501085" target="_blank">http://pastebin.test.redhat.<wbr>com/501085</a><br>
here is a link to full logs: <br>
<a class="gmail-m_7405781680609277323moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7501/artifact/" target="_blank">http://jenkins.ovirt.org/job/<wbr>test-repo_ovirt_experimental_<wbr>master/7501/artifact/</a><br>
<br>
Can you please have a look? <br></div></div></blockquote><div><br></div><div>Reverted <a href="https://gerrit.ovirt.org/#/c/78955/">https://gerrit.ovirt.org/#/c/78955/</a> for now.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div bgcolor="#FFFFFF"><div class="gmail-m_7405781680609277323moz-cite-prefix">
<br>
Thanks, <br>
Dafna<br>
<br>
<br>
<br>
<br>
On 07/07/2017 10:03 AM, Dafna Ron wrote:<br>
</div>
<blockquote type="cite">
<div class="gmail-m_7405781680609277323moz-cite-prefix">Thank you :) <br>
I will keep an eye on the tests <br>
<br>
<br>
On 07/07/2017 09:43 AM, Arik Hadas wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">בתאריך 6 ביולי 2017 11:13 PM,
"Arik Hadas" <<a href="mailto:ahadas@redhat.com" target="_blank">ahadas@redhat.com</a>> כתב:<br type="attribution">
<blockquote class="gmail-m_7405781680609277323quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<div class="gmail-m_7405781680609277323quoted-text">On Thu, Jul 6, 2017 at
8:40 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div bgcolor="#FFFFFF">
<p><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"> </b></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Hi,
</span></b></p>
<b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal">
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
</b><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal">
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr">vm failed to run with libvrt
unsupported configuration <span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">(see error below) since the patch is related to 4.2 xml configuration and the vm failed to run on unsupported configuration I suspect its related - can you please have a closer look? </span></p>
</b></div>
</blockquote>
<div><br>
</div>
</div>
<div>Right, good analysis.</div>
<div>Will be easy to fix, just need to copy one
of VDSM little hacks in:</div>
<div><a href="https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/vmdevices/graphics.py#L87" target="_blank">https://github.com/oVirt/vdsm/<wbr>blob/master/lib/vdsm/virt/vmde<wbr>vices/graphics.py#L87</a></div>
<div>To:</div>
<div><a href="https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java#L1152" target="_blank">https://github.com/oVirt/ovirt<wbr>-engine/blob/master/backend/<wbr>manager/modules/vdsbroker/src/<wbr>main/java/org/ovirt/engine/<wbr>core/vdsbroker/builder/vminfo/<wbr>LibvirtVmXmlBuilder.java#L1152</a></div>
<div>I'll do that tomorrow.</div>
<div>Not sure why "ci please build" tests passed
on that one though.</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Fix is posted:</div>
<div dir="auto"><a href="https://gerrit.ovirt.org/#/c/79125" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>79125</a><br>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail-m_7405781680609277323quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div class="gmail-m_7405781680609277323elided-text">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div bgcolor="#FFFFFF"><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"> </b><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal">
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
</b><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal">
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">here is a grep from logs on vm id: <a class="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://pastebin.test.redhat.com/500889" target="_blank">http://pastebin.test.redhat.co<wbr>m/500889</a>
</span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Test failed:<b> </b></span><span style="color:rgb(51,51,51);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:Helvetica,Arial,sans-serif;font-size:14px;font-style:normal;font-weight:bold;word-spacing:0px;display:inline;white-space:normal;float:none">004_basic_sanity.vm_run</span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to suspected patches: <a class="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324moz-txt-link-freetext" href="https://gerrit.ovirt.org/#/c/78955/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>8955/</a></span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to Job: <a class="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7491/" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/7491/</a></span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to all logs: <a class="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7491/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-004_basic_sanity.py/" target="_blank">http://jenkins.ovirt.org/job/t<wbr>est-repo_ovirt_experimental_ma<wbr>ster/7491/artifact/exported-ar<wbr>tifacts/basic-suit-master-el7/<wbr>test_logs/basic-suite-master/p<wbr>ost-004_basic_sanity.py/</a></span></p>
<br>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Error snippet from the log: </span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent"><error></span></p>
</b>
<p><i><b><span style="font-weight:normal">engine
log: </span></b></i><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"><b><br>
</b></b></p>
<p><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal">2017-07-06
11:26:34,473-04 INFO
[org.ovirt.engine.core.bll.Run<wbr>VmOnceCommand]
(default task-31)
[a7b073ec-04ba-434a-95b4-39595<wbr>7cae6dc]
Lock freed to object
'EngineLock:{exclusiveLocks='[<wbr>d3b1b67d-d2fd-4ed7-86d1-795ba2<wbr>f10bc0=VM]',
sharedLocks=''}'<br>
{"params":
{"d3b1b67d-d2fd-4ed7-86d1-795b<wbr>a2f10bc0":
{"status": "Down", "timeOffset": "0",
"exitReason": 1, "exitMessage":
"unsupported configuration: unknown
spice channel name smain", "exitCode":
1}, "notify_time": 4295594320},
"jsonrpc": "2.0", "method":
"|virt|VM_status|d3b1b67d-d2fd<wbr>-4ed7-86d1-795ba2f10bc0"}^@<br>
<br>
</b></p>
<p><span style="font-weight:normal">vdsm
log: </span><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"><b><br>
</b></b></p>
<p><span style="font-weight:normal">2017-07-06
11:26:36,866-0400 ERROR (vm/d3b1b67d)
[virt.vm]
(vmId='d3b1b67d-d2fd-4ed7-86d1<wbr>-795ba2f10bc0')
The vm start process failed (vm:789)<br>
Traceback (most recent call last):<br>
File "/usr/share/vdsm/virt/vm.py",
line 723, in _startUnderlyingVm<br>
self._run()<br>
File "/usr/share/vdsm/virt/vm.py",
line 2328, in _run<br>
self._connection.createXML(dom<wbr>xml,
flags),<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/libvirtconnection.py"<wbr>,
line 125, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib/python2.7/site-packa<wbr>ges/vdsm/utils.py",
line 646, in wrapper<br>
return func(inst, *args, **kwargs)<br>
File "/usr/lib64/python2.7/site-pac<wbr>kages/libvirt.py",
line 3782, in createXML<br>
if ret is None:raise
libvirtError('virDomainCreateX<wbr>ML()
failed', conn=self)<br>
libvirtError: unsupported
configuration: unknown spice channel
name smain<b><br>
</b></span><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"><b><br>
</b><br>
</b></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt" dir="ltr"><b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent"></error></span></b></p>
<b id="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a" style="font-weight:normal"> </b><br class="gmail-m_7405781680609277323m_6643759665648779864gmail-m_-3012446297553863324Apple-interchange-newline">
</div>
</blockquote>
</div>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<br>
<fieldset class="gmail-m_7405781680609277323mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
Infra mailing list
<a class="gmail-m_7405781680609277323moz-txt-link-abbreviated" href="mailto:Infra@ovirt.org" target="_blank">Infra@ovirt.org</a>
<a class="gmail-m_7405781680609277323moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/infra" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a>
</pre>
</blockquote>
<p><br>
</p>
</div>
</blockquote></div><br></div></div>