<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Please make sure to add me as reviewer, the little hacks you
mention may be out of date and there could be simpler and safer
ways to fix this issue.</p>
<p><br>
</p>
<p>Bests,<br>
</p>
<br>
<div class="moz-cite-prefix">On 07/06/2017 10:13 PM, Arik Hadas
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAMCgCFEYjz5O1MQvvpa9ZavtPM6mDdrgQFByy18yoa+Ga30ohw@mail.gmail.com">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Jul 6, 2017 at 8:40 PM, Dafna
Ron <span dir="ltr"><<a href="mailto:dron@redhat.com"
target="_blank" moz-do-not-send="true">dron@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div bgcolor="#FFFFFF">
<p><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"> </b></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Hi,
</span></b></p>
<b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal">
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
</b><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal">
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr">vm failed to run with libvrt unsupported
configuration <span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">(see error below) since the patch is related to 4.2 xml configuration and the vm failed to run on unsupported configuration I suspect its related - can you please have a closer look? </span></p>
</b></div>
</blockquote>
<div><br>
</div>
<div>Right, good analysis.</div>
<div>Will be easy to fix, just need to copy one of VDSM
little hacks in:</div>
<div><a
href="https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/vmdevices/graphics.py#L87"
moz-do-not-send="true">https://github.com/oVirt/vdsm/blob/master/lib/vdsm/virt/vmdevices/graphics.py#L87</a></div>
<div>To:</div>
<div><a
href="https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java#L1152"
moz-do-not-send="true">https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java#L1152</a></div>
<div>I'll do that tomorrow.</div>
<div>Not sure why "ci please build" tests passed on that one
though.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid">
<div bgcolor="#FFFFFF"><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"> </b><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal">
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
</b><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal">
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">here is a grep from logs on vm id: <a class="gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://pastebin.test.redhat.com/500889" target="_blank" moz-do-not-send="true">http://pastebin.test.redhat.<wbr>com/500889</a>
</span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">
</span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Test failed:<b> </b></span><span
style="color:rgb(51,51,51);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:Helvetica,Arial,sans-serif;font-size:14px;font-style:normal;font-weight:bold;word-spacing:0px;display:inline;white-space:normal;float:none">004_basic_sanity.vm_run</span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to suspected patches: <a class="gmail-m_-3012446297553863324moz-txt-link-freetext" href="https://gerrit.ovirt.org/#/c/78955/" target="_blank" moz-do-not-send="true">https://gerrit.ovirt.org/#/c/<wbr>78955/</a></span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to Job: <a class="gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7491/" target="_blank" moz-do-not-send="true">http://jenkins.ovirt.org/job/<wbr>test-repo_ovirt_experimental_<wbr>master/7491/</a></span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Link to all logs: <a class="gmail-m_-3012446297553863324moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/7491/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-004_basic_sanity.py/" target="_blank" moz-do-not-send="true">http://jenkins.ovirt.org/job/<wbr>test-repo_ovirt_experimental_<wbr>master/7491/artifact/exported-<wbr>artifacts/basic-suit-master-<wbr>el7/test_logs/basic-suite-<wbr>master/post-004_basic_sanity.<wbr>py/</a></span></p>
<br>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Error snippet from the log: </span></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent"><error></span></p>
</b>
<p><i><b><span style="font-weight:normal">engine log: </span></b></i><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"><b><br>
</b></b></p>
<p><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal">2017-07-06
11:26:34,473-04 INFO [org.ovirt.engine.core.bll.<wbr>RunVmOnceCommand]
(default task-31) [a7b073ec-04ba-434a-95b4-<wbr>395957cae6dc]
Lock freed to object 'EngineLock:{exclusiveLocks='[<wbr>d3b1b67d-d2fd-4ed7-86d1-<wbr>795ba2f10bc0=VM]',
sharedLocks=''}'<br>
{"params": {"d3b1b67d-d2fd-4ed7-86d1-<wbr>795ba2f10bc0":
{"status": "Down", "timeOffset": "0", "exitReason":
1, "exitMessage": "unsupported configuration:
unknown spice channel name smain", "exitCode": 1},
"notify_time": 4295594320}, "jsonrpc": "2.0",
"method": "|virt|VM_status|d3b1b67d-<wbr>d2fd-4ed7-86d1-795ba2f10bc0"}^<wbr>@<br>
<br>
</b></p>
<p><span style="font-weight:normal">vdsm log: </span><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"><b><br>
</b></b></p>
<p><span style="font-weight:normal">2017-07-06
11:26:36,866-0400 ERROR (vm/d3b1b67d) [virt.vm]
(vmId='d3b1b67d-d2fd-4ed7-<wbr>86d1-795ba2f10bc0')
The vm start process failed (vm:789)<br>
Traceback (most recent call last):<br>
File "/usr/share/vdsm/virt/vm.py", line 723, in
_startUnderlyingVm<br>
self._run()<br>
File "/usr/share/vdsm/virt/vm.py", line 2328, in
_run<br>
self._connection.createXML(<wbr>domxml, flags),<br>
File "/usr/lib/python2.7/site-<wbr>packages/vdsm/<wbr>libvirtconnection.py",
line 125, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib/python2.7/site-<wbr>packages/vdsm/utils.py",
line 646, in wrapper<br>
return func(inst, *args, **kwargs)<br>
File "/usr/lib64/python2.7/site-<wbr>packages/libvirt.py",
line 3782, in createXML<br>
if ret is None:raise libvirtError('<wbr>virDomainCreateXML()
failed', conn=self)<br>
libvirtError: unsupported configuration: unknown
spice channel name smain<b><br>
</b></span><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"><b><br>
</b><br>
</b></p>
<p
style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"
dir="ltr"><b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"><span style="color:rgb(0,0,0);font-family:Arial;font-size:11pt;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;background-color:transparent"></error></span></b></p>
<b
id="gmail-m_-3012446297553863324docs-internal-guid-e0ead7e4-18ea-282b-e1b6-8be42d98a81a"
style="font-weight:normal"> </b><br
class="gmail-m_-3012446297553863324Apple-interchange-newline">
</div>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Devel@ovirt.org">Devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/devel">http://lists.ovirt.org/mailman/listinfo/devel</a></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Francesco Romani
Senior SW Eng., Virtualization R&D
Red Hat
IRC: fromani github: @fromanirh</pre>
</body>
</html>