<div dir="ltr">Sorry for the trouble. I put clearly in the commit message:<div><br></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre">This patch deletes 'frontend/webadmin/modules/userportal-gwtp'
and won't pass CI on its own. Patch 3/3 will pass.</span><br></div><div><br></div><div>I think it's reasonable that not every single patch will pass CI. Sometimes patches are so large that they need to be split. And usually we can split things such that each patch compiles, but in this case it didn't make sense to me.</div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 19, 2017 at 6:58 AM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><span class="gmail-"><br><div class="gmail_quote">On 19 July 2017 at 13:49, Oved Ourfali <span dir="ltr"><<a href="mailto:oourfali@redhat.com" target="_blank">oourfali@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">If that's the case, we should make sure in the future that patches are self contained, even if the plan is to push them together.</div><div class="gmail-m_-8155901000548646168HOEnZb"><div class="gmail-m_-8155901000548646168h5"><div class="gmail_extra"><br></div></div></div></blockquote><div> </div></div></span>That is axiomatically true if you want any useful CI...<br><br></div><div class="gmail_extra">Maybe some tests should be added to check-patch to ascertain that...<span class="gmail-HOEnZb"><font color="#888888"><br clear="all"></font></span></div><span class="gmail-HOEnZb"><font color="#888888"><div class="gmail_extra"><br>-- <br><div class="gmail-m_-8155901000548646168gmail_signature">Barak Korren<br>RHV DevOps team , RHCE, RHCi<br>Red Hat EMEA<br><a href="http://redhat.com" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" target="_blank">redhat.com/trusted</a></div>
</div></font></span></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Greg Sheremeta, MBA<br><span style="font-size:12.8px">Sr. Software Engineer</span><br></div><div>Red Hat, Inc.<br><a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a><br></div></div></div></div></div>
</div></div></div>