<div dir="ltr"><div><div><div>The patch works as promised.<br></div>The issue is now gone.<br><br></div>Thanks,<br></div>Petr<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 1, 2017 at 9:12 AM, Petr Kotas <span dir="ltr"><<a href="mailto:pkotas@redhat.com" target="_blank">pkotas@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Thanks Nir,<br><br></div>I am working on it right now, will post result.<span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">Petr<br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 31, 2017 at 7:35 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Pter, should be fixed by <a href="https://gerrit.ovirt.org/80027" target="_blank">https://gerrit.ovirt.org/80<wbr>027</a><div><br></div><div>Can you test and report if it works for you?</div></div><div class="m_672417387153528848HOEnZb"><div class="m_672417387153528848h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, Jul 31, 2017 at 8:24 PM Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Jul 31, 2017 at 8:09 PM Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Jul 31, 2017 at 5:52 PM Petr Kotas <<a href="mailto:pkotas@redhat.com" target="_blank">pkotas@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div>Hi,<br><br></div>I have encountered an issue with VDSM master when running tests.<br></div>Maybe I am doing something wrong, or I am overlooking something.<br><br></div><div>This is a clear master without any modification pulled with the latest commits.<br></div>Did anyone please encountered the same issue:<br><br>==============================<wbr>==================== FAILURES ==============================<wbr>====================<br>______________________________<wbr>________ TestDirectioChecker.test_path_<wbr>ok ______________________________<wbr>________<br><br>self = <storage.check_test.TestDirect<wbr>ioChecker testMethod=test_path_ok><br><br> def test_path_ok(self):<br> self.checks = 1<br> with temporaryPath(data=b"blah") as path:<br> checker = check.DirectioChecker(self.loo<wbr>p, path, self.complete)<br> checker.start()<br> self.loop.run_forever()<br> pprint.pprint(self.results)<br> result = self.results[0]<br>> delay = result.delay()<br><br>storage/check_test.py:82: <br>_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ <br><br>self = <CheckResult path=/var/tmp/tmpPpV1Rj rc=0 err=bytearray(b'0+1 records in\n0+1 ... copied, 0,000496228 s, 8,1 kB/s\n') time=4299448.73 elapsed=0.00 at 0x3b72390><br><br> def delay(self):<br> # TODO: Raising MiscFileReadException for all errors to keep the old<br> # behavior. Should probably use StorageDomainAccessError.<br> if self.rc != 0:<br> raise exception.MiscFileReadExceptio<wbr>n(self.path, self.rc, self.err)<br> if not self.err:<br> raise exception.MiscFileReadExceptio<wbr>n(self.path, "no stats")<br> stats = self.err.splitlines()[-1]<br> match = self._PATTERN.match(stats)<br> if not match:<br> raise exception.MiscFileReadExceptio<wbr>n(self.path,<br>> <wbr> "no match: %r" % stats)<br>E MiscFileReadException: Internal file read failure: ('/var/tmp/tmpPpV1Rj', "no match: bytearray(b'4 bytes (4 B) copied, 0,000496228 s, 8,1 kB/s')")<br><br>../lib/vdsm/storage/check.py:3<wbr>72: MiscFileReadException<br>------------------------------<wbr>-------------- Captured stdout call ------------------------------<wbr>--------------<br>[<CheckResult path=/var/tmp/tmpPpV1Rj rc=0 err=bytearray(b'0+1 records in\n0+1 records out\n4 bytes (4 B) copied, 0,000496228 s, 8,1 kB/s\n') time=4299448.73 elapsed=0.00 at 0x3b72390>]<br></div></div></div></blockquote></div></div></blockquote><div><br></div></div></div><div dir="ltr"><div class="gmail_quote"><div>This is the issue - your dd uses "," as decimal point: 0,000496228</div><div>We expect: 0.000496228</div><div><br></div><div>Can you share the output of "locale"? on the machine?</div><div><br></div><div>Here I get:</div><div><br></div><div><div>$ locale</div><div>LANG=en_US.UTF-8</div><div>LC_CTYPE="en_US.UTF-8"</div><div>LC_NUMERIC="en_US.UTF-8"</div><div>LC_TIME="en_US.UTF-8"</div><div>LC_COLLATE="en_US.UTF-8"</div><div>LC_MONETARY="en_US.UTF-8"</div><div>LC_MESSAGES="en_US.UTF-8"</div><div>LC_PAPER="en_US.UTF-8"</div><div>LC_NAME="en_US.UTF-8"</div><div>LC_ADDRESS="en_US.UTF-8"</div><div>LC_TELEPHONE="en_US.UTF-8"</div><div>LC_MEASUREMENT="en_US.UTF-8"</div><div>LC_IDENTIFICATION="en_US.UTF-8<wbr>"</div><div>LC_ALL=</div></div><div><br></div><div>Maybe we don't configure the test environment properly?<br></div><div><br></div><div>Dan, do you have any insite on this?</div></div></div><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Nir</div></div></div></blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>