<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 31, 2017 at 11:09 AM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 31 August 2017 at 11:54, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
> So with ovirt-ansible-roles-1.1.0 (which is the last offically relased<br>
> version) everything runs fine and host is added properly (tested several<br>
> times on CentOS 7.3)<br>
><br>
> But we need to fix executing builds from github otherwise we cannot continue<br>
> working with ovirt-ansible-roles in github:<br>
><br>
> 1. If you add comment 'ci build please' to github PR, then build will be<br>
> executed and the result will be a repo with RPM to be used in OST (but this<br>
> build will not be passed to queue to be added to tested repo)<br>
><br>
> 2. When PR is merged, then either automatically or by some other<br>
> comment/action (available to maintainers only) build will be executed and if<br>
> build is OK, it can be queued to be added to tested repo<br>
><br>
> Without above we just cannot continue working on ovirt-ansible-roles on<br>
> github.<br>
<br>
We are working on that, but given that GitHub triggering work's quite<br>
differently then Gerrit's, we need to rewrite some significant chunks<br>
of code.<br>
<br>
Tracker ticket is [1] or more specifically [2], [3] and [4]. We've<br>
some pending patches for this, but we've not finished implementing all<br>
required functionality yet.<br>
<br>
[1]: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-1548" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-1548</a><br>
[2]: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-1547" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-1547</a><br>
[3]: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-1522" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-1522</a><br>
[4]: <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-1486" rel="noreferrer" target="_blank">https://ovirt-jira.atlassian.<wbr>net/browse/OVIRT-1486</a><br>
<br>
As a temporary measure, we can disable the automated deployment from<br>
jobs that run on PR messages. But this means that we will need to do<br>
the deployment manually when needed.<br></blockquote><div><br><div style="font-family:arial,helvetica,sans-serif;display:inline" class="gmail_default">Seems like good idea, as we really need to add to tested queue only merged PRs. How exactly will we be able to perform that manually?<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Barak Korren<br>
RHV DevOps team , RHCE, RHCi<br>
Red Hat EMEA<br>
<a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" rel="noreferrer" target="_blank">redhat.com/trusted</a><br>
</font></span></blockquote></div><br></div></div>