<div dir="auto"><br><div class="gmail_extra" dir="auto"><br><div class="gmail_quote">בתאריך 8 בספט׳ 2017 14:18, "Martin Sivak" <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> כתב:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I recently noticed GitHub enabled a feature that allows specifying<br>
code owners for different pieces of code:<br>
<br>
<a href="https://github.com/blog/2392-introducing-code-owners" rel="noreferrer" target="_blank">https://github.com/blog/2392-<wbr>introducing-code-owners</a><br>
<br>
It should supposedly automatically</blockquote></div></div><div class="gmail_extra" dir="auto"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">add the proper reviewers to patches.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Not sure what are they using to identify people, are these GitHub usernames? This feels a bit like lock-in.</div><div dir="auto"><br></div><div dir="auto">It might be better to enforce using email addresse in the file.</div><div dir="auto"><br></div><div dir="auto">Is actually prefer if there was a way to keep this out of the code, or if they'd adopted Kubernetses format for this instead of inventing thier own.</div><div dir="auto"><br></div><div class="gmail_extra" dir="auto"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br></blockquote><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We have similar feature enabled in Gerrit and it might make sense for<br>
our GitHub specific projects to do the same.</blockquote></div></div><div dir="auto"><br></div><div dir="auto">Sure, why not. Its been very useful in Gerrit.</div><div dir="auto"><br></div><div class="gmail_extra" dir="auto"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> (It might even make sense<br>
to follow the same format in Gerrit)<font color="#888888"><br>
</font></blockquote></div><br></div><div class="gmail_extra" dir="auto">If soneone would contribute a parser to the GitHub format (which is to say, something that would scan a commit and yield a list of addresses). We could make it work with a hook or a Jenkins job.</div></div>