<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Sep 18, 2017 at 3:42 PM, Roy Golan <span dir="ltr"><<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_quote"><span><div dir="ltr">On Mon, 18 Sep 2017 at 22:30 Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:12.8px">Here[1]:</div><div style="font-size:12.8px">"Anyone can send a patch</div></div></blockquote></span></div></div></blockquote><div><br></div><div>That's no longer true. We have a whitelist. [2][3]</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:12.8px">Initially a patch should be sent as draft"</div></div></blockquote></span></div></div></blockquote><div><br></div><div>I think we should edit that to be more along the lines of "consider initially posting as a draft" with guidelines to assist the decision.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:12.8px"><span style="font-size:12.8px">A draft is hidden from the public, why is it better to send as such?</span><br></div></div></blockquote></span></div></div></blockquote><div><br></div><div>I've sent draft patches for 2 reasons. </div><div>1. I made progress on something and want to preserve it, but it's so WIP that I wouldn't want anyone to see it. That might be because it could confuse people, or it might be that the code is a prototype and/or so terrible that I'd be embarrassed if anyone saw it :D Lately I'm more likely to 'git format-patch | gdrive upload -' if it's something in this category.</div><div>2. I don't want to waste CI resources on something. Sometimes related to 1.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div>I see few advantages and they all drawn from the assumption the initial patchset is always some sort of work in progress in really most of the cases:<br></div></span><div>1. It doesn't invoke automation and waste resources. First the developer should run it and be passed the checkstyle/pep/other errors locally. <br></div><div>2. Default reviewers feature hopefully will put the reviewers in place automatically so it not hidden.<br></div></div></div></blockquote><div><br></div><div>Hmm, I believe the "hopefully" doesn't work. A few weeks ago I got a notification that I had a draft to look at [because I was a default reviewer], but when I followed the link, I received a "not found" error.</div><div><br></div><div>Best wishes,</div><div>Greg</div><div><br></div><div>[2] <a href="http://lists.ovirt.org/pipermail/devel/2017-February/029633.html">http://lists.ovirt.org/pipermail/devel/2017-February/029633.html</a></div><div>[3] <a href="https://ovirt-jira.atlassian.net/browse/OVIRT-1154">https://ovirt-jira.atlassian.net/browse/OVIRT-1154</a></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div>3. After the patch is bit more mature it is worth publishing to get more reviews. Half baked or controversial patches may be costly to review. After they are published the reviewer can expect higher quality and can estimate better the effort in review <br></div><div><br></div><div>IMHO we don't use this practice enough.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span><div dir="ltr"><div style="font-size:12.8px">TIA,</div><div style="font-size:12.8px">Y.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">[1] <a href="https://www.ovirt.org/develop/dev-process/working-with-gerrit/" target="_blank">https://www.ovirt.org/deve<wbr>lop/dev-process/working-with-<wbr>gerrit/</a></div></div></span>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></blockquote><div><br></div><div> </div></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br><div class="gmail-m_-3300764368784937405gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div>
</div></div>