<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Sep 20, 2017 at 11:04 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><br><div><blockquote type="cite"><div><div class="gmail-m_3702395294545443653gmail-h5"><div>On 20 Sep 2017, at 16:12, Viktor Mihajlovski <<a href="mailto:mihajlov@linux.vnet.ibm.com" target="_blank">mihajlov@linux.vnet.ibm.com</a>> wrote:</div><br class="gmail-m_3702395294545443653gmail-m_-5782326287049923669Apple-interchange-newline"></div></div><div><div><div class="gmail-m_3702395294545443653gmail-h5"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">On 20.09.2017 15:40, Michal Skrivanek wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br><blockquote type="cite">On 19 Sep 2017, at 14:08, Viktor Mihajlovski <<a href="mailto:mihajlov@linux.vnet.ibm.com" target="_blank">mihajlov@linux.vnet.ibm.com</a>> wrote:<br><br>On 18.09.2017 17:52, Juan Hernández wrote:<br><blockquote type="cite">On 09/18/2017 05:31 PM, Viktor Mihajlovski wrote:<br><blockquote type="cite">Hi,<br><br>I have submitted a topic branch containing the changes necessary to<br>enable support for the s390 arch in VDSM and would appreciate your<br>feedback, not only for the code, but also on the procedure:<br><br>1. I've submitted the patches as draft, following the suggestions on the<br>homepage. Not sure whether this is really required.<br><br>2. The individual commits are actually tiny, let me know whether this is<br>OK, or you prefer a single commit.<br><br>3. Topic branch here: <a href="https://gerrit.ovirt.org/#/q/topic:s390-base" target="_blank">https://gerrit.ovirt.org/#/q/t<wbr>opic:s390-base</a><br><br></blockquote><br>Note that draft changes are generally OK, but they have the inconvenient<br>that they are invisible for people that isn't explicitly added as<br>reviewers. So you will need to either promote them to regular patches,<br>maybe adding a [WIP] prefix to the subject, or else explicitly add<br>reviewers, otherwise nobody will see them.<br><br></blockquote>Thanks for the clarification, I have done as you suggested. Looking<br>forward for comments.<br></blockquote><br>Hi Viktor,<br>thank you for the contribution! It looks good so far, some of the patches are already in a good shape, feel free to remove the WIP prefix.<br>Size of the patches is also quite matching the typical scope of each patch, at least for vdsm.<br><br>Do you intend to work on ovirt-engine component as well? If yes then it would be great if you share the areas which you expect will need to change, or perhaps some other higher level overview of what kind of changes in general are required in oVirt to have a complete s390 support<br></blockquote><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">Hi Michal,</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">thanks for the feedback. I'll have to clean up the vdsm/libvirt stuff</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">first. There's still an issue with NUMA on s390 I have to solve…</span></div></blockquote><div><br></div>sure, it’s the one to start with. Are other system dependencies (qemu, libvirt, other)?<span class="gmail-m_3702395294545443653gmail-"><br><blockquote type="cite"><div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">Once I'm done with vdsm, I'll provide patches for ovirt-engine. As a</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></blockquote><div><br></div></span>that’s great!</div><div><span class="gmail-m_3702395294545443653gmail-"><br><blockquote type="cite"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">prerequisite for that I need to update ovirt-engine-api-model (new</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">architecture and a new watchdog device type).</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></blockquote><div><br></div></span>regarding watchdog…we have an overdue plan/intent to use pvpanic instead of watchdog devices. They are not widely used anyway. So I wonder if there are plans to support pvpanic on s390 at the qemu/libvirt level and (separately) whether a watchdog is an important item for s390 users</div><div><span class="gmail-m_3702395294545443653gmail-"><br><blockquote type="cite"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">Most of the changes have to do with the s390 cpu type handling, nothing</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">really fancy.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">Maybe a side discussion: I use ovirt-host-deploy to turn a Fedora</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">installation into a hypervisor. This worked (with minor changes) well</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">for Fedora 25, but fails for Fedora 26. This is because F26 uses DNF</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">version 3 whereas the otopi/python dnf plugin refuses to work with DNF</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">!= 1. Has anyone been hit by that before, and if so, any plans to fix that?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></blockquote><div><br></div></span>yeah, unfortunately we are a bit behind on moving to new dnf and due to qemu and libvirt features we are forced to move out of F25 to F26….which is not ideal - F25 is no longer enough to run, but you can’t really deploy ovirt on F26. A fix is not expected to happen for some time and I’m afraid for the timebeing you’d need to work around that manually, perhaps deploying on F25 and then upgrading to F26 would work. </div><div>We’re mostly focusing on EL platform, it may also make sense to work on top of EL 7.4 with custom QEMU/libvirt (I’m assuming you do need some bleeding edge changes there)</div></div></blockquote><div><br></div><div>Are you sure about "DNF version 3"? "bin/dnf-3" is "dnf using python3".<br><br></div><div>For dnf-2 support, we have:<br><br><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1455452" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1455452</a><br><br></div><div>Currently targetted to oVirt 4.3.<br><br></div><div>See also:<br><br><a href="http://lists.ovirt.org/pipermail/devel/2017-August/030990.html">http://lists.ovirt.org/pipermail/devel/2017-August/030990.html</a><br><br></div><div>Bottom line: If you *know what you are doing*, and want to play<br></div><div>with fedora, that's fine. Otherwise, you should consider it broken<br></div><div>and use EL7.<br><br></div><div>I have no idea what we are going to do in 4.2, but IMO we should not<br></div><div>publish at all RPMs for fedora, in the stable repos. People that<br></div><div>know what they are doing can use the nightly snapshots.<br><br></div><div>Best,<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br></div><div>Thanks,</div><div>michal</div><span class="gmail-m_3702395294545443653gmail-"><div><br><blockquote type="cite"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">[...]</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">--<span class="gmail-m_3702395294545443653gmail-m_-5782326287049923669Apple-converted-space"> </span></span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline">Mit freundlichen Grüßen/Kind Regards</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline"> Viktor Mihajlovski</span></div></blockquote></div><br></span></div><br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail-m_3702395294545443653gmail_signature">Didi<br></div>
</div></div>