<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 24, 2017 at 4:52 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sun, Sep 24, 2017 at 4:48 PM, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>So I've found linkchecker[1], which is quite a powerful and useful tool for that, and run it on oVirt.org, the results are not good, unfortunately.</div><div>We have over 15K(!) of broken links to fix before we can even consider adding a constant CI job to check new commits. </div><div><br></div><div>Snippet example from the huge report attached to this email [2]. ( btw there are other formats available to generate this report if we want )</div></div></blockquote><div><br></div></span><div>resending with zipped report ( the file was 16MB, too big for the list ).<br></div></div></div></div></blockquote><div><br></div><div>I've rerun the tool excluding .png images, since there are many of them and the broken links got down to 2373, to much more reasonable number </div><div>to start working on.</div><div><br></div><div>Attached new report w/o images.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>After we'll do an initial cleanup of the broken links ( similar to what we did on findbugs errors ), we can consider adding CI for it, 2 ideas I had in mind:</div><div><br></div><div><br></div><div>1. Running the tool on GitHub PR using Travis CI ( which ovirt-site is already connected to it ), the tool seems to be using it as well for testing itself</div><div>2. Adding ovirt-site as a std-ci project and using it to also properly deploy to the site in the end ( more complex and long term goal, which might require more work ).</div><div><br></div><div><br></div><div>TL;DR, let's schedule a doc-fix day first to address the sheer amount of broken links and then worry about adding CI.</div><div><br></div><div><br></div><div><br></div><div>[1] <a href="https://github.com/wummel/linkchecker" target="_blank">https://github.com/wummel/<wbr>linkchecker</a></div><div>[2] </div><div><br><table>
<tbody><tr>
<td class="m_-878050786124512270gmail-m_1897013713931047008gmail-url">URL</td>
<td class="m_-878050786124512270gmail-m_1897013713931047008gmail-url">`develop/release-management/fe<wbr>atures/sla/hosted-engine-agent<wbr>-offloading/#documentation'</td></tr>
<tr><td>Name</td><td>`Documentation/External references'</td></tr>
<tr><td>Parent URL</td><td><a href="https://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/" target="_blank">https://ovirt.org/develop/rele<wbr>ase-management/features/sla/<wbr>hosted-engine-agent-offloading<wbr>/</a>, line 1870, col 131 (<a href="http://validator.w3.org/check?ss=1&uri=https://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/" target="_blank">HTML</a>) (<a href="http://jigsaw.w3.org/css-validator/validator?uri=https://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/&warning=1&profile=css2&usermedium=all" target="_blank">CSS</a>)</td></tr>
<tr><td>Real URL</td><td><a href="https://ovirt.org/develop/release-management/features/sla/hosted-engine-agent-offloading/develop/release-management/features/sla/hosted-engine-agent-offloading/#documentation" target="_blank">https://ovirt.org/develop/rele<wbr>ase-management/features/sla/<wbr>hosted-engine-agent-offloading<wbr>/develop/release-management/<wbr>features/sla/hosted-engine-<wbr>agent-offloading/#<wbr>documentation</a></td></tr>
<tr><td>Size</td><td>14.63KB</td></tr>
<tr><td>Check time</td><td>3.496 seconds</td></tr>
<tr><td class="m_-878050786124512270gmail-m_1897013713931047008error">Result</td><td class="m_-878050786124512270gmail-m_1897013713931047008error">Error: 404 Not Found</td></tr></tbody></table></div><div><br><br><table>
<tbody><tr>
<td class="m_-878050786124512270gmail-m_1897013713931047008gmail-url">URL</td>
<td class="m_-878050786124512270gmail-m_1897013713931047008gmail-url">`/images/apple-touch-icon-prec<wbr>omposed.png'</td></tr>
<tr><td>Parent URL</td><td><a href="https://www.ovirt.org" target="_blank">https://www.ovirt.org</a>, line 22, col 1 (<a href="http://validator.w3.org/check?ss=1&uri=https://www.ovirt.org" target="_blank">HTML</a>) (<a href="http://jigsaw.w3.org/css-validator/validator?uri=https://www.ovirt.org&warning=1&profile=css2&usermedium=all" target="_blank">CSS</a>)</td></tr>
<tr><td>Real URL</td><td><a href="https://www.ovirt.org/images/apple-touch-icon-precomposed.png" target="_blank">https://www.ovirt.org/images/a<wbr>pple-touch-icon-precomposed.pn<wbr>g</a></td></tr>
<tr><td>Size</td><td>14.63KB</td></tr>
<tr><td>Check time</td><td>1.851 seconds</td></tr>
<tr><td class="m_-878050786124512270gmail-m_1897013713931047008error">Result</td><td class="m_-878050786124512270gmail-m_1897013713931047008error">Error: 404 Not Found</td></tr>
</tbody></table></div></div><div class="gmail_extra"><div><br></div></div></blockquote></div></div></div><div class="gmail_extra"><br></div><span class=""><div class="gmail_extra"><br></div>-- <br><div class="m_-878050786124512270gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold"><font color="#cc0000">Eyal edri</font></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><br></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">ASSOCIATE MANAGER</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">RHV DevOps</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><br></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat EMEA</a></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div>phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div>
</span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold"><font color="#cc0000">Eyal edri</font></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><br></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">ASSOCIATE MANAGER</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">RHV DevOps</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><br></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat EMEA</a></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div>
</div></div>