<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 16, 2017 at 10:24 AM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Mon, Oct 16, 2017 at 10:21 AM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_8654652437862383703gmail-">On Mon, Oct 16, 2017 at 9:28 AM, Daniel Belenky <span dir="ltr"><<a href="mailto:dbelenky@redhat.com" target="_blank">dbelenky@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">can someone address this issue? every patch to <u>ovirt-engine</u> that is based on top of this patch is failing OST and<b> won't deploy to the tested repo</b>.</div><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-HOEnZb"><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 15, 2017 at 9:33 AM, Daniel Belenky <span dir="ltr"><<a href="mailto:dbelenky@redhat.com" target="_blank">dbelenky@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi all,<div>The following tests are failing both of the upgrade suites in OST (upgrade_from_release and upgrade_from_prevrelease).</div><div><br></div><div><b>Link to console:</b> <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3146/console" target="_blank">ovirt-master_change-q<wbr>ueue-tester/3146/console</a></div><div><b>Link to test logs:</b></div><div> - <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3146/artifact/exported-artifacts/upgrade-from-release-suit-master-el7" target="_blank">upgrade-from-release-suit-ma<wbr>ster-el7</a></div><div> - <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3146/artifact/exported-artifacts/upgrade-from-prevrelease-suit-master-el7" target="_blank">upgrade-from-prevrelease-sui<wbr>t-master-el7</a></div><div><b>Suspected patch:</b> <a href="https://gerrit.ovirt.org/#/c/82615/5" target="_blank">https://gerrit.ovirt.or<wbr>g/#/c/82615/5</a></div><div><i>Please note that every patch that is based on top of the patch above was not deployed to the tested repo.</i></div><div><br></div><div><b>Error snippet from engine setup log:</b></div></div></blockquote></div></div></div></div></blockquote><div><br></div></span><div>Please add a direct link next time, if possible. This is it:<br><br><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3146/artifact/exported-artifacts/upgrade-from-release-suit-master-el7/test_logs/upgrade-from-release-suite-master/post-001_upgrade_engine.py/lago-upgrade-from-release-suite-master-engine/_var_log/ovirt-engine/setup/ovirt-engine-setup-20171013222617-73f0df.log" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/3146/artifact/exported-artif<wbr>acts/upgrade-from-release-<wbr>suit-master-el7/test_logs/<wbr>upgrade-from-release-suite-<wbr>master/post-001_upgrade_engine<wbr>.py/lago-upgrade-from-release-<wbr>suite-master-engine/_var_log/<wbr>ovirt-engine/setup/ovirt-<wbr>engine-setup-20171013222617-<wbr>73f0df.log</a><br><br></div><div>And a bit above the snippet below, there is:<br><br>2017-10-13 22:26:24,274-0400 DEBUG otopi.plugins.ovirt_engine_set<wbr>up.ovirt_engine.upgrade.asynct<wbr>asks plugin.execute:926 execute-output: ('/usr/share/ovirt-engine/setu<wbr>p/dbutils/taskcleaner.sh', '-l', '/var/log/ovirt-engine/setup/o<wbr>virt-engine-setup-201710132226<wbr>17-73f0df.log', '-u', 'engine', '-s', 'localhost', '-p', '5432', '-d', 'engine', '-q', '-r', '-Z') stderr:
<pre>/usr/share/ovirt-engine/bin/ge<wbr>nerate-pgpass.sh: line 3: /usr/share/ovirt-engine/setup/<wbr>dbutils/engine-prolog.sh: No such file or directory
<br></pre></div><span class="m_8654652437862383703gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-HOEnZb"><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><pre style="color:rgb(0,0,0);white-space:pre-wrap">2017-10-13 22:26:24,274-0400 DEBUG otopi.context context._executeMethod:143 method exception
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packa<wbr>ges/otopi/context.py", line 133, in _executeMethod
method['method']()
File "/usr/share/ovirt-engine/setup<wbr>/bin/../plugins/ovirt-engine-s<wbr>etup/ovirt-engine/upgrade/asyn<wbr>ctasks.py", line 470, in _validateZombies
self._clearZombies()
File "/usr/share/ovirt-engine/setup<wbr>/bin/../plugins/ovirt-engine-s<wbr>etup/ovirt-engine/upgrade/asyn<wbr>ctasks.py", line 135, in _clearZombies
'Failed to clear zombie commands. '
RuntimeError: Failed to clear zombie commands. Please access support in attempt to resolve the problem
2017-10-13 22:26:24,275-0400 ERROR otopi.context context._executeMethod:152 Failed to execute stage 'Setup validation': Failed to clear zombie commands. Please access support in attempt to resolve the problem</pre></div></div></blockquote></div></div></div></div></blockquote><div><br></div></span><div>With [1], taskcleaner.sh sources generate-pgpass.sh .<br><br>generate-pgpass.sh is in ovirt-engine-tools, which in upgrade flows, is not<br></div><div>yet upgraded (at the point of above failure).<br><br>generate-pgpass.sh in 4.1 used to source engine-prolog.sh , using a path<br></div><div>relative to "$0". In master it does not, but we now upgrade and it does.<br></div><div><br>This, in principle, is the core of the bug:<br><br></div><div>A file, such as generate-pgpass.sh, that's supposed to be sourced<br></div><div>from some other files, should not by itself source other files<br></div><div>that are relative to "$0", because it can't know what "$0" is - it's<br></div><div>the path of the script sourcing it, not of itself.<br><br></div><div>It seems like luckily we were not affected by this in 4.1, because<br></div><div>all of the files that sourced generate-pgpass.sh were together with<br></div><div>it in the same directory. But with [1], taskcleaner does too now,<br></div><div>and is in a different directory.<br><br></div><div>Not sure what's the best solution:<br><br>- revert [1] (and introduce it later on, in 4.3)<br><br>- patch 4.1's generate-pgpass.sh and require the fixed 4.1 version<br>in 4.2 setup<br><br></div><div>- Somehow trick everything to work together? Not sure. Seems like<br></div><div>you can't set $0.<br></div><div><br>[1] <a href="https://gerrit.ovirt.org/82511" target="_blank">https://gerrit.ovirt.org/82511</a></div></div></div></div></blockquote><div><br></div></div></div><div>The same bug exists with unlock_entity:<br><br><a href="https://gerrit.ovirt.org/82615" target="_blank">https://gerrit.ovirt.org/82615</a><br><br></div><div>So we should probably revert both.<br></div></div></div></div></blockquote><div><br></div><div>I tend to agree.</div><div>Doesn't mean we cannot fix this for 4.2, but let's revert for the meantime.</div><div>Y.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br><br></div><div>Regards,<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_8654652437862383703gmail-"><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-HOEnZb"><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-h5"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><span class="m_8654652437862383703gmail-m_-6661282453761250673gmail-m_3631348691870078685HOEnZb"><font color="#888888">-- <br><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-m_3631348691870078685m_-8248892620742837241gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>DANIEL</span> <span>BELENKY</span></p><p style="margin:0px;padding:0px"></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>RHV DEVOPS</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail-m_3631348691870078685gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>DANIEL</span> <span>BELENKY</span></p><p style="margin:0px;padding:0px"></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>RHV DEVOPS</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div></div></div>
</div>
</div></div><br></span>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><span class="m_8654652437862383703gmail-HOEnZb"><font color="#888888"><br></font></span></blockquote></div><span class="m_8654652437862383703gmail-HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_8654652437862383703gmail-m_-6661282453761250673gmail_signature">Didi<br></div>
</font></span></div></div>
</blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br><div class="m_8654652437862383703gmail_signature">Didi<br></div>
</font></span></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br></div></div>