<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-10-20 20:05 GMT+02:00 Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Fri, Oct 20, 2017 at 7:56 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-4742455912997223860gmail-"><div dir="ltr">On Fri, Oct 20, 2017 at 11:37 AM Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Just an heads up we have improvement margin on vdsm spec file quality.</div><div><br></div><div>[sbonazzo@sbonazzo SPECS]$ rpmlint ./vdsm.spec /var/lib/mock/epel-7-x86_64/re<wbr>sult/*rpm</div><div>vdsm.x86_64: E: explicit-lib-dependency libnl3</div></div></blockquote><div><br></div></span><div>What is wrong with this?</div><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-client</div><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-daemon-config-nwfilter</div><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-lock-sanlock</div><div>vdsm.x86_64: W: obsolete-not-provided vdsm-infra<br></div><div>vdsm.x86_64: E: no-binary</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote></span></div></div></div></blockquote><div><br></div><div><div>The package should be of the noarch architecture because it doesn't contain</div><div>any binaries.</div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: conffile-without-noreplace-fla<wbr>g /var/log/vdsm/mom.log</div></div></blockquote><div><br></div><div>This is not a conf file, we should probably change this</div><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: conffile-without-noreplace-fla<wbr>g /var/log/vdsm/supervdsm.log</div><div>vdsm.x86_64: W: conffile-without-noreplace-fla<wbr>g /var/log/vdsm/vdsm.log</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/NetworkManager/conf.d/vds<wbr>m.conf</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote><div><br></div></span><div>Perhaps:</div><div>%{_sysconfdir}/NetworkManager/<wbr>conf.d/vdsm.conf</div><div><br></div><div>should be:</div><div>%config(noreplace) %{_sysconfdir}/NetworkManager/<wbr>conf.d/vdsm.conf </div><span class="gmail-"><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: non-conffile-in-etc /etc/modprobe.d/vdsm-bonding-m<wbr>odprobe.conf</div><div>vdsm.x86_64: E: non-readable /etc/pki/vdsm/keys/libvirt_pas<wbr>sword 600</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/security/limits.d/99-vdsm<wbr>.conf</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote><div><br></div></span><div>Same?</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm</div><div>vdsm.x86_64: W: systemd-unit-in-etc /etc/systemd/system/libvirtd.s<wbr>ervice.d/unlimited-core.conf</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/systemd/system/libvirtd.s<wbr>ervice.d/unlimited-core.conf</div><div>vdsm.x86_64: E: zero-length /etc/vdsm/mom.d/01-parameters.<wbr>policy</div><div>vdsm.x86_64: E: wrong-script-interpreter /usr/libexec/vdsm/kvm2ovirt /usr/bin/env python</div></div></blockquote><div><br></div></span><div>This used to be the recommended way to write scripts, but it is easy to</div><div>replace with /usr/bin/python2.</div></div></div></blockquote></span></div></div></div></blockquote><div><br></div><div>It should be /usr/bin/python since python is under "alternatives" management</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: E: wrong-script-interpreter /usr/libexec/vdsm/vm_migrate_h<wbr>ook.py /usr/bin/env python</div><div>vdsm.x86_64: E: wrong-script-interpreter /usr/share/vdsm/virt/vm_migrat<wbr>e_hook.py /usr/bin/env python</div><div>vdsm.x86_64: E: non-executable-script /usr/share/vdsm/virt/vm_migrat<wbr>e_hook.py 644 /usr/bin/env python</div><div>vdsm.x86_64: E: non-standard-dir-perm /var/lib/libvirt/qemu/channels 775</div><div>vdsm.x86_64: E: non-standard-dir-perm /var/log/core 1777</div><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm</div></div></blockquote><div><br></div></span><div>What is wrong with this?</div></div></div></blockquote><div><br></div></span><div>"/var/run may be a temporary filesystem, so any directories or files needed there must be created dynamically at boot time."</div><span class="gmail-HOEnZb"><font color="#888888"><div><br></div><div>Y. </div></font></span><div><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm/payload</div><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm/sourceRoutes</div><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm/trackedInterface<wbr>s</div><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm/v2v</div><div>vdsm.x86_64: W: log-files-without-logrotate ['/var/log/core', '/var/log/vdsm']</div></div></blockquote><div><br></div></span><div>We have logrotate configuration for vdsm, but we don't use the standard</div><div>configuration since we need more frequent rotation. </div></div></div></blockquote></div></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><div class="gmail-m_-4742455912997223860gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: dangerous-command-in-%pre rpm</div><div>vdsm.x86_64: W: dangerous-command-in-%post chmod</div><div>vdsm-api.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packag<wbr>es/vdsm/api/vdsmapi.py /usr/bin/env python</div><div>vdsm-api.noarch: E: non-executable-script /usr/lib/python2.7/site-packag<wbr>es/vdsm/api/vdsmapi.py 644 /usr/bin/env python</div><div>vdsm-cli.noarch: W: non-conffile-in-etc /etc/bash_completion.d/vdsClie<wbr>nt</div><div>vdsm-gluster.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist</div><div>vdsm-gluster.noarch: W: no-documentation</div><div>vdsm-hook-allocate_net.noarch: W: summary-not-capitalized C random_network allocation hook for VDSM</div><div>vdsm-hook-allocate_net.noarch: W: spelling-error %description -l en_US vms -> vs, ms, ems</div><div>vdsm-hook-allocate_net.noarch: W: no-documentation</div><div>vdsm-hook-allocate_net.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_device_create/10_allocate_net /usr/bin/env python</div><div>vdsm-hook-checkimages.noarch: W: no-documentation</div><div>vdsm-hook-checkips.x86_64: W: no-documentation</div><div>vdsm-hook-checkips.x86_64: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/after_<wbr>get_stats/10_checkips /usr/bin/env python</div><div>vdsm-hook-checkips.x86_64: E: non-executable-script /usr/libexec/vdsm/hooks/after_<wbr>get_stats/checkips_utils.py 644 /usr/bin/python2 </div><div>vdsm-hook-diskunmap.noarch: W: spelling-error Summary(en_US) lun -> loon, lung, sun</div><div>vdsm-hook-diskunmap.noarch: W: no-documentation</div><div>vdsm-hook-diskunmap.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_vm_start/50_diskunmap /usr/bin/env python2</div><div>vdsm-hook-ethtool-options.noar<wbr>ch: W: spelling-error Summary(en_US) nics -> incs, mics, nicks</div><div>vdsm-hook-ethtool-options.noar<wbr>ch: W: spelling-error %description -l en_US nics -> incs, mics, nicks</div><div>vdsm-hook-ethtool-options.noar<wbr>ch: W: no-documentation</div><div>vdsm-hook-ethtool-options.noar<wbr>ch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/after_<wbr>network_setup/30_ethtool_optio<wbr>ns /usr/bin/env python</div><div>vdsm-hook-extnet.noarch: W: spelling-error Summary(en_US) vNIC -> Venice</div><div>vdsm-hook-extnet.noarch: W: spelling-error Summary(en_US) libvirt -> liberty, ovirt</div><div>vdsm-hook-extnet.noarch: W: spelling-error %description -l en_US vNIC -> Venice</div><div>vdsm-hook-extnet.noarch: W: spelling-error %description -l en_US libvirt -> liberty, ovirt</div><div>vdsm-hook-extnet.noarch: W: spelling-error %description -l en_US openvswitch -> switchboard</div><div>vdsm-hook-extnet.noarch: W: no-documentation</div><div>vdsm-hook-extra-ipv4-addrs.x86<wbr>_64: W: summary-ended-with-dot C Set extra ipv4 addresses for vdsm networks.</div><div>vdsm-hook-extra-ipv4-addrs.x86<wbr>_64: W: no-documentation</div><div>vdsm-hook-extra-ipv4-addrs.x86<wbr>_64: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/after_<wbr>network_setup/40_extra_ipv4_ad<wbr>drs /usr/bin/env python</div><div>vdsm-hook-fakesriov.x86_64: W: spelling-error %description -l en_US hostdevListByCaps </div><div>vdsm-hook-fakesriov.x86_64: W: spelling-error %description -l en_US sriov -> Rios</div><div>vdsm-hook-fakesriov.x86_64: W: spelling-error %description -l en_US conf -> con, cone, cons</div><div>vdsm-hook-fakesriov.x86_64: W: no-documentation</div><div>vdsm-hook-fakevmstats.noarch: W: spelling-error %description -l en_US vmstats -> stats</div><div>vdsm-hook-fakevmstats.noarch: W: spelling-error %description -l en_US conf -> con, cone, cons</div><div>vdsm-hook-fakevmstats.noarch: W: no-documentation</div><div>vdsm-hook-faqemu.noarch: W: spelling-error Summary(en_US) qemu -> emu, q emu</div><div>vdsm-hook-faqemu.noarch: W: spelling-error %description -l en_US kvm -> km</div><div>vdsm-hook-faqemu.noarch: W: spelling-error %description -l en_US conf -> con, cone, cons</div><div>vdsm-hook-faqemu.noarch: W: no-documentation</div><div>vdsm-hook-fcoe.noarch: W: no-documentation</div><div>vdsm-hook-fcoe.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_network_setup/50_fcoe /bin/env python</div><div>vdsm-hook-fileinject.noarch: W: no-documentation</div><div>vdsm-hook-floppy.noarch: W: no-documentation</div><div>vdsm-hook-hostusb.noarch: W: no-documentation</div><div>vdsm-hook-hostusb.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_ho<wbr>stusb 440</div><div>vdsm-hook-hostusb.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_ho<wbr>stusb</div><div>vdsm-hook-httpsisoboot.noarch: W: spelling-error Summary(en_US) https -> HTTP</div><div>vdsm-hook-httpsisoboot.noarch: W: spelling-error %description -l en_US https -> HTTP</div><div>vdsm-hook-httpsisoboot.noarch: W: spelling-error %description -l en_US http -> HTTP</div><div>vdsm-hook-httpsisoboot.noarch: W: no-documentation</div><div>vdsm-hook-hugepages.noarch: W: summary-ended-with-dot C Huge pages enable user to handle VM with 2048KB page files.</div><div>vdsm-hook-hugepages.noarch: W: no-documentation</div><div>vdsm-hook-hugepages.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_hu<wbr>gepages 440</div><div>vdsm-hook-hugepages.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_hu<wbr>gepages</div><div>vdsm-hook-ipv6.noarch: W: no-documentation</div><div>vdsm-hook-ipv6.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_network_setup/50_ipv6 /usr/bin/env python2</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: W: spelling-error %description -l en_US ip -> pi, up, op</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: W: spelling-error %description -l en_US filterref -> filter ref, filter-ref, filterer</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: W: no-documentation</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: E: executable-marked-as-config-fi<wbr>le /etc/libvirt/nwfilter/isolated<wbr>privatevlan-vdsm.xml</div><div>vdsm-hook-isolatedprivatevlan.<wbr>noarch: E: script-without-shebang /etc/libvirt/nwfilter/isolated<wbr>privatevlan-vdsm.xml</div><div>vdsm-hook-localdisk.noarch: W: spelling-error %description -l en_US lvm -> lvi, lam, Lvov</div><div>vdsm-hook-localdisk.noarch: W: only-non-binary-in-usr-lib</div><div>vdsm-hook-localdisk.noarch: W: no-documentation</div><div>vdsm-hook-localdisk.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_lo<wbr>caldisk 440</div><div>vdsm-hook-localdisk.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_lo<wbr>caldisk</div><div>vdsm-hook-macbind.noarch: W: spelling-error Summary(en_US) vNIC -> Venice</div><div>vdsm-hook-macbind.noarch: W: spelling-error %description -l en_US vNIC -> Venice</div><div>vdsm-hook-macbind.noarch: W: no-documentation</div><div>vdsm-hook-macbind.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_vm_start/50_macbind /usr/bin/env python2</div><div>vdsm-hook-macspoof.noarch: W: spelling-error %description -l en_US vnics -> conics</div><div>vdsm-hook-macspoof.noarch: W: no-documentation</div><div>vdsm-hook-nestedvt.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization</div><div>vdsm-hook-nestedvt.noarch: W: spelling-error %description -l en_US kvm -> km</div><div>vdsm-hook-nestedvt.noarch: W: no-documentation</div><div>vdsm-hook-nestedvt.noarch: W: non-conffile-in-etc /etc/modprobe.d/vdsm-nestedvt.<wbr>conf</div><div>vdsm-hook-noipspoof.noarch: W: no-documentation</div><div>vdsm-hook-numa.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml</div><div>vdsm-hook-numa.noarch: W: no-documentation</div><div>vdsm-hook-openstacknet.noarch: W: spelling-error Summary(en_US) vNICs -> conics</div><div>vdsm-hook-openstacknet.noarch: W: spelling-error %description -l en_US vNICs -> conics</div><div>vdsm-hook-openstacknet.noarch: W: no-documentation</div><div>vdsm-hook-openstacknet.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_op<wbr>enstacknet 440</div><div>vdsm-hook-openstacknet.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_op<wbr>enstacknet</div><div>vdsm-hook-openstacknet.noarch: E: wrong-script-interpreter /usr/libexec/vdsm/hooks/before<wbr>_device_migrate_destination/<wbr>50_openstacknet /usr/bin/env python2</div><div>vdsm-hook-pincpu.noarch: W: no-documentation</div><div>vdsm-hook-promisc.noarch: W: no-documentation</div><div>vdsm-hook-promisc.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_pr<wbr>omisc 440</div><div>vdsm-hook-promisc.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_pr<wbr>omisc</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error Summary(en_US) cmdline -> decline</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US cmdline -> decline</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US libvirt's -> liberty's</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US qemu -> emu, q emu</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml</div><div>vdsm-hook-qemucmdline.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace</div><div>vdsm-hook-qemucmdline.noarch: W: no-documentation</div><div>vdsm-hook-qos.noarch: W: no-documentation</div><div>vdsm-hook-scratchpad.noarch: W: no-documentation</div><div>vdsm-hook-smbios.noarch: W: spelling-error Summary(en_US) libvirt -> liberty, ovirt</div><div>vdsm-hook-smbios.noarch: W: spelling-error %description -l en_US libvirt -> liberty, ovirt</div><div>vdsm-hook-smbios.noarch: W: no-documentation</div><div>vdsm-hook-spiceoptions.noarch: W: spelling-error Summary(en_US) vm -> cm, v, m</div><div>vdsm-hook-spiceoptions.noarch: W: no-documentation</div><div>vdsm-hook-vfio-mdev.noarch: W: summary-ended-with-dot C Hook to enable mdev-capable devices.</div><div>vdsm-hook-vfio-mdev.noarch: W: no-documentation</div><div>vdsm-hook-vhostmd.noarch: W: no-documentation</div><div>vdsm-hook-vhostmd.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_vh<wbr>ostmd 440</div><div>vdsm-hook-vhostmd.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_vh<wbr>ostmd</div><div>vdsm-hook-vmdisk.noarch: W: no-documentation</div><div>vdsm-hook-vmfex.noarch: W: summary-not-capitalized C vmfex support for VDSM</div><div>vdsm-hook-vmfex.noarch: W: no-documentation</div><div>vdsm-hook-vmfex-dev.noarch: W: spelling-error Summary(en_US) vNIC -> Venice</div><div>vdsm-hook-vmfex-dev.noarch: W: spelling-error %description -l en_US vNIC -> Venice</div><div>vdsm-hook-vmfex-dev.noarch: W: spelling-error %description -l en_US macvtap -> madcap</div><div>vdsm-hook-vmfex-dev.noarch: W: no-documentation</div><div>vdsm-jsonrpc.noarch: W: spelling-error %description -l en_US libvdsm -> liberalism</div><div>vdsm-jsonrpc.noarch: W: obsolete-not-provided vdsm-api</div><div>vdsm-jsonrpc.noarch: W: no-documentation</div><div>vdsm-python.noarch: E: non-executable-script /usr/lib/python2.7/site-packag<wbr>es/vdsm/tool/dummybr.py 644 /usr/bin/python2 </div><div>vdsm-python.noarch: E: non-executable-script /usr/lib/python2.7/site-packag<wbr>es/vdsm/tool/nwfilter.py 644 /usr/bin/python2 </div><div>vdsm-python.noarch: W: dangerous-command-in-%post rm</div><div>vdsm-tests.noarch: E: non-executable-script /usr/share/vdsm/tests/alignmen<wbr>tScanTests.py 644 /usr/bin/python2 </div></div></blockquote><div><br></div></div></div><div>This looks easy, this is not a script</div><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm-tests.noarch: E: wrong-script-interpreter /usr/share/vdsm/tests/fake-ssh<wbr>-add /usr/bin/env python</div><div>vdsm-tests.noarch: E: non-executable-script /usr/share/vdsm/tests/fake-ssh<wbr>-add 644 /usr/bin/env python</div><div>vdsm-tests.noarch: E: wrong-script-interpreter /usr/share/vdsm/tests/fake-ssh<wbr>-agent /usr/bin/env python</div><div>vdsm-tests.noarch: E: non-executable-script /usr/share/vdsm/tests/fake-ssh<wbr>-agent 644 /usr/bin/env python</div><div>vdsm-tests.noarch: E: wrong-script-interpreter /usr/share/vdsm/tests/fake-vir<wbr>t-v2v /usr/bin/env python</div><div>vdsm-tests.noarch: E: non-executable-script /usr/share/vdsm/tests/fake-vir<wbr>t-v2v 644 /usr/bin/env python</div><div>vdsm-tests.noarch: E: script-without-shebang /usr/share/vdsm/tests/testVali<wbr>dation.py</div></div></blockquote><div><br></div></span><div>This is also not a script, maybe wrong permissions?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm-tests.noarch: E: zero-length /usr/share/vdsm/tests/toolTest<wbr>s_empty.conf</div></div></blockquote><div><br></div><div>This is bogus error, but we can probably replace this with generated temporary file.</div><span class="gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm-xmlrpc.noarch: W: spelling-error %description -l en_US vdsmd </div><div>vdsm-xmlrpc.noarch: W: spelling-error %description -l en_US vdsClient -> clientele</div><div>vdsm-xmlrpc.noarch: W: no-documentation</div><div>vdsm-yajsonrpc.noarch: W: no-documentation</div><div>48 packages and 1 specfiles checked; 49 errors, 120 warnings.</div></div></blockquote><div><br></div></span><div>Sandro, can you help with adding a test to vdsm build, failing if the spec has</div><div>errors?</div></div></div></blockquote></div></div></div></div></div></blockquote><div><br></div><div>Some of the errors may be false positives, but if really needed I can help with the test.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>This would also would be useful to other projects like ovirt-imageio.</div><div><br></div><div>Nir</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4742455912997223860gmail-"><div dir="ltr"><div><br></div><div><br></div>-- <br><div class="gmail-m_-4742455912997223860gmail-m_2168858289825454197m_1679924899913372686gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>SANDRO</span> <span>BONAZZOLA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>EMEA</span></a></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></div></td></tr></tbody></table><a href="http://www.teraplan.it/redhat-osd-2017/" target="_blank"><img src="http://images.engage.redhat.com/EloquaImages/clients/RedHat/%7Bce8ba915-16e1-4b66-8a16-dfaac06bd5c0%7D_RH_OSD_Generic_Banner_655x100.png" width="420" height="60"></a><span></span><a href="http:///" target="_blank"></a><span></span><br></div></div></div></div></div></div></div></div></div></div></div>
</div></span>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></blockquote></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div></div></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>SANDRO</span> <span>BONAZZOLA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>EMEA</span></a></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></div></td></tr></tbody></table><a href="http://www.teraplan.it/redhat-osd-2017/" target="_blank"><img src="http://images.engage.redhat.com/EloquaImages/clients/RedHat/%7Bce8ba915-16e1-4b66-8a16-dfaac06bd5c0%7D_RH_OSD_Generic_Banner_655x100.png" width="420" height="60"></a><span></span><a href="http:///" target="_blank"></a><span></span><br></div></div></div></div></div></div></div></div></div></div></div>
</div></div>