<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 25, 2017 at 3:21 PM, Nir Soffer <span dir="ltr">&lt;<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-"><div dir="ltr">On Wed, Oct 25, 2017 at 9:33 AM Sandro Bonazzola &lt;<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2017-10-20 20:05 GMT+02:00 Yaniv Kaul <span dir="ltr">&lt;<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>&gt;</span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-">On Fri, Oct 20, 2017 at 7:56 PM, Nir Soffer <span dir="ltr">&lt;<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div dir="ltr">On Fri, Oct 20, 2017 at 11:37 AM Sandro Bonazzola &lt;<a href="mailto:sbonazzo@redhat.com" target="_blank">sbonazzo@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Just an heads up we have improvement margin on vdsm spec file quality.</div><div><br></div><div>[sbonazzo@sbonazzo SPECS]$ rpmlint ./vdsm.spec /var/lib/mock/epel-7-x86_64/<wbr>result/*rpm</div><div>vdsm.x86_64: E: explicit-lib-dependency libnl3</div></div></blockquote><div><br></div></span><div>What is wrong with this?</div><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-client</div><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-daemon-config-nwfilter</div><div>vdsm.x86_64: E: explicit-lib-dependency libvirt-lock-sanlock</div><div>vdsm.x86_64: W: obsolete-not-provided vdsm-infra<br></div><div>vdsm.x86_64: E: no-binary</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote></span></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div>The package should be of the noarch architecture because it doesn&#39;t contain</div><div>any binaries.</div></div></div></div></div></blockquote><div><br></div></span><div>Vdsm has many arch specific requirements, and we have different requirements</div><div>on different platforms. Having a arch specific meta package was the solution</div><div>suggested by Fedora reviewers about 2 years ago.</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: conffile-without-noreplace-<wbr>flag /var/log/vdsm/mom.log</div></div></blockquote><div><br></div><div>This is not a conf file, we should probably change this</div><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: conffile-without-noreplace-<wbr>flag /var/log/vdsm/supervdsm.log</div><div>vdsm.x86_64: W: conffile-without-noreplace-<wbr>flag /var/log/vdsm/vdsm.log</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/NetworkManager/conf.d/<wbr>vdsm.conf</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote><div><br></div></span><div>Perhaps:</div><div>%{_sysconfdir}/NetworkManager/<wbr>conf.d/vdsm.conf</div><div><br></div><div>should be:</div><div>%config(noreplace) %{_sysconfdir}/NetworkManager/<wbr>conf.d/vdsm.conf </div><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-"><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: non-conffile-in-etc /etc/modprobe.d/vdsm-bonding-<wbr>modprobe.conf</div><div>vdsm.x86_64: E: non-readable /etc/pki/vdsm/keys/libvirt_<wbr>password 600</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/security/limits.d/99-<wbr>vdsm.conf</div></div></blockquote><div><br></div></span><div>Ha?</div></div></div></blockquote><div><br></div></span><div>Same?</div><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm</div><div>vdsm.x86_64: W: systemd-unit-in-etc /etc/systemd/system/libvirtd.<wbr>service.d/unlimited-core.conf</div><div>vdsm.x86_64: W: non-conffile-in-etc /etc/systemd/system/libvirtd.<wbr>service.d/unlimited-core.conf</div><div>vdsm.x86_64: E: zero-length /etc/vdsm/mom.d/01-parameters.<wbr>policy</div><div>vdsm.x86_64: E: wrong-script-interpreter /usr/libexec/vdsm/kvm2ovirt /usr/bin/env python</div></div></blockquote><div><br></div></span><div>This used to be the recommended way to write scripts, but it is easy to</div><div>replace with /usr/bin/python2.</div></div></div></blockquote></span></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>It should be /usr/bin/python since python is under &quot;alternatives&quot; management</div></div></div></div></blockquote><div><br></div></span><div>But most of the code is python2 only - we recently update (most) scripts to use</div><div>/usr/bin/python2.</div><span class="gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>vdsm.x86_64: E: wrong-script-interpreter /usr/libexec/vdsm/vm_migrate_<wbr>hook.py /usr/bin/env python</div><div>vdsm.x86_64: E: wrong-script-interpreter /usr/share/vdsm/virt/vm_<wbr>migrate_hook.py /usr/bin/env python</div><div>vdsm.x86_64: E: non-executable-script /usr/share/vdsm/virt/vm_<wbr>migrate_hook.py 644 /usr/bin/env python</div><div>vdsm.x86_64: E: non-standard-dir-perm /var/lib/libvirt/qemu/channels 775</div><div>vdsm.x86_64: E: non-standard-dir-perm /var/log/core 1777</div><div>vdsm.x86_64: E: dir-or-file-in-var-run /var/run/vdsm</div></div></blockquote><div><br></div></span><div>What is wrong with this?</div></div></div></blockquote><div><br></div></span><div>&quot;/var/run may be a temporary filesystem, so any directories or files needed there must be created dynamically at boot time.&quot;</div></div></div></div></blockquote></div></div></div></blockquote><div><br></div></span><div>We create these directories in runtime, not sure why we create them also </div><div>during instillation.</div></div></div></blockquote><div><br></div><div>As of my I0bdc3b1f2be960d536856465979c89ac85bce4a5 (introduced to silence rpmlint), we no longer do.</div><div><br></div><div>I do not recall why do we still have this horrible <span class="gmail-"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-"><span class="gmail-m_-3265794237610697644m_-7389532273925150490gmail-m_-4742455912997223860gmail-">/var/log/core 1777; I hoped that with proper integration to ABRT, we can delegate the responsiblity of collecting core dumps. Irit, do you recall?<br></span></span></span></div><br></div></div></div>