<div dir="ltr"><div>Yep, I guess you're right.<br></div>Haven't noticed that :)<br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br>Regards,<br></div>Idan<br></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Oct 26, 2017 at 2:26 PM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">... yeah should be a $<div><br></div><div>fix: <a href="https://gerrit.ovirt.org/83216" target="_blank">https://gerrit.ovirt.org/<wbr>83216</a> (@Idan, can you verify?)<br><div><br></div><div><div>git blame ./frontend/webadmin/modules/<wbr>frontend/src/main/resources/<wbr>org/ovirt/engine/ui/frontend/<wbr>AppErrors.properties |grep -C 5 VAR__TYPE__LUNS</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1177) VAR__TYPE__CLUSTER_POLICY=$<wbr>type Scheduling Policy</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1178) VAR__TYPE__COMPUTER_ACCOUNT=$<wbr>type Computer Account</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1179) VAR__TYPE__CPU_PROFILE=$type CPU Profile</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1180) VAR__TYPE__DESKTOP_POOL=$type VM-Pool</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1181) VAR__TYPE__DISK=$type Virtual Disk</div><div>d99144f0882 (Idan Shaby 2017-07-03 11:17:50 +0300 1182) VAR__TYPE__LUNS=@type LUNs</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1183) VAR__TYPE__DISK_PROFILE=$type Disk Profile</div><div>ad0c5001641 (Scott J Dickerson 2016-05-19 04:56:29 -0400 1184) VAR__TYPE__DISK__SNAPSHOT=$<wbr>type Disk Snapshot</div><div>6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1185) VAR__TYPE__EXTERNAL_EVENT=$<wbr>type External Event</div><div>6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1186) VAR__TYPE__EXTERNAL_JOB=$type External Job</div><div>6d4008eddb3 (Jakub Niedermertl 2017-06-12 02:06:45 +0200 1187) VAR__TYPE__EXTERNAL_STEP=$type External Step</div><div><div class="h5"><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 26, 2017 at 6:02 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">I think Yuko meant: it should be a $ instead of @.<span class="m_7800732263361610941gmail-HOEnZb"><font color="#888888"><br><br><div>Greg</div></font></span></div><div class="m_7800732263361610941gmail-HOEnZb"><div class="m_7800732263361610941gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Oct 26, 2017 2:28 AM, "Idan Shaby" <<a href="mailto:ishaby@redhat.com" target="_blank">ishaby@redhat.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div>Hi Yuko,<br><br></div>I am not sure where exactly you meant that the typo is.<br></div><span style="color:rgb(0,0,0)"><font size="2"><span style="font-family:arial,helvetica,sans-serif">- "LUNs" (in "@type LUNs") seems ok since LUN is </span></font></span><span id="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-result_box" class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-short_text" lang="en"><span class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-">an acronym and the "s" is for the plural.<br>- </span></span><span style="color:rgb(0,0,0)"><font size="2"><span style="font-family:arial,helvetica,sans-serif">"LUNS" (in "VAR__TYPE__LUNS") seems ok since variable names in AppErrors should be </span></font></span><span style="color:rgb(0,0,0)"><font size="2"><span style="font-family:arial,helvetica,sans-serif"><span id="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-result_box" class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-short_text" lang="en"><span class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail-">in capital letters</span></span>.<br><br></span></font></span></div><span style="color:rgb(0,0,0)"><font size="2"><span style="font-family:arial,helvetica,sans-serif">If I misunderstood please say so.<br></span></font></span><div class="gmail_extra"><br clear="all"><div><div class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br>Regards,<br></div>Idan<br></div></div></div></div></div></div></div>
<br><div class="gmail_quote">On Thu, Oct 26, 2017 at 3:18 AM, Yuko Katabami <span dir="ltr"><<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><font size="1">Hello again.</font></div><div><font size="1">Here is my next question.</font></div><div style="font-size:small"><br clear="all"></div><div><div style="font-size:small"><b style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">File: </b><font style="font-size:16px" color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">AppErrors</span></font></div><p style="margin:0px;padding:0px;word-wrap:break-word"><b style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">Resource ID: </b><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">VAR__TYPE__LUNS</span></font></p><div style="font-size:small;display:inline"><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"></font></div><b style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">String: </b><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">@type LUNs</span><span style="font-size:15px;white-space:pre-wrap"> </span></font><div><span style="font-size:small"><b style="color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;font-size:15px">Question:</b><span style="color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;font-size:15px"> </span></span><font size="1">Is this a typo for "$type LUNs"?</font></div><span class="m_7800732263361610941gmail-m_-8017021270123807281m_-5375376583170766403HOEnZb"><font color="#888888"><div style="font-size:16px"><font size="1"><br></font></div><div style="font-size:16px"><font size="1">Yuko</font></div></font></span></div></div>
</div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div></div>
</div></div></blockquote></div><br><div class="m_7800732263361610941gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div></div>
</div></div></div></div></div></div>
</blockquote></div><br></div>