<div dir="ltr"><div class="gmail_default" style="font-size:small">Thank you very much Greg for looking into this.</div><div class="gmail_default" style="font-size:small">Your suggested message makes perfect sense.</div><div class="gmail_default" style="font-size:small">I leave my translation as-is for now (I cannot edit the source text) but when it is fixed and repushed to Zanata, I will retranslate it.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Yuko</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 27, 2017 at 9:44 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">As I thought from the context of the sentence, it's being used as a (parameterized) Message, like this:<div><br></div><div><div> if (isKsmEnabled) {</div><div> recommendationsList.add(consta<wbr>nts.highPerformancePopupRecomm<wbr>endationMsgForKsmPart1()</div><div> + clusterName</div><div> + constants.highPerformancePopup<wbr>RecommendationMsgForKsmPart2()<wbr>);</div><div> }</div></div><div><br></div><div>So the cluster name is set between those two quotes.</div><div><br></div><div>The programmer is supposed to use "Messages"[1] for this, not Constants. The message should be:</div><div><br></div><div><div><div>highPerformancePopupRecommenda<wbr>tionMsgForKsm=KERNEL SAME PAGE MERGING (KSM): Please disable KSM by disabling it for the Cluster: "{0}". This can be done by editing the Cluster and disabling the "Enable KSM" field.</div></div><div><br></div></div><div>^ although I'm not sure why the cluster name would be in quotes. It doesn't need to be. It can just say Cluster X (no colon either)</div><div><br></div><div>Greg</div><div><br></div><div>[1] ./frontend/webadmin/module<wbr>s/webadmin/src/main/resources/<wbr>org/ovirt/engine/ui/webadmin/<wbr>ApplicationMessages.properties</div><div>Example: </div><div>geoRepSlaveVolumeToolTip=Volum<wbr>e data from {0} of cluster {1} is replicated to this volume.</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-3698154717367721824h5">On Thu, Oct 26, 2017 at 7:24 PM, Yuko Katabami <span dir="ltr"><<a href="mailto:ykatabam@redhat.com" target="_blank">ykatabam@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="m_-3698154717367721824h5"><div dir="ltr"><div><div><div><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">Hello oVirt developers.</span></font></div><div><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">My next question is as follows;</span></font></div><div><strong style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif"><br></strong></div><div><strong style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">File: </strong><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">UIConstants</span></font></div><p style="margin:0px;padding:0px;word-wrap:break-word"><strong style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">Resource IDs: <br></strong><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">highPerformancePopupRecommenda<wbr>tionMsgForKsmPart1</span></font></p><p style="margin:0px;padding:0px;word-wrap:break-word"><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px">highPerformancePopupRecommenda<wbr>tionMsgForKsmPart2</span><br></font></p><div style="font-size:small;display:inline"><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"></font></div><strong style="font-size:15px;color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif">Strings: </strong></div><div><font color="#3d3d3d" face="Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif"><span style="font-size:15px"><div>KERNEL SAME PAGE MERGING (KSM):</div><div>Please disable KSM by disabling it for the Cluster: "</div><div><br></div><div>". This can be done by editing the Cluster and disabling the "Enable KSM" field.</div></span></font></div><div style="font-size:16px"><div><span style="font-size:small"><strong style="color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;font-size:15px">Question:</strong><span style="color:rgb(61,61,61);font-family:"Helvetica Neue",Helvetica,Arial,"Lucida Grande",sans-serif;font-size:15px"> </span></span>There is something wrong with the usage of double quotes in those two strings. Could I remove it from the end of the first string, and the beginning of the second string (as well as the period)?</div><div><br></div><div>Thank you,</div><div><br></div><div>Yuko</div></div></div>
</div>
<br></div></div>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br><div class="m_-3698154717367721824m_-8555116522538532217gmail-m_7290036974217110948gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div><div class="m_-3698154717367721824gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div></div>