<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 2, 2017 at 12:30 PM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Thu, Nov 2, 2017 at 12:22 PM, Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>> wrote:<br>
><br>
><br>
><br>
> On Thu, Nov 2, 2017 at 12:12 PM, Yedidyah Bar David <<a href="mailto:didi@redhat.com">didi@redhat.com</a>> wrote:<br>
>><br>
>> On Thu, Nov 2, 2017 at 9:56 AM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
>> ><br>
>> ><br>
>> ><br>
>> > 2017-11-02 8:46 GMT+01:00 Eyal Edri <<a href="mailto:eedri@redhat.com">eedri@redhat.com</a>>:<br>
>> >><br>
>> >><br>
>> >><br>
>> >> On Thu, Nov 2, 2017 at 9:24 AM, Sandro Bonazzola <<a href="mailto:sbonazzo@redhat.com">sbonazzo@redhat.com</a>> wrote:<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> 2017-11-01 17:16 GMT+01:00 Dafna Ron <<a href="mailto:dron@redhat.com">dron@redhat.com</a>>:<br>
>> >>>><br>
>> >>>> Hi,<br>
>> >>>><br>
>> >>>> we have failures in 4.1 imagebased.<br>
>> >>>><br>
>> >>>> I think it's also related to the same package from 4.2 that is downloaded in the 4.1 repo.<br>
>> >>>><br>
>> >>>> 2017-11-01 13:17:53,817::ssh.py::ssh::96:<wbr>:lago.ssh::DEBUG::Command 10946280 on lago-basic-suite-4-1-host-0 errors:<br>
>> >>>> Error: Package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch (alocalsync)<br>
>> >>>> Requires: vdsm-client >= 4.20.0<br>
>> >>>> Available: vdsm-client-4.19.35-2.<wbr>gitc1d5a55.el7.centos.noarch (alocalsync)<br>
>> >>>> vdsm-client = 4.19.35-2.gitc1d5a55.el7.<wbr>centos<br>
>> >>>> Error: Package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch (alocalsync)<br>
>> >>>> Requires: vdsm >= 4.20.0<br>
>> >>>> Available: vdsm-4.19.35-2.gitc1d5a55.el7.<wbr>centos.x86_64 (alocalsync)<br>
>> >>>> vdsm = 4.19.35-2.gitc1d5a55.el7.<wbr>centos<br>
>><br>
>> Where exactly is this failure? Please add links in such reports. Thanks.<br>
>><br>
>> >>>><br>
>> >>>><br>
>> >>>> From what I can see, the package is coming from the centos mirros:<br>
>> >>>><br>
>> >>>> yum -y install ovirt-host<br>
>> >>>> rm -rf /dev/shm/*.rpm /dev/shm/yum<br>
>> >>>> "<br>
>> >>>> 2017-11-01 13:17:53,817::ssh.py::ssh::81:<wbr>:lago.ssh::DEBUG::Command 10946280 on lago-basic-suite-4-1-host-0 returned with 0<br>
>> >>>> 2017-11-01 13:17:53,817::ssh.py::ssh::89:<wbr>:lago.ssh::DEBUG::Command 10946280 on lago-basic-suite-4-1-host-0 output:<br>
>> >>>> Loaded plugins: fastestmirror<br>
>> >>>> Loading mirror speeds from cached hostfile<br>
>> >>>> * base: <a href="http://mirror.keystealth.org" rel="noreferrer" target="_blank">mirror.keystealth.org</a><br>
>> >>>> * extras: <a href="http://mirror.lax.hugeserver.com" rel="noreferrer" target="_blank">mirror.lax.hugeserver.com</a><br>
>> >>>> * updates: <a href="http://dallas.tx.mirror.xygenhosting.com" rel="noreferrer" target="_blank">dallas.tx.mirror.xygenhosting.<wbr>com</a><br>
>> >>>> Resolving Dependencies<br>
>> >>>> --> Running transaction check<br>
>> >>>> ---> Package ovirt-host.noarch 0:4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos will be installed<br>
>> >>>> --> Processing Dependency: vdsm >= 4.20.0 for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: vdsm-client >= 4.20.0 for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: collectd for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: collectd-disk for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: collectd-netlink for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: collectd-virt for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: collectd-write_http for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: fluentd for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: ovirt-vmconsole for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: ovirt-vmconsole-host for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: rubygem-fluent-plugin-<wbr>collectd-nest for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: rubygem-fluent-plugin-rewrite-<wbr>tag-filter for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: rubygem-fluent-plugin-secure-<wbr>forward for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: rubygem-fluent-plugin-viaq_<wbr>data_model for package: ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.noarch<br>
>> >>>> --> Processing Dependency: socat for package: <a href="http://ovirt-host-4.2.0-0.0.master.20171019135233.git1921fc6.el7.centos.no" rel="noreferrer" target="_blank">ovirt-host-4.2.0-0.0.master.<wbr>20171019135233.git1921fc6.el7.<wbr>centos.no</a><br>
>> >>>><br>
>> >>>><br>
>> >>>> Sandro, can you please help to remove this package?<br>
>> >>><br>
>> >>><br>
>> >>> Removed from tested repo. It should have been ovirt-host-4.1.0 not 4.2.0. Not sure how it got there passing CI.<br>
>> >><br>
>> >><br>
>> >> It got there before the test that was trying to install it was added to OST, so nothing prevented it from being pushed to 4.2.<br>
>><br>
>> Not sure I fully understand. What test does install it now?<br>
>> All I see is [1], which is a performance cheat/hack, not a proper test,<br>
>> and was merged long ago (1.5 weeks before I started breaking ovirt-host-4.1).<br>
>><br>
>> In principle, only the engine should instruct to install ovirt-host<br>
>> during *testing*, and only a 4.2 engine. Do we have tests that add<br>
>> a 4.1 host to a 4.2 engine?<br>
><br>
><br>
> This was another bug in OST, the installation of ovirt-host should only have be done on 4.2, its also fixed now so future runs should install ovirt-host only on 4.2.<br>
<br>
</div></div>If in "another bug" you mean "the reason for [1]" (it has no bug-url),<br></blockquote><div><br></div><div>Yea this is what I meant, maybe 'bug' was a wrong word for it, the author didn't intended to have ovirt-host</div><div>test added to 4.1 at this point, but it got in due to shared LagoInitFile.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
then I do not think it's a bug, at least not now (after 4.1 repo is fixed).<br>
Installing ovirt-host-4.1 for a 4.1 host should have exactly the same<br>
principle effect as installing ovirt-host-4.2 for a 4.2 host. The only<br>
difference is that only 4.2 engines /rely/ on this behavior, but if<br>
the patch before [1] was only added as a performance hack, there is no<br>
problem in using it also for 4.1.<br></blockquote><div><br></div><div>If you think its valuable and relevant, please send a patch to add it to 4.1, I got the feeling we only want to test it on 4.2.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
[1] <a href="https://gerrit.ovirt.org/83448" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/83448</a><br>
<div><div class="h5"><br>
><br>
>><br>
>><br>
>> [1] <a href="https://gerrit.ovirt.org/82461" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/82461</a><br>
>><br>
>> ><br>
>> ><br>
>> > ok, this explain<br>
>> ><br>
>> >><br>
>> >> If you know that a certain pkg got built with the wrong version, please let us know so we can act on it and perhaps avoid such failures.<br>
>><br>
>> Sorry, that's my fault, and I didn't think about it.<br>
>> As Sandro wrote in private, I started the work on 4.1<br>
>> by cherry-picking patches for master that I decided we<br>
>> need in 4.1, and only later changed the version to 4.1.<br>
>> In retrospective, I should probably have done this adaptation<br>
>> as the first patch in the series.<br>
>><br>
>> ><br>
>> ><br>
>> > I've been made aware this morning<br>
>> ><br>
>> >><br>
>> >><br>
>> >> The 4.1 build was changed in [1] but before that it was building 4.2 version.<br>
>> ><br>
>> ><br>
>> > Noted that while investigating this morning<br>
>> ><br>
>> >><br>
>> >><br>
>> >><br>
>> >> [1] <a href="https://gerrit.ovirt.org/#/c/82875/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>82875/</a><br>
>> >><br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>>><br>
>> >>>><br>
>> >>>> Thanks,<br>
>> >>>> Dafna<br>
>> >>>><br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> --<br>
>> >>><br>
>> >>> SANDRO BONAZZOLA<br>
>> >>><br>
>> >>> ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D<br>
>> >>><br>
>> >>> Red Hat EMEA<br>
>> >>><br>
>> >>> TRIED. TESTED. TRUSTED.<br>
>> >>><br>
>> >>><br>
>> >>> ______________________________<wbr>_________________<br>
>> >>> Devel mailing list<br>
>> >>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
>> >>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
>> >><br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >><br>
>> >> Eyal edri<br>
>> >><br>
>> >><br>
>> >> MANAGER<br>
>> >><br>
>> >> RHV DevOps<br>
>> >><br>
>> >> EMEA VIRTUALIZATION R&D<br>
>> >><br>
>> >><br>
>> >> Red Hat EMEA<br>
>> >><br>
>> >> TRIED. TESTED. TRUSTED.<br>
>> >> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
>> >> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> ><br>
>> > SANDRO BONAZZOLA<br>
>> ><br>
>> > ASSOCIATE MANAGER, SOFTWARE ENGINEERING, EMEA ENG VIRTUALIZATION R&D<br>
>> ><br>
>> > Red Hat EMEA<br>
>> ><br>
>> > TRIED. TESTED. TRUSTED.<br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> Didi<br>
><br>
><br>
><br>
><br>
> --<br>
><br>
> Eyal edri<br>
><br>
><br>
> MANAGER<br>
><br>
> RHV DevOps<br>
><br>
> EMEA VIRTUALIZATION R&D<br>
><br>
><br>
> Red Hat EMEA<br>
><br>
> TRIED. TESTED. TRUSTED.<br>
> phone: <a href="tel:%2B972-9-7692018" value="+97297692018">+972-9-7692018</a><br>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
<br>
<br>
<br>
<br>
--<br>
</div></div>Didi<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold"><font color="#cc0000">Eyal edri</font></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><br></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">MANAGER</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">RHV DevOps</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><br></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat EMEA</a></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div>phone: +972-9-7692018<br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div></div></div>
</div></div>