<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Both are merged, let's see how OST fares</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 13, 2017 at 12:00 PM, Allon Mureinik <span dir="ltr"><<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">I merged 83920 with dependencies. Perhaps gerrit doesn't handle such chains properly (or perhaps our CI is misusing the API?).</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">WRT current issues, posted two patches upstream:</div><div class="gmail_default" style="font-family:monospace,monospace">- <a href="https://gerrit.ovirt.org/#/c/83986/" target="_blank">https://gerrit.ovirt.org/#/<wbr>c/83986/</a> - fixes the GWT build that was broken this morning, preventing a proper build altogether</div><div class="gmail_default" style="font-family:monospace,monospace">- <a href="https://gerrit.ovirt.org/#/c/83987/" target="_blank">https://gerrit.ovirt.org/#/<wbr>c/83987/</a> - should fix the OST regression you noted.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">I'm waiting for the CI to finish running on both and will merge.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 13, 2017 at 11:26 AM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 13 November 2017 at 11:10, Allon Mureinik <<a href="mailto:amureini@redhat.com" target="_blank">amureini@redhat.com</a>> wrote:<br>
> Commit 86bf82e746404145e8b97df46f5140<wbr>86e4f82e69 is probably the offending<br>
> commit, taking a deeper look now, should have a fix within the hour<br>
><br>
<br>
</span>Hmm, I see what happened there, that commit is<br>
<a href="https://gerrit.ovirt.org/c/83920" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/c/839<wbr>20</a>, so it was tested at:<br>
<a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3769" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/3769</a><br>
and passed.<br>
<br>
BUT, it was tested along with <a href="https://gerrit.ovirt.org/#/c/83918/2" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>3918/2</a><br>
that was merged earlier as far as git ordering goes, but somehow was<br>
assumed to be a later patch. When we test multiple patches from the<br>
same project we essentially use packages built from the one we deem to<br>
be the latest. So in this case only the packages from 83918 were<br>
actually tested.<br>
<br>
We went to great lengths to preserve correct patch ordering by<br>
preserving the order of event notifications reaching us from gerrit.<br>
But here it seems we ended out with out-of-order patches. Do you have<br>
any idea how did we end up with this? Do you remember what was the<br>
sequence in which you clicked the 'merge' button on the different<br>
patches?<br>
<div class="m_-4045296225863113064HOEnZb"><div class="m_-4045296225863113064h5"><br>
--<br>
Barak Korren<br>
RHV DevOps team , RHCE, RHCi<br>
Red Hat EMEA<br>
<a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" rel="noreferrer" target="_blank">redhat.com/trusted</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>