<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">It&#39;s most definitely not THAT patch.</div><div class="gmail_default" style="font-family:monospace,monospace">Could be one of the earlier patches in the series, though.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Looking.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 13, 2017 at 10:54 AM, Barak Korren <span dir="ltr">&lt;<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 13 November 2017 at 10:08, Nir Soffer &lt;<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>&gt; wrote:<br>
&gt;<br>
&gt;<br>
&gt; On Mon, Nov 13, 2017 at 9:56 AM Barak Korren &lt;<a href="mailto:bkorren@redhat.com">bkorren@redhat.com</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Test failed: [ add_master_storage_domain ]<br>
&gt;&gt;<br>
&gt;&gt; Link to suspected patches:<br>
&gt;&gt; - <a href="https://gerrit.ovirt.org/#/c/83849/4" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83849/4</a><br>
&gt;<br>
&gt;<br>
&gt; This fixes grammar in few error messages, I don&#39;t see how this can cause<br>
&gt; failures unless someone is depending on the error text...<br>
&gt;<br>
</span>Previous test with engine patches before it was successful:<br>
<a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3769" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-master_change-queue-<wbr>tester/3769</a><br>
This one included the following patches which were the two commits<br>
leading up to the failing one:<br>
- <a href="https://gerrit.ovirt.org/#/c/83920/4" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83920/4</a><br>
- <a href="https://gerrit.ovirt.org/#/c/83918/2" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83918/2</a><br>
<br>
Also following tests with no engine patches were also successful:<br>
<a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3780/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-master_change-queue-<wbr>tester/3780/</a><br>
so this eliminates suspicion for unrelated infra issues.<br>
<br>
I think that is sufficient grounds for suspicion.<br>
<div class="HOEnZb"><div class="h5"><br>
&gt;&gt;<br>
&gt;&gt; This seems to be a fairly consistent regression as all patches that<br>
&gt;&gt; follow the patch above exhibit the same issue when tested, this list<br>
&gt;&gt; of similarly failing patches includes:<br>
&gt;&gt; - <a href="https://gerrit.ovirt.org/#/c/83940/2" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83940/2</a><br>
&gt;&gt; - <a href="https://gerrit.ovirt.org/#/c/83608/7" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83608/7</a><br>
&gt;&gt; - <a href="https://gerrit.ovirt.org/#/c/83815/3" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83815/3</a><br>
&gt;&gt; The following patch is an exception because it simply failed to build:<br>
&gt;&gt; - <a href="https://gerrit.ovirt.org/#/c/83370/9" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/<wbr>83370/9</a><br>
&gt;&gt;<br>
&gt;&gt; Link to Job:<br>
&gt;&gt; <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3770/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-master_change-queue-<wbr>tester/3770/</a><br>
&gt;&gt;<br>
&gt;&gt; Link to all logs:<br>
&gt;&gt;<br>
&gt;&gt; <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/3770/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-002_bootstrap.py/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-master_change-queue-<wbr>tester/3770/artifact/exported-<wbr>artifacts/basic-suit-master-<wbr>el7/test_logs/basic-suite-<wbr>master/post-002_bootstrap.py/</a><br>
&gt;&gt;<br>
&gt;&gt; Error snippet from log:<br>
&gt;&gt;<br>
&gt;&gt; &lt;error&gt;<br>
&gt;&gt;<br>
&gt;&gt; Fault reason is &quot;Operation Failed&quot;. Fault detail is &quot;[Failed to attach<br>
&gt;&gt; Storage due to an error on the Data Center master Storage Domain.<br>
&gt;&gt; -Please activate the master Storage Domain first.]&quot;. HTTP response code is<br>
&gt;&gt; 409.<br>
&gt;&gt;<br>
&gt;&gt; &lt;/error&gt;<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; --<br>
&gt;&gt; Barak Korren<br>
&gt;&gt; RHV DevOps team , RHCE, RHCi<br>
&gt;&gt; Red Hat EMEA<br>
&gt;&gt; <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" rel="noreferrer" target="_blank">redhat.com/trusted</a><br>
&gt;&gt; ______________________________<wbr>_________________<br>
&gt;&gt; Devel mailing list<br>
&gt;&gt; <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
&gt;&gt; <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<br>
<br>
<br>
--<br>
Barak Korren<br>
RHV DevOps team , RHCE, RHCi<br>
Red Hat EMEA<br>
<a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" rel="noreferrer" target="_blank">redhat.com/trusted</a><br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>